From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF8D7A0A0E; Fri, 4 Jun 2021 00:29:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57C2E40698; Fri, 4 Jun 2021 00:29:27 +0200 (CEST) Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id D5F1F4068F for ; Fri, 4 Jun 2021 00:29:25 +0200 (CEST) Received: by mail-lf1-f48.google.com with SMTP id r198so7794272lff.11 for ; Thu, 03 Jun 2021 15:29:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=I1l+2jfTRrFM3C2ItEAB2HVCXP0yJ4sKCgXuByVaLmw=; b=QdvjxJhaQyeb17r9hd9LWcdj7BdeH02gfpTJRCtkooX1Q2O0DuqrIOUhFFpljhZv+S utwaPRpA9hqmsIEvo3Ke+/ROnTami1oBy0xA/zsx2DRVoNT6ttdahD7V6BwSsppRowLr 1PfWKRfuaYaXjNNSkK0z3bM5zUEHVJNRlySyEJsWSx2Wbxy2iPYYQEhRivsIIEbFgVz2 z+qjJCFDgIZvf1dzP9yz4Az+l6RgNYAqzf7I/L3Mub6ob+I9y+3/GIO5af/rrGV9D2fQ 2Bg6mkU85cRudA8XvJXd8iWLW0TNk8YSIRwxkHtFWhraeQrVsdiZZJRU3EcN1EZsWPMo JDEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=I1l+2jfTRrFM3C2ItEAB2HVCXP0yJ4sKCgXuByVaLmw=; b=GsTdzfa8VI76BDxDuAU0mLT1Qr0Di4Dbe9DKdwawS/KWgbdhqTq/Q1tGIs4BDf8WSo JTeZMuXCsVDyp5BkVRjTqH1d1gHQWPixKFskBx1mVHv2t3aAy4j1Npb6aprD6+bilFGU iJaeoXL04Hhu00o3BEuVb9VBCE9omnF6xuCp+rXivP5lZP0O9ChbFr9W146KMYIY0DGQ snWAxOotZnX3H9jjeIKol+Hobyyrzn6+yp+TDDgNjK1af+UKjJbL7t+VQdBR0RZwcDXm hIYde+FjqPs0qfCYaimXY/JeoHnw35V9iEFpb2sZWWMZwpaQ1Ed3Q3r2Z8w9KxEXMmka dsbA== X-Gm-Message-State: AOAM531rxDvkYZu41JGCnzT/b9/ESIHzOx2rLaFLtYqfWCqKkIlC98ae Yuj4R7Q7P6nQiWcBn0zw2WE= X-Google-Smtp-Source: ABdhPJyJEROEfFxCVRENbyjen9D1r9YQMZZ7O8I5qy24iXsvE5qaWaMwnqFvkCrlisnT0mJN9xgH+A== X-Received: by 2002:a19:a406:: with SMTP id q6mr703395lfc.616.1622759365319; Thu, 03 Jun 2021 15:29:25 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id b17sm434612lfc.153.2021.06.03.15.29.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jun 2021 15:29:24 -0700 (PDT) Date: Fri, 4 Jun 2021 01:29:22 +0300 From: Dmitry Kozlyuk To: David Marchand Cc: dev@dpdk.org, Igor Russkikh , Aaron Conole , Michael Santana , Bruce Richardson , Rasesh Mody , Shahed Shaikh , Qiming Yang , Qi Zhang , Heinrich Kuhn , Devendra Singh Rawat , Ray Kinsella , Neil Horman , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam Message-ID: <20210604012922.63574cff@sovereign> In-Reply-To: <20210603165512.7357-3-david.marchand@redhat.com> References: <20210602095836.24901-1-david.marchand@redhat.com> <20210603165512.7357-1-david.marchand@redhat.com> <20210603165512.7357-3-david.marchand@redhat.com> X-Mailer: Claws Mail 3.17.6 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 2/2] eal: handle compressed firmwares X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2021-06-03 18:55 (UTC+0200), David Marchand: [...] > diff --git a/config/meson.build b/config/meson.build > index 017bb2efbb..c6985139b4 100644 > --- a/config/meson.build > +++ b/config/meson.build > @@ -172,6 +172,13 @@ if libexecinfo.found() and cc.has_header('execinfo.h') > dpdk_extra_ldflags += '-lexecinfo' > endif > > +libarchive = dependency('libarchive', required: false, method: 'pkg-config') > +if libarchive.found() > + dpdk_conf.set('RTE_HAS_LIBARCHIVE', 1) > + add_project_link_arguments('-larchive', language: 'c') > + dpdk_extra_ldflags += '-larchive' > +endif > + Suggestion: diff --git a/config/meson.build b/config/meson.build index c6985139b4..c3668798c1 100644 --- a/config/meson.build +++ b/config/meson.build @@ -175,7 +175,6 @@ endif libarchive = dependency('libarchive', required: false, method: 'pkg-config') if libarchive.found() dpdk_conf.set('RTE_HAS_LIBARCHIVE', 1) - add_project_link_arguments('-larchive', language: 'c') dpdk_extra_ldflags += '-larchive' endif diff --git a/lib/eal/meson.build b/lib/eal/meson.build index 1722924f67..5a018d97d6 100644 --- a/lib/eal/meson.build +++ b/lib/eal/meson.build @@ -16,6 +16,7 @@ subdir(exec_env) subdir(arch_subdir) deps += ['kvargs'] +ext_deps += libarchive if not is_windows deps += ['telemetry'] endif