DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] event/cnxk: fix clang warning on Arm
@ 2021-06-10  7:25 Ruifeng Wang
  2021-06-18  7:21 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula
  0 siblings, 1 reply; 2+ messages in thread
From: Ruifeng Wang @ 2021-06-10  7:25 UTC (permalink / raw)
  To: Pavan Nikhilesh, Shijith Thotton; +Cc: dev, nd, Ruifeng Wang

Build with Clang-10 has warning:
drivers/event/cnxk/cnxk_tim_worker.h:372:23: warning: value size does not match register size specified by the constraint and modifier [-Wasm-operand-widths]
                             : [rem] "=&r"(rem)
                                           ^
drivers/event/cnxk/cnxk_tim_worker.h:365:17: note: use constraint modifier "w"
                             "          ldxr %[rem], [%[crem]]  \n"
                                             ^~~~~~
                                             %w[rem]

Changed variable type to match register size, which placates clang.

Fixes: 300b796262a1 ("event/cnxk: add timer arm routine")
Cc: pbhagavatula@marvell.com

Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 drivers/event/cnxk/cnxk_tim_worker.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/event/cnxk/cnxk_tim_worker.h b/drivers/event/cnxk/cnxk_tim_worker.h
index 7caeb1a8fb..78e36ffafe 100644
--- a/drivers/event/cnxk/cnxk_tim_worker.h
+++ b/drivers/event/cnxk/cnxk_tim_worker.h
@@ -320,7 +320,7 @@ cnxk_tim_add_entry_mp(struct cnxk_tim_ring *const tim_ring,
 	struct cnxk_tim_ent *chunk;
 	struct cnxk_tim_bkt *bkt;
 	uint64_t lock_sema;
-	int16_t rem;
+	int64_t rem;
 
 __retry:
 	cnxk_tim_get_target_bucket(tim_ring, rel_bkt, &bkt, &mirr_bkt);
-- 
2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [EXT] [PATCH] event/cnxk: fix clang warning on Arm
  2021-06-10  7:25 [dpdk-dev] [PATCH] event/cnxk: fix clang warning on Arm Ruifeng Wang
@ 2021-06-18  7:21 ` Pavan Nikhilesh Bhagavatula
  0 siblings, 0 replies; 2+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2021-06-18  7:21 UTC (permalink / raw)
  To: Ruifeng Wang, Shijith Thotton; +Cc: dev, nd



>-----Original Message-----
>From: Ruifeng Wang <ruifeng.wang@arm.com>
>Sent: Thursday, June 10, 2021 12:55 PM
>To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Shijith
>Thotton <sthotton@marvell.com>
>Cc: dev@dpdk.org; nd@arm.com; Ruifeng Wang
><ruifeng.wang@arm.com>
>Subject: [EXT] [PATCH] event/cnxk: fix clang warning on Arm
>
>External Email
>
>----------------------------------------------------------------------
>Build with Clang-10 has warning:
>drivers/event/cnxk/cnxk_tim_worker.h:372:23: warning: value size
>does not match register size specified by the constraint and modifier [-
>Wasm-operand-widths]
>                             : [rem] "=&r"(rem)
>                                           ^
>drivers/event/cnxk/cnxk_tim_worker.h:365:17: note: use constraint
>modifier "w"
>                             "          ldxr %[rem], [%[crem]]  \n"
>                                             ^~~~~~
>                                             %w[rem]
>
>Changed variable type to match register size, which placates clang.
>
>Fixes: 300b796262a1 ("event/cnxk: add timer arm routine")
>Cc: pbhagavatula@marvell.com
>
>Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>

LGTM, thanks.

Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

>---
> drivers/event/cnxk/cnxk_tim_worker.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/event/cnxk/cnxk_tim_worker.h
>b/drivers/event/cnxk/cnxk_tim_worker.h
>index 7caeb1a8fb..78e36ffafe 100644
>--- a/drivers/event/cnxk/cnxk_tim_worker.h
>+++ b/drivers/event/cnxk/cnxk_tim_worker.h
>@@ -320,7 +320,7 @@ cnxk_tim_add_entry_mp(struct cnxk_tim_ring
>*const tim_ring,
> 	struct cnxk_tim_ent *chunk;
> 	struct cnxk_tim_bkt *bkt;
> 	uint64_t lock_sema;
>-	int16_t rem;
>+	int64_t rem;
>
> __retry:
> 	cnxk_tim_get_target_bucket(tim_ring, rel_bkt, &bkt,
>&mirr_bkt);
>--
>2.25.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-18  7:21 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10  7:25 [dpdk-dev] [PATCH] event/cnxk: fix clang warning on Arm Ruifeng Wang
2021-06-18  7:21 ` [dpdk-dev] [EXT] " Pavan Nikhilesh Bhagavatula

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git