DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stanislaw Kardach <kda@semihalf.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dev@dpdk.org, upstream@semihalf.com
Subject: Re: [dpdk-dev] [PATCH v2 0/3] Increase test compatibility with PA IOVA
Date: Thu, 10 Jun 2021 09:51:09 +0200	[thread overview]
Message-ID: <20210610075109.6mcody2zaer3gdi2@toster> (raw)
In-Reply-To: <20210604141601.275430-1-kda@semihalf.com>

On Fri, Jun 04, 2021 at 04:15:58PM +0200, Stanislaw Kardach wrote:
> Please let me know if I'm missing a bigger picture with the --no-huge
> and --no-shconf usage on non-FreeBSD platforms.
> 
After looking at this issue again I'm abandoning this patchset because
it seems wrong for 2 reasons:

1. --iova-mode=pa and --no-huge combination is still unsupported but
   detecting such situation is not straightforward in the
   eal_flags_no_huge_autotest. That is because it is not only a product
   of user input but IOMMU requirements (if any), bus requirements and
   PA map availability. If a PCI device is bound to UIO and no IOMMU is
   avilable, then bus requests PA mapping. However if there's no UIO
   device, PCI reports DC and therefore decision relies on PA map
   availability. If it's not available, VA will be chosen. This changes
   between the parent dpdk-test binary being run (available->PA) and the
   child processes being spawned by the test (not-available->VA).
   However rte_eal_iova_mode() only reports the final IOVA mode. Even if
   in the parent process it is PA, it doesn't mean it will be so in
   the child process. So test will be skipped when it shouldn't.
2. Because of the above, the same test can pass on a non-IOMMU platform
   if no PCI device is bound to UIO while it would fail if there is a
   PCI device bound to UIO. It seems that the silent assumption is that
   fast-tests should be run without any UIO devices (or basically with
   all buses requestin DC IOVA mode).

Sorry for any confusion with this patchset.

-- 
Best Regards,
Stanislaw Kardach

      parent reply	other threads:[~2021-06-10  7:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-04 14:15 Stanislaw Kardach
2021-06-04 14:15 ` [dpdk-dev] [PATCH v2 1/3] test: disable no-huge test " Stanislaw Kardach
2021-06-04 14:16 ` [dpdk-dev] [PATCH v2 2/3] test: disable no-huge where it's not necessary Stanislaw Kardach
2021-06-04 14:16 ` [dpdk-dev] [PATCH v2 3/3] test: fix the -n unit test description Stanislaw Kardach
2021-06-10  7:51 ` Stanislaw Kardach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210610075109.6mcody2zaer3gdi2@toster \
    --to=kda@semihalf.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=upstream@semihalf.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).