From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 607FCA0C4A;
Tue, 15 Jun 2021 04:37:42 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 4B2804067A;
Tue, 15 Jun 2021 04:37:42 +0200 (CEST)
Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com
[209.85.215.180])
by mails.dpdk.org (Postfix) with ESMTP id C221B40140
for <dev@dpdk.org>; Tue, 15 Jun 2021 04:37:40 +0200 (CEST)
Received: by mail-pg1-f180.google.com with SMTP id w31so7728858pga.6
for <dev@dpdk.org>; Mon, 14 Jun 2021 19:37:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20150623.gappssmtp.com; s=20150623;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=0BLw6rs25AZTPGl4+lGAjg+KtYBaizpc3JTQFe60x8k=;
b=bPpy37B4EVLkzgpTQp1/TLPofAQ4+RSXbFFbRGA94yKTVTa8UWBNfFt4NVkYeriUDk
z7YpEkHzFM4ShfPLXX4uz0Jn8lJMk3dfm+LbncQL/8n6myP9DdQlULQI/pn09KLHNJS/
Qop11BToCiLRtwz+H3ba/rw9c5wzhtBtSucEZzf1I17X1d7NZ1LTgexGHMYIyY9x2cX9
hyoZcp8YLGG54VdQD+41DT+QhcAWuamsW/ImxKw9XVxFZA00jbwN7jczZbow41if8dHT
/+4/wRbMpHpVOfXr8+gBcrxW2qPqweac95wiCdQP/cPn8zfgDIZxbul9Qc1hTbTJ82xL
tJsQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=0BLw6rs25AZTPGl4+lGAjg+KtYBaizpc3JTQFe60x8k=;
b=HZJj4h0vhNqHZ2dA1XLx1PFYAwHw/+7OapIZNW/Et2Li2TjB3z7/D4j94WFCSS6jf4
zhEVG+5DSjkHHhVX8ZcaKIeQrE9H0MJY5r18/FghgLx4bKllzYq6iJC8QqwQbeNzNBV0
2RHGdo9EQUH4Qce9G1DObaotOzxdzgRcYl9/6RjjdPNoIlWdrRU+ellIPBGXrZ/3zlT4
Ro87KjdOvsnyLzZtUpWQfgNY/7jcyAGKhJzV+fxL3EOJWGT0pn4AisFDpbyzzVEdmqWe
RJ3no2q0iTh4KucN/vz1giah0JiyicgFnTJO4Bgus6bxe/sd2IiS72ofqAeauVQX1DIa
0oLw==
X-Gm-Message-State: AOAM531fOBin/YPObqj+sF4xE2UnXTm+tHbaSkAzZrbysiCf3g/oFdMt
pvD1aCyl2ijbxS/EgGMzzTYCHg==
X-Google-Smtp-Source: ABdhPJzd6b/vvaM8tTFCIGEXJLbU50EsLaC3VBJPAwOxepchkaVOBhA+anZPULVYg4UoCN/a2z7/Lg==
X-Received: by 2002:a63:3d8f:: with SMTP id
k137mr20154919pga.161.1623724660136;
Mon, 14 Jun 2021 19:37:40 -0700 (PDT)
Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44])
by smtp.gmail.com with ESMTPSA id s16sm5387677pfc.33.2021.06.14.19.37.39
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 14 Jun 2021 19:37:39 -0700 (PDT)
Date: Mon, 14 Jun 2021 19:37:37 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Min Hu (Connor)" <humin29@huawei.com>
Cc: <dev@dpdk.org>, <ferruh.yigit@intel.com>, <andrew.rybchenko@oktetlabs.ru>
Message-ID: <20210614193737.39f5151c@hermes.local>
In-Reply-To: <1623720869-26320-1-git-send-email-humin29@huawei.com>
References: <1623548576-34995-2-git-send-email-humin29@huawei.com>
<1623720869-26320-1-git-send-email-humin29@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] net/hns3: support Tx push quick doorbell
to improve perf
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Tue, 15 Jun 2021 09:34:29 +0800
"Min Hu (Connor)" <humin29@huawei.com> wrote:
> +void
> +hns3_tx_push_init(struct rte_eth_dev *dev)
> +{
> + struct hns3_hw *hw = HNS3_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> + volatile uint32_t *reg;
> + uint32_t val;
> +
> + if (!hns3_dev_tx_push_supported(hw))
> + return;
> +
> + reg = (volatile uint32_t *)hns3_tx_push_get_queue_tail_reg(dev, 0);
Better to use proper barrier function than using volatile.