From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57F7EA0C4B; Thu, 17 Jun 2021 17:21:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 18B094067A; Thu, 17 Jun 2021 17:21:57 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 4EA7740150 for ; Thu, 17 Jun 2021 17:21:56 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 9E3B020B6C50; Thu, 17 Jun 2021 08:21:55 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 9E3B020B6C50 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1623943315; bh=H78s6Ba84ydSu4D2iMA5ncKP8RqGwMfeann39YxpwfA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eUVNrs8+s8zYbRwLh8fGHug/rL0W92YAmUxBtpxnpEwNrAMloePK3k1E+7PWC+qeR Mqc5kDwQhOQ2Fr85C88AJtdwCAB69Ss7RAI2RzKVY5ByE9aCUtzRdP3d5ZTDpQUzin 3VVyCp1QO189m/CfmS2r60msrXBlCHLm+ZPh6mh4= Date: Thu, 17 Jun 2021 08:21:55 -0700 From: Tyler Retzlaff To: Joyce Kong Cc: thomas@monjalon.net, david.marchand@redhat.com, stephen@networkplumber.org, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru, harry.van.haaren@intel.com, honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com, dev@dpdk.org, nd@arm.com Message-ID: <20210617152155.GD29777@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20210604094624.31308-1-joyce.kong@arm.com> <20210616025459.22717-1-joyce.kong@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210616025459.22717-1-joyce.kong@arm.com> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v2 0/8] use GCC's C11 atomic builtins for test X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 15, 2021 at 09:54:51PM -0500, Joyce Kong wrote: > Since C11 memory model is adopted in DPDK now[1], use GCC's > atomic builtins in test cases. as previously discussed these atomics are not "C11" they are direct use of gcc builtins. please don't incorporate C11 into the title of the patches or commit messages since it isn't. please do not integrate a patch that directly uses gcc builtins and extensions please maintain abstractions under the rte_ namespace. specifically this patch substantially increases coupling to a single compiler implementation reducing portability. as previously requested, please establish at a minimum macros in the rte_ namespace for this. thanks. > > [1] https://www.dpdk.org/blog/2021/03/26/dpdk-adopts-the-c11-memory-model/ > > v2: > Use rte_wait_until_equal() instead of original sync loops. > > > v1: > The initial version. > > Joyce Kong (8): > test/ticketlock: use GCC atomic builtins for lcores sync > test/spinlock: use GCC atomic builtins for lcores sync > test/rwlock: use GCC atomic builtins for lcores sync > test/mcslock: use GCC atomic builtins for lcores sync > test/mempool: remove unused variable for lcores sync > test/mempool_perf: use GCC atomic builtins for lcores sync > test/service_cores: use GCC atomic builtins for lock sync > test/rcu: use GCC atomic builtins for data sync > > app/test/test_mcslock.c | 14 +++-- > app/test/test_mempool.c | 5 -- > app/test/test_mempool_perf.c | 11 ++-- > app/test/test_rcu_qsbr_perf.c | 98 +++++++++++++++++------------------ > app/test/test_rwlock.c | 10 ++-- > app/test/test_service_cores.c | 36 +++++++------ > app/test/test_spinlock.c | 9 ++-- > app/test/test_ticketlock.c | 10 ++-- > 8 files changed, 91 insertions(+), 102 deletions(-) > > -- > 2.17.1