From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09B2CA0A0C; Fri, 18 Jun 2021 23:53:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9D2AA410DE; Fri, 18 Jun 2021 23:53:29 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 57B2340150 for ; Fri, 18 Jun 2021 23:53:28 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1059) id A308320B7178; Fri, 18 Jun 2021 14:53:27 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com A308320B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1624053207; bh=Cfw7YnpTjj81Y8sHRANvgWX7y88Sks2EalEP81Go7R8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=JQF+q7jj9WMFgyDuBI6XFCe4ATun0NzxaHYZZUNaDOsLYNigHI10E4p0v5qPVf/gM zesL6Mg4EKlYrSQTlTfrsRGkp56WmIbNi2SfIA6EAix0Kf5RGIANRMofRr/vNne/D7 uSIVNJuSgRGp1C0O+2ggrljgMN2bFfxTEloF5984= Date: Fri, 18 Jun 2021 14:53:27 -0700 From: Narcisa Ana Maria Vasile To: David Marchand Cc: dev , Thomas Monjalon , Dmitry Kozlyuk , Khoa To , navasile@microsoft.com, "Dmitry Malloy (MESHCHANINOV)" , roretzla@microsoft.com, Tal Shnaiderman , Omar Cardona , Bruce Richardson , Pallavi Kadam Message-ID: <20210618215327.GB30249@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1622849908-5710-1-git-send-email-navasile@linux.microsoft.com> <1622850274-6946-1-git-send-email-navasile@linux.microsoft.com> <1622850274-6946-11-git-send-email-navasile@linux.microsoft.com> <20210608055033.GA20476@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v9 10/10] Enable the new EAL thread API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 08, 2021 at 09:45:44AM +0200, David Marchand wrote: > On Tue, Jun 8, 2021 at 7:50 AM Narcisa Ana Maria Vasile > wrote: > > > > On Fri, Jun 04, 2021 at 04:44:34PM -0700, Narcisa Ana Maria Vasile wrote: > > > From: Narcisa Vasile > > > > > > Rename pthread_* occurrences with the new rte_thread_* API. > > > Enable the new API in the build system. > > > > > > Signed-off-by: Narcisa Vasile > > > --- > > > > I'll send v10. > > Can someone please help with an example on how to check for ABI breaks? Thank you! > > > > I've run: > > DPDK_ABI_REF_VERSION=v21.05 DPDK_ABI_REF_DIR=~/ref ./devtools/test-meson-builds.sh > > which doesn't give any warnings about the ABI break. > > This should work the way you tried if you have working toolchains and > libabigail installed. > Something is off in your env. > > Side note: ovsrobot is out those days (we have some trouble in one of > RH labs and it happens ovsrobot is hosted there), but you could try > with a github repo of yours + GHA, and the ABI failure should be > caught too. > > > I just tried on my rhel7 (gcc 4.8.5 + libabigail 1.8.2) with your > series applied. > $ DPDK_ABI_REF_VERSION=v21.05 > DPDK_ABI_REF_DIR=~/git/pub/dpdk.org/reference > ./devtools/test-meson-builds.sh > ... > Error: ABI issue reported for 'abidiff --suppr > /home/dmarchan/git/pub/dpdk.org/devtools/../devtools/libabigail.abignore > --no-added-syms --headers-dir1 > /home/dmarchan/git/pub/dpdk.org/reference/v21.05/build-gcc-shared/usr/local/include > --headers-dir2 /home/dmarchan/git/pub/dpdk.org/build-gcc-shared/install/usr/local/include > /home/dmarchan/git/pub/dpdk.org/reference/v21.05/build-gcc-shared/dump/librte_eal.dump > /home/dmarchan/git/pub/dpdk.org/build-gcc-shared/install/dump/librte_eal.dump' > ABIDIFF_ABI_CHANGE, this change requires a review (abidiff flagged > this as a potential issue). > > > $ abidiff --suppr > /home/dmarchan/git/pub/dpdk.org/devtools/../devtools/libabigail.abignore > --no-added-syms --headers-dir1 > /home/dmarchan/git/pub/dpdk.org/reference/v21.05/build-gcc-shared/usr/local/include > --headers-dir2 /home/dmarchan/git/pub/dpdk.org/build-gcc-shared/install/usr/local/include > /home/dmarchan/git/pub/dpdk.org/reference/v21.05/build-gcc-shared/dump/librte_eal.dump > /home/dmarchan/git/pub/dpdk.org/build-gcc-shared/install/dump/librte_eal.dump > Functions changes summary: 0 Removed, 2 Changed (1 filtered out), 0 > Added (20 filtered out) functions > Variables changes summary: 0 Removed, 0 Changed, 0 Added variable > > 2 functions with some indirect sub-type change: > > [C] 'function int rte_ctrl_thread_create(pthread_t*, const char*, > const pthread_attr_t*, void* (void*)*, void*)' at rte_lcore.h:443:1 > has some indirect sub-type changes: > parameter 1 of type 'pthread_t*' changed: > in pointed to type 'typedef pthread_t' at rte_thread.h:42:1: > typedef name changed from pthread_t to rte_thread_t at rte_thread.h:42:1 > underlying type 'unsigned long int' changed: > entity changed from 'unsigned long int' to 'struct > rte_thread_tag' at rte_thread.h:40:1 > type size hasn't changed > parameter 3 of type 'const pthread_attr_t*' changed: > in pointed to type 'const pthread_attr_t': > 'const pthread_attr_t' changed to 'const rte_thread_attr_t' > > [C] 'function int rte_thread_setname(pthread_t, const char*)' at > rte_lcore.h:377:1 has some indirect sub-type changes: > parameter 1 of type 'typedef pthread_t' changed: > typedef name changed from pthread_t to rte_thread_t at rte_thread.h:42:1 > underlying type 'unsigned long int' changed: > entity changed from 'unsigned long int' to 'struct > rte_thread_tag' at rte_thread.h:40:1 > type size hasn't changed > > > > Can you check that in your env build-gcc-shared/ and the build > directory for references are configured with debug symbols? > You should see: > $ meson configure build-gcc-shared | awk '$1=="buildtype" {print $2}' > debugoptimized > $ meson configure reference/v21.05/build | awk '$1=="buildtype" {print $2}' > debugoptimized > > Thank you very much David! There was something wrong with my local reference. Using your commands, I am able to run the tools now. >