From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 90A90A0547; Mon, 21 Jun 2021 20:18:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7DBEB411C9; Mon, 21 Jun 2021 20:18:04 +0200 (CEST) Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by mails.dpdk.org (Postfix) with ESMTP id D875540040 for ; Mon, 21 Jun 2021 20:18:03 +0200 (CEST) Received: by mail-pf1-f177.google.com with SMTP id x16so14277810pfa.13 for ; Mon, 21 Jun 2021 11:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XmhJCb32E/aMmuOUPwhs1DcYeBTQvBqfnaRGZIOBo3o=; b=kA0nItmwOPpadZho2EdMtAAN2brNh5PVpWy2/Cd6NY27KpOCsKSdNx8JM2zKQWVOIu qdnpPvWY76+YZTKoX8Cl5CyriS0iFbCph6XDP4Yb4psZGPl2M9w18zlsUI813lN2pTyP XXUFNQ+m2PUQ6LslCsCrgzC2WCtq1KrtcoDj1eWV7IH+PbVw2DEJeKDWBgRJoYOnceb/ eKhrEezo8hnMAFDZ14mgylG6MDHlSbLjlNotJlO+0kWXtQeP2k0zVJblsRQOGv5UXctl 5JilqEIGX4iHS36LVUVvA3DAM1RvaabNRAX0fb8ZtcsqdDWLPr/wtuWIWSphR8svKdsx O8lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XmhJCb32E/aMmuOUPwhs1DcYeBTQvBqfnaRGZIOBo3o=; b=nyhi7I/jnUViHl7jDlJr3P4Mdtxc4u+0zH2GsbFD2YV82rPLvs/BGPVagzhab5Sz+4 YQ/VnOWUTnSDuua7mkYcqqWGzraH4nRYsfdcd0iBYd5BELoGMCtqe1SUAFNEF/VLxoqI puME7qr1oiNBHHGHUdCfUgtjqFMWZETFiLWUr3WTvqfCPOLwRR0DNW2+fjrmFcd4G3t4 twS5GZOYwk366QZfKEhWZ0o5Qi8H2WPdLmGKvuVQn1CLVaEw83rJ0eC9Ei9N5heD0YXJ H4VUbpE4u5YuHsMKmF4DPlCo7U0cmLRvB13aNDLSBVpuTg06MhrXTIWU0Xw3++fqNgJx pm9Q== X-Gm-Message-State: AOAM532tKyntGinmLTYCU1bSvN12KdZs0aSiq+1izqvAObzOKKHWp8j+ TpvmcYJLhyXG+cVotRUqS+1Dyw== X-Google-Smtp-Source: ABdhPJxEoY1ZPFmr+uFMr2PaAWaBpi/yx4PwolW2bIpBaka/Py8ERU+lJ5K4oUDbFP0AAWX6LwK5yA== X-Received: by 2002:a63:4302:: with SMTP id q2mr24912847pga.428.1624299483014; Mon, 21 Jun 2021 11:18:03 -0700 (PDT) Received: from hermes.local (76-14-218-44.or.wavecable.com. [76.14.218.44]) by smtp.gmail.com with ESMTPSA id y20sm18258325pfb.207.2021.06.21.11.18.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 11:18:02 -0700 (PDT) Date: Mon, 21 Jun 2021 11:17:59 -0700 From: Stephen Hemminger To: "Liguzinski, WojciechX" Cc: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, savinay.dharmappa@intel.com, megha.ajmera@intel.com Message-ID: <20210621111759.30cae7c2@hermes.local> In-Reply-To: <20210621073506.96017-2-wojciechx.liguzinski@intel.com> References: <20210615090200.56824-1-wojciechx.liguzinski@intel.com> <20210621073506.96017-1-wojciechx.liguzinski@intel.com> <20210621073506.96017-2-wojciechx.liguzinski@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC PATCH v3 1/3] sched: add PIE based congestion management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 21 Jun 2021 08:35:04 +0100 "Liguzinski, WojciechX" wrote: > +/** > + * @brief Initialises run-time data > + * > + * @param pie [in,out] data pointer to PIE runtime data > + * > + * @return Operation status > + * @retval 0 success > + * @retval !0 error > + */ > +int > +rte_pie_rt_data_init(struct rte_pie *pie); All the new code needs to be marked experimental. Why return an error on the init() function, then you are going to make application check the result and lead to lots more code. Other places in DPDK use void for init functions.