From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 331D9A0C41;
Wed, 23 Jun 2021 14:03:54 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id ACF494003F;
Wed, 23 Jun 2021 14:03:53 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
by mails.dpdk.org (Postfix) with ESMTP id A942A4003E
for <dev@dpdk.org>; Wed, 23 Jun 2021 14:03:51 +0200 (CEST)
IronPort-SDR: gdaHzEDGuJ/IR6bzhMczxDdLzDc92ByKVHicoaBomGIvxHoPLpfDhuEyyvpvMpAHZyTq4ckMpf
SV7oMqxa4OMg==
X-IronPort-AV: E=McAfee;i="6200,9189,10023"; a="228816254"
X-IronPort-AV: E=Sophos;i="5.83,293,1616482800"; d="scan'208";a="228816254"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
23 Jun 2021 05:03:49 -0700
IronPort-SDR: sRBQifh+EPUeVgb0VgCGnzpmVHjd/5QE2aL82CrMzweDM2XHvdEw5Y9O0buEdLO1xCGZnvAqSg
SLM/VKm38pdA==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.83,293,1616482800"; d="scan'208";a="487279918"
Received: from silpixa00399952.ir.intel.com ([10.55.129.13])
by orsmga001.jf.intel.com with ESMTP; 23 Jun 2021 05:03:47 -0700
From: David Hunt <david.hunt@intel.com>
To: dev@dpdk.org
Cc: david.hunt@intel.com, anatoly.burakov@intel.com, Richael.Zhuang@arm.com,
stephen@networkplumber.org, reshma.pattan@intel.com, nd@arm.com
Date: Wed, 23 Jun 2021 13:03:41 +0100
Message-Id: <20210623120342.36321-1-david.hunt@intel.com>
X-Mailer: git-send-email 2.17.1
In-Reply-To: <20210622125853.2798-1-david.hunt@intel.com>
References: <20210622125853.2798-1-david.hunt@intel.com>
Subject: [dpdk-dev] [PATCH v6 1/2] power: don't use rte prefix in internal
code
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
From: Anatoly Burakov <anatoly.burakov@intel.com>
Currently, ACPI code uses rte_power_info as the struct name, which
gives the appearance that this is an externally visible API. Fix to
use internal namespace.
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: David Hunt <david.hunt@intel.com>
---
lib/power/power_acpi_cpufreq.c | 34 +++++++++++++++++-----------------
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c
index d028a9947f..1b8c69cc8b 100644
--- a/lib/power/power_acpi_cpufreq.c
+++ b/lib/power/power_acpi_cpufreq.c
@@ -78,7 +78,7 @@ enum power_state {
/**
* Power info per lcore.
*/
-struct rte_power_info {
+struct acpi_power_info {
unsigned int lcore_id; /**< Logical core id */
uint32_t freqs[RTE_MAX_LCORE_FREQS]; /**< Frequency array */
uint32_t nb_freqs; /**< number of available freqs */
@@ -90,14 +90,14 @@ struct rte_power_info {
uint16_t turbo_enable; /**< Turbo Boost enable/disable */
} __rte_cache_aligned;
-static struct rte_power_info lcore_power_info[RTE_MAX_LCORE];
+static struct acpi_power_info lcore_power_info[RTE_MAX_LCORE];
/**
* It is to set specific freq for specific logical core, according to the index
* of supported frequencies.
*/
static int
-set_freq_internal(struct rte_power_info *pi, uint32_t idx)
+set_freq_internal(struct acpi_power_info *pi, uint32_t idx)
{
if (idx >= RTE_MAX_LCORE_FREQS || idx >= pi->nb_freqs) {
RTE_LOG(ERR, POWER, "Invalid frequency index %u, which "
@@ -133,7 +133,7 @@ set_freq_internal(struct rte_power_info *pi, uint32_t idx)
* governor will be saved for rolling back.
*/
static int
-power_set_governor_userspace(struct rte_power_info *pi)
+power_set_governor_userspace(struct acpi_power_info *pi)
{
FILE *f;
int ret = -1;
@@ -189,7 +189,7 @@ power_set_governor_userspace(struct rte_power_info *pi)
* sys file.
*/
static int
-power_get_available_freqs(struct rte_power_info *pi)
+power_get_available_freqs(struct acpi_power_info *pi)
{
FILE *f;
int ret = -1, i, count;
@@ -259,7 +259,7 @@ power_get_available_freqs(struct rte_power_info *pi)
* It is to fopen the sys file for the future setting the lcore frequency.
*/
static int
-power_init_for_setting_freq(struct rte_power_info *pi)
+power_init_for_setting_freq(struct acpi_power_info *pi)
{
FILE *f;
char fullpath[PATH_MAX];
@@ -299,7 +299,7 @@ power_acpi_cpufreq_check_supported(void)
int
power_acpi_cpufreq_init(unsigned int lcore_id)
{
- struct rte_power_info *pi;
+ struct acpi_power_info *pi;
uint32_t exp_state;
if (lcore_id >= RTE_MAX_LCORE) {
@@ -374,7 +374,7 @@ power_acpi_cpufreq_init(unsigned int lcore_id)
* needed by writing the sys file.
*/
static int
-power_set_governor_original(struct rte_power_info *pi)
+power_set_governor_original(struct acpi_power_info *pi)
{
FILE *f;
int ret = -1;
@@ -420,7 +420,7 @@ power_set_governor_original(struct rte_power_info *pi)
int
power_acpi_cpufreq_exit(unsigned int lcore_id)
{
- struct rte_power_info *pi;
+ struct acpi_power_info *pi;
uint32_t exp_state;
if (lcore_id >= RTE_MAX_LCORE) {
@@ -475,7 +475,7 @@ power_acpi_cpufreq_exit(unsigned int lcore_id)
uint32_t
power_acpi_cpufreq_freqs(unsigned int lcore_id, uint32_t *freqs, uint32_t num)
{
- struct rte_power_info *pi;
+ struct acpi_power_info *pi;
if (lcore_id >= RTE_MAX_LCORE) {
RTE_LOG(ERR, POWER, "Invalid lcore ID\n");
@@ -522,7 +522,7 @@ power_acpi_cpufreq_set_freq(unsigned int lcore_id, uint32_t index)
int
power_acpi_cpufreq_freq_down(unsigned int lcore_id)
{
- struct rte_power_info *pi;
+ struct acpi_power_info *pi;
if (lcore_id >= RTE_MAX_LCORE) {
RTE_LOG(ERR, POWER, "Invalid lcore ID\n");
@@ -540,7 +540,7 @@ power_acpi_cpufreq_freq_down(unsigned int lcore_id)
int
power_acpi_cpufreq_freq_up(unsigned int lcore_id)
{
- struct rte_power_info *pi;
+ struct acpi_power_info *pi;
if (lcore_id >= RTE_MAX_LCORE) {
RTE_LOG(ERR, POWER, "Invalid lcore ID\n");
@@ -581,7 +581,7 @@ power_acpi_cpufreq_freq_max(unsigned int lcore_id)
int
power_acpi_cpufreq_freq_min(unsigned int lcore_id)
{
- struct rte_power_info *pi;
+ struct acpi_power_info *pi;
if (lcore_id >= RTE_MAX_LCORE) {
RTE_LOG(ERR, POWER, "Invalid lcore ID\n");
@@ -598,7 +598,7 @@ power_acpi_cpufreq_freq_min(unsigned int lcore_id)
int
power_acpi_turbo_status(unsigned int lcore_id)
{
- struct rte_power_info *pi;
+ struct acpi_power_info *pi;
if (lcore_id >= RTE_MAX_LCORE) {
RTE_LOG(ERR, POWER, "Invalid lcore ID\n");
@@ -614,7 +614,7 @@ power_acpi_turbo_status(unsigned int lcore_id)
int
power_acpi_enable_turbo(unsigned int lcore_id)
{
- struct rte_power_info *pi;
+ struct acpi_power_info *pi;
if (lcore_id >= RTE_MAX_LCORE) {
RTE_LOG(ERR, POWER, "Invalid lcore ID\n");
@@ -647,7 +647,7 @@ power_acpi_enable_turbo(unsigned int lcore_id)
int
power_acpi_disable_turbo(unsigned int lcore_id)
{
- struct rte_power_info *pi;
+ struct acpi_power_info *pi;
if (lcore_id >= RTE_MAX_LCORE) {
RTE_LOG(ERR, POWER, "Invalid lcore ID\n");
@@ -674,7 +674,7 @@ power_acpi_disable_turbo(unsigned int lcore_id)
int power_acpi_get_capabilities(unsigned int lcore_id,
struct rte_power_core_capabilities *caps)
{
- struct rte_power_info *pi;
+ struct acpi_power_info *pi;
if (lcore_id >= RTE_MAX_LCORE) {
RTE_LOG(ERR, POWER, "Invalid lcore ID\n");
--
2.17.1