From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6C6ADA0C41; Wed, 23 Jun 2021 22:51:23 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE09040141; Wed, 23 Jun 2021 22:51:22 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id BD7D24003C; Wed, 23 Jun 2021 22:51:21 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1061) id F0E7420B7188; Wed, 23 Jun 2021 13:51:20 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com F0E7420B7188 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1624481480; bh=pREX5a+ICSH82U+B0BMQfAV6QmQjeP92VNvWtPY65Bw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Pur8mbzB3+pvWiGIPwYDjpXqEETrWiG/HU3PR60jbTqPAnHrQKEut3zkz+lXS/AAX RE8CQNemyAasG05i5WXow/nlyblld9EGjGWzwq2/eoOJe24wHklvDttGdWj29QgVXG p7QeJXOv1TxvgoMvRWCQbSBI+Ug6CmgHGDm3lXAA= Date: Wed, 23 Jun 2021 13:51:20 -0700 From: Jie Zhou To: Dmitry Kozlyuk Cc: dev@dpdk.org, xiaoyun.li@intel.com, roretzla@microsoft.com, talshn@nvidia.com, pallavi.kadam@intel.com, thomas@monjalon.net, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, stable@dpdk.org Message-ID: <20210623205120.GA20289@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1620236174-10676-1-git-send-email-jizh@linux.microsoft.com> <1620241931-28435-1-git-send-email-jizh@linux.microsoft.com> <1620241931-28435-3-git-send-email-jizh@linux.microsoft.com> <20210621022827.6f342d73@sovereign> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210621022827.6f342d73@sovereign> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v13 02/10] eal/windows: add necessary macros X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 21, 2021 at 02:28:27AM +0300, Dmitry Kozlyuk wrote: > 2021-05-05 12:12 (UTC-0700), Jie Zhou: > > Add required macros by testpmd on Windows in rte_os_shim.h > > > > Signed-off-by: Jie Zhou > > Signed-off-by: Jie Zhou > > Acked-by: Tal Shnaiderman > > --- > > lib/eal/windows/include/rte_os_shim.h | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/lib/eal/windows/include/rte_os_shim.h b/lib/eal/windows/include/rte_os_shim.h > > index 1b314733b..3763cae62 100644 > > --- a/lib/eal/windows/include/rte_os_shim.h > > +++ b/lib/eal/windows/include/rte_os_shim.h > > @@ -21,6 +21,7 @@ > > #define strdup(str) _strdup(str) > > #define strtok_r(str, delim, saveptr) strtok_s(str, delim, saveptr) > > #ifndef RTE_TOOLCHAIN_GCC > > +#define strcasecmp _stricmp > > #define strncasecmp(s1, s2, count) _strnicmp(s1, s2, count) > > #endif > > Please use macros with arguments, like in the next line. > This provides better error messages at call site > and IDE display a nice hint knowing the parameters. > > > > > @@ -38,6 +39,14 @@ > > #define IPPROTO_SCTP 132 > > #endif > > > > +#ifndef IPDEFTTL > > +#define IPDEFTTL 64 > > +#endif > > + > > +#ifndef S_ISREG > > +#define S_ISREG(mode) (((mode)&S_IFMT) == S_IFREG) > > +#endif > > + > > Missing spaces around `&`. Thanks Dmitry. Will fix both in V14.