* [dpdk-dev] [dpdk-dev v1] crypto/aesni_gcm: fix performance issue
@ 2021-06-29 12:36 Kai Ji
2021-06-29 15:19 ` [dpdk-dev] [dpdk-dev v2] " Kai Ji
0 siblings, 1 reply; 4+ messages in thread
From: Kai Ji @ 2021-06-29 12:36 UTC (permalink / raw)
To: dev; +Cc: roy.fan.zhang, Kai Ji, pablo.de.lara.guarch
This patch fixes the aesni_gcm performance issue on systems with AVX512
CPU flag presented but with VAES CPU flag missing, such as Skylake.
Fixes: 81fe96a0cece ("crypto/aesni_gcm: use architecture independent API")
Cc: pablo.de.lara.guarch@intel.com
Signed-off-by: Kai Ji <kai.ji@intel.com>
---
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
index bc87e44a9d..f8dea484b4 100644
--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
@@ -842,8 +842,14 @@ aesni_gcm_create(const char *name,
init_mb_mgr_avx2(mb_mgr);
break;
case RTE_AESNI_GCM_AVX512:
- dev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX512;
- init_mb_mgr_avx512(mb_mgr);
+ if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_VAES)) {
+ dev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX512;
+ init_mb_mgr_avx512(mb_mgr);
+ } else {
+ dev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX2;
+ init_mb_mgr_avx2(mb_mgr);
+ vector_mode = RTE_AESNI_GCM_AVX2;
+ }
break;
default:
AESNI_GCM_LOG(ERR, "Unsupported vector mode %u\n", vector_mode);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [dpdk-dev] [dpdk-dev v2] crypto/aesni_gcm: fix performance issue
2021-06-29 12:36 [dpdk-dev] [dpdk-dev v1] crypto/aesni_gcm: fix performance issue Kai Ji
@ 2021-06-29 15:19 ` Kai Ji
2021-06-29 15:25 ` Zhang, Roy Fan
0 siblings, 1 reply; 4+ messages in thread
From: Kai Ji @ 2021-06-29 15:19 UTC (permalink / raw)
To: dev; +Cc: roy.fan.zhang, Kai Ji, pablo.de.lara.guarch
This patch fixes the aesni_gcm performance issue on systems with AVX512
CPU flag presented but with VAES CPU flag missing, such as Skylake.
Fixes: 81fe96a0cece ("crypto/aesni_gcm: use architecture independent API")
Cc: pablo.de.lara.guarch@intel.com
Signed-off-by: Kai Ji <kai.ji@intel.com>
---
v2: Checkpatch fix
drivers/crypto/aesni_gcm/aesni_gcm_pmd.c | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
index bc87e44a9d..886e2a5aaa 100644
--- a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
+++ b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c
@@ -842,8 +842,14 @@ aesni_gcm_create(const char *name,
init_mb_mgr_avx2(mb_mgr);
break;
case RTE_AESNI_GCM_AVX512:
- dev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX512;
- init_mb_mgr_avx512(mb_mgr);
+ if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_VAES)) {
+ dev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX512;
+ init_mb_mgr_avx512(mb_mgr);
+ } else {
+ dev->feature_flags |= RTE_CRYPTODEV_FF_CPU_AVX2;
+ init_mb_mgr_avx2(mb_mgr);
+ vector_mode = RTE_AESNI_GCM_AVX2;
+ }
break;
default:
AESNI_GCM_LOG(ERR, "Unsupported vector mode %u\n", vector_mode);
--
2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-dev v2] crypto/aesni_gcm: fix performance issue
2021-06-29 15:19 ` [dpdk-dev] [dpdk-dev v2] " Kai Ji
@ 2021-06-29 15:25 ` Zhang, Roy Fan
2021-07-07 13:36 ` Akhil Goyal
0 siblings, 1 reply; 4+ messages in thread
From: Zhang, Roy Fan @ 2021-06-29 15:25 UTC (permalink / raw)
To: Ji, Kai, dev; +Cc: De Lara Guarch, Pablo
> -----Original Message-----
> From: Ji, Kai <kai.ji@intel.com>
> Sent: Tuesday, June 29, 2021 4:19 PM
> To: dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>; Ji, Kai <kai.ji@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>
> Subject: [dpdk-dev v2] crypto/aesni_gcm: fix performance issue
>
> This patch fixes the aesni_gcm performance issue on systems with AVX512
> CPU flag presented but with VAES CPU flag missing, such as Skylake.
>
> Fixes: 81fe96a0cece ("crypto/aesni_gcm: use architecture independent API")
> Cc: pablo.de.lara.guarch@intel.com
>
> Signed-off-by: Kai Ji <kai.ji@intel.com>
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [dpdk-dev v2] crypto/aesni_gcm: fix performance issue
2021-06-29 15:25 ` Zhang, Roy Fan
@ 2021-07-07 13:36 ` Akhil Goyal
0 siblings, 0 replies; 4+ messages in thread
From: Akhil Goyal @ 2021-07-07 13:36 UTC (permalink / raw)
To: Zhang, Roy Fan, Ji, Kai, dev; +Cc: De Lara Guarch, Pablo
> >
> > This patch fixes the aesni_gcm performance issue on systems with AVX512
> > CPU flag presented but with VAES CPU flag missing, such as Skylake.
> >
> > Fixes: 81fe96a0cece ("crypto/aesni_gcm: use architecture independent
> API")
> > Cc: pablo.de.lara.guarch@intel.com
> >
> > Signed-off-by: Kai Ji <kai.ji@intel.com>
>
> Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Applied to dpdk-next-crypto
Thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-07 13:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29 12:36 [dpdk-dev] [dpdk-dev v1] crypto/aesni_gcm: fix performance issue Kai Ji
2021-06-29 15:19 ` [dpdk-dev] [dpdk-dev v2] " Kai Ji
2021-06-29 15:25 ` Zhang, Roy Fan
2021-07-07 13:36 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).