From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D735CA0A0C; Tue, 29 Jun 2021 20:29:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7684C411A5; Tue, 29 Jun 2021 20:29:08 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 179EC40E01; Tue, 29 Jun 2021 20:29:07 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1061) id 67AD220B7178; Tue, 29 Jun 2021 11:29:06 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 67AD220B7178 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1624991346; bh=s3fagXCTpp6C7XKsgM0G1J+ivd5KtFSxseqptbKl8eA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZsbRcO0ro/jO/szttSuenztbbrGvOIgQ/W2noAd9d4chw8k2gS6E8xxZzeImzpkxU OC9yqvXC4a+YKCCTrniPyDU4dRPps9FBZHrF7O/llAgy5lUl9BumcWKeffHi1h+EUp L20J0wOBA28FuOmOvMaMT+/H40zSZd32K5QfLScM= Date: Tue, 29 Jun 2021 11:29:06 -0700 From: Jie Zhou To: Tyler Retzlaff ;, andrew.rybchenko@oktetlabs.ru Cc: Andrew Rybchenko , dev@dpdk.org, dmitry.kozliuk@gmail.com, xiaoyun.li@intel.com, roretzla@microsoft.com, talshn@nvidia.com, pallavi.kadam@intel.com, thomas@monjalon.net, bruce.richardson@intel.com, ferruh.yigit@intel.com, konstantin.ananyev@intel.com, stable@dpdk.org Message-ID: <20210629182906.GA23474@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1620241931-28435-1-git-send-email-jizh@linux.microsoft.com> <1624487698-31136-1-git-send-email-jizh@linux.microsoft.com> <1624487698-31136-2-git-send-email-jizh@linux.microsoft.com> <681deaed-fbbf-998f-65cf-9990b0cdcdaf@oktetlabs.ru> <20210628141001.GA28256@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210628141001.GA28256@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [dpdk-dev] [PATCH v14 1/9] lib: build libraries that testpmd depends on X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 28, 2021 at 07:10:01AM -0700, Tyler Retzlaff wrote: > On Mon, Jun 28, 2021 at 01:35:09PM +0300, Andrew Rybchenko wrote: > > On 6/28/21 1:01 PM, Andrew Rybchenko wrote: > > >On 6/24/21 1:34 AM, Jie Zhou wrote: > > >>Enable building libraries that testpmd depends on for Windows > > >> > > >>Signed-off-by: Jie Zhou > > >>Signed-off-by: Jie Zhou > > > > > >Why are two a bit difference Signed-off-by used in these > > >patches? Can we drop the first one and keep the second one > > >which matches E-mail From? > > > > In fact looking at git log I see both E-mail addresses > > present, but it looks like the first one (w/o linux.) is > > used more often. > > yes, the CI system rejects the patch without the first because it > doesn't match the original commit. it also rejects without the second > because it needs to match the dev email list subscriber mail so both > have been provided to pass CI. > > i think future patches submitted won't be an issue because git local > config for the dpdk clone has been changed to match the second which is > also the subscription mail but changing the config doesn't re-write > the history on the commits (and it shouldn't). Yes, the first one was originally manually added due to some CI warning. Double checked git config on local dpdk clone and ensured the user.email matches the second one. Will remove the first one in V15 and investigate if CI still complains. Thanks.