From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 8E608A0A0C;
Tue, 29 Jun 2021 20:34:42 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1BFE1411A5;
Tue, 29 Jun 2021 20:34:42 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
by mails.dpdk.org (Postfix) with ESMTP id A522940E01;
Tue, 29 Jun 2021 20:34:40 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1061)
id BE78620B7178; Tue, 29 Jun 2021 11:34:39 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com BE78620B7178
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
s=default; t=1624991679;
bh=g8GrlGuxC1Yfkh2EeDikE5LDo3inHrnWB3Hjy838BCM=;
h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
b=ZIFEqyGRMO6Mj4EiE/iZ+3UCH+9bvNAwTP1w5NZm0PhbfZANDhkdG+EhUlgsB/eME
Ivo7Nb7vGsncSsUwC4QwP+ff5aWmpupwPJHqjRv/W/aJyuaXpHN5YGnL5Ui6oQ6UDK
729Hiwo3MwRHPp30cx8/8YiEziTHSkdix89DrKNU=
Date: Tue, 29 Jun 2021 11:34:39 -0700
From: Jie Zhou <jizh@linux.microsoft.com>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>;,
andrew.rybchenko@oktetlabs.ru
Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, dev@dpdk.org,
dmitry.kozliuk@gmail.com, xiaoyun.li@intel.com,
roretzla@microsoft.com, talshn@nvidia.com, pallavi.kadam@intel.com,
thomas@monjalon.net, bruce.richardson@intel.com,
ferruh.yigit@intel.com, konstantin.ananyev@intel.com, stable@dpdk.org
Message-ID: <20210629183439.GA28401@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1620241931-28435-1-git-send-email-jizh@linux.microsoft.com>
<1624487698-31136-1-git-send-email-jizh@linux.microsoft.com>
<1624487698-31136-7-git-send-email-jizh@linux.microsoft.com>
<aa6ecc9a-3e77-8c96-03b7-c2df9a94f0db@oktetlabs.ru>
<20210628142911.GB28256@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210628142911.GB28256@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Subject: Re: [dpdk-dev] [PATCH v14 6/9] app/testpmd: fix parse_fec_mode
return type name
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Mon, Jun 28, 2021 at 07:29:11AM -0700, Tyler Retzlaff wrote:
> On Mon, Jun 28, 2021 at 01:55:02PM +0300, Andrew Rybchenko wrote:
> > On 6/24/21 1:34 AM, Jie Zhou wrote:
> > >Replace parse_fec_mode misleading return type name mode with fec_capa
> > >
> > >Fixes: b19da32e3151 ("app/testpmd: add FEC command")
> > >Cc: stable@dpdk.org
> > >
> > >Signed-off-by: Jie Zhou <jizh@microsoft.com>
> > >Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> >
> > [snip]
> >
> > >diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
> > >index 283b5e3680..9ae4d90dd1 100644
> > >--- a/app/test-pmd/testpmd.h
> > >+++ b/app/test-pmd/testpmd.h
> > >@@ -885,7 +885,7 @@ void show_tx_pkt_segments(void);
> > > void set_tx_pkt_times(unsigned int *tx_times);
> > > void show_tx_pkt_times(void);
> > > void set_tx_pkt_split(const char *name);
> > >-int parse_fec_mode(const char *name, enum rte_eth_fec_mode *mode);
> > >+int parse_fec_mode(const char *name, uint32_t *fec_capa);
> >
> > I guess that the real reason behind is to fix implicit
> > conversion of enum pointer to/from uint32_t pointer.
> > I guess the problem is different signness of enum on
> > Windows compiler.
>
> yes, compilers targeting targets will select `int' once all constants of
> the enumeration list are defined.
>
> >
> > If so, please, put real motivation of the changeset in summary.
> > It should be human-readable (and do not contain function name).
> > Explain details in the description.
> >
> > Yes, I agree that mode is misleading here and should be mentioned
> > in the description, but I guess it is not the root cause.
> > May be I'm wrong.
Your understanding on the root cause is corret. Will fix the description in V15. Thanks.