DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl field
@ 2021-07-05 11:52 Gregory Etelson
  2021-07-11 10:25 ` Gregory Etelson
  2021-07-13  7:29 ` [dpdk-dev] [PATCH v2] " Gregory Etelson
  0 siblings, 2 replies; 8+ messages in thread
From: Gregory Etelson @ 2021-07-05 11:52 UTC (permalink / raw)
  To: dev; +Cc: getelson, viacheslavo, Ori Kam, Xiaoyun Li

The new item allows PMD to offload IPv4 IHL field for matching,
if hardware supports that operation.

Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
 app/test-pmd/cmdline_flow.c                 | 12 +++++++++++-
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  1 +
 2 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 1c587bb7b8..c1c7b9a9f9 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -173,6 +173,7 @@ enum index {
 	ITEM_VLAN_INNER_TYPE,
 	ITEM_VLAN_HAS_MORE_VLAN,
 	ITEM_IPV4,
+	ITEM_IPV4_VER_IHL,
 	ITEM_IPV4_TOS,
 	ITEM_IPV4_ID,
 	ITEM_IPV4_FRAGMENT_OFFSET,
@@ -1071,6 +1072,7 @@ static const enum index item_vlan[] = {
 };
 
 static const enum index item_ipv4[] = {
+	ITEM_IPV4_VER_IHL,
 	ITEM_IPV4_TOS,
 	ITEM_IPV4_ID,
 	ITEM_IPV4_FRAGMENT_OFFSET,
@@ -2567,6 +2569,13 @@ static const struct token token_list[] = {
 		.next = NEXT(item_ipv4),
 		.call = parse_vc,
 	},
+	[ITEM_IPV4_VER_IHL] = {
+		.name = "version_ihl",
+		.help = "match header length",
+		.next = NEXT(item_ipv4, NEXT_ENTRY(UNSIGNED), item_param),
+		.args = ARGS(ARGS_ENTRY(struct rte_flow_item_ipv4,
+				     hdr.version_ihl)),
+	},
 	[ITEM_IPV4_TOS] = {
 		.name = "tos",
 		.help = "type of service",
@@ -8123,7 +8132,8 @@ update_fields(uint8_t *buf, struct rte_flow_item *item, uint16_t next_proto)
 		break;
 	case RTE_FLOW_ITEM_TYPE_IPV4:
 		ipv4 = (struct rte_ipv4_hdr *)buf;
-		ipv4->version_ihl = 0x45;
+		if (!ipv4->version_ihl)
+			ipv4->version_ihl = RTE_IPV4_VHL_DEF;
 		if (next_proto && ipv4->next_proto_id == 0)
 			ipv4->next_proto_id = (uint8_t)next_proto;
 		break;
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 33857acf54..ab7e91ad6c 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -3654,6 +3654,7 @@ This section lists supported pattern items and their attributes, if any.
 
 - ``ipv4``: match IPv4 header.
 
+  - ``version_ihl {unsigned}``: IPv4 version and IP header length.
   - ``tos {unsigned}``: type of service.
   - ``ttl {unsigned}``: time to live.
   - ``proto {unsigned}``: next protocol ID.
-- 
2.31.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl field
  2021-07-05 11:52 [dpdk-dev] [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl field Gregory Etelson
@ 2021-07-11 10:25 ` Gregory Etelson
  2021-07-13  7:29 ` [dpdk-dev] [PATCH v2] " Gregory Etelson
  1 sibling, 0 replies; 8+ messages in thread
From: Gregory Etelson @ 2021-07-11 10:25 UTC (permalink / raw)
  To: andrew.rybchenko, dev, Raslan Darawsheh
  Cc: Slava Ovsiienko, Ori Kam, Xiaoyun Li

Hello Andrew,

Can you estimate when that patch will be merged ?

Regards,
Gregory

> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Monday, July 5, 2021 14:52
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Xiaoyun Li
> <xiaoyun.li@intel.com>
> Subject: [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl
> field
> 
> The new item allows PMD to offload IPv4 IHL field for matching, if hardware
> supports that operation.
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> ---
>  app/test-pmd/cmdline_flow.c                 | 12 +++++++++++-
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  1 +
>  2 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 1c587bb7b8..c1c7b9a9f9 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -173,6 +173,7 @@ enum index {
>  	ITEM_VLAN_INNER_TYPE,
>  	ITEM_VLAN_HAS_MORE_VLAN,
>  	ITEM_IPV4,
> +	ITEM_IPV4_VER_IHL,
>  	ITEM_IPV4_TOS,
>  	ITEM_IPV4_ID,
>  	ITEM_IPV4_FRAGMENT_OFFSET,
> @@ -1071,6 +1072,7 @@ static const enum index item_vlan[] = {  };
> 
>  static const enum index item_ipv4[] = {
> +	ITEM_IPV4_VER_IHL,
>  	ITEM_IPV4_TOS,
>  	ITEM_IPV4_ID,
>  	ITEM_IPV4_FRAGMENT_OFFSET,
> @@ -2567,6 +2569,13 @@ static const struct token token_list[] = {
>  		.next = NEXT(item_ipv4),
>  		.call = parse_vc,
>  	},
> +	[ITEM_IPV4_VER_IHL] = {
> +		.name = "version_ihl",
> +		.help = "match header length",
> +		.next = NEXT(item_ipv4, NEXT_ENTRY(UNSIGNED),
> item_param),
> +		.args = ARGS(ARGS_ENTRY(struct rte_flow_item_ipv4,
> +				     hdr.version_ihl)),
> +	},
>  	[ITEM_IPV4_TOS] = {
>  		.name = "tos",
>  		.help = "type of service",
> @@ -8123,7 +8132,8 @@ update_fields(uint8_t *buf, struct rte_flow_item
> *item, uint16_t next_proto)
>  		break;
>  	case RTE_FLOW_ITEM_TYPE_IPV4:
>  		ipv4 = (struct rte_ipv4_hdr *)buf;
> -		ipv4->version_ihl = 0x45;
> +		if (!ipv4->version_ihl)
> +			ipv4->version_ihl = RTE_IPV4_VHL_DEF;
>  		if (next_proto && ipv4->next_proto_id == 0)
>  			ipv4->next_proto_id = (uint8_t)next_proto;
>  		break;
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 33857acf54..ab7e91ad6c 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -3654,6 +3654,7 @@ This section lists supported pattern items and
> their attributes, if any.
> 
>  - ``ipv4``: match IPv4 header.
> 
> +  - ``version_ihl {unsigned}``: IPv4 version and IP header length.
>    - ``tos {unsigned}``: type of service.
>    - ``ttl {unsigned}``: time to live.
>    - ``proto {unsigned}``: next protocol ID.
> --
> 2.31.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* [dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field
  2021-07-05 11:52 [dpdk-dev] [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl field Gregory Etelson
  2021-07-11 10:25 ` Gregory Etelson
@ 2021-07-13  7:29 ` Gregory Etelson
  2021-07-13  8:07   ` Andrew Rybchenko
  2021-07-13 11:11   ` Slava Ovsiienko
  1 sibling, 2 replies; 8+ messages in thread
From: Gregory Etelson @ 2021-07-13  7:29 UTC (permalink / raw)
  To: dev, andrew.rybchenko; +Cc: getelson, viacheslavo, Ori Kam, Xiaoyun Li

The new flow item allows PMD to offload IPv4 IHL field for matching,
if hardware supports that operation.

Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
v2: replace UNSIGNED with COMMON_UNSIGNED following 21.08 API change.
---
 app/test-pmd/cmdline_flow.c                 | 13 ++++++++++++-
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |  1 +
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index 8fc0e1469d..34e043621c 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -171,6 +171,7 @@ enum index {
 	ITEM_VLAN_INNER_TYPE,
 	ITEM_VLAN_HAS_MORE_VLAN,
 	ITEM_IPV4,
+	ITEM_IPV4_VER_IHL,
 	ITEM_IPV4_TOS,
 	ITEM_IPV4_ID,
 	ITEM_IPV4_FRAGMENT_OFFSET,
@@ -1069,6 +1070,7 @@ static const enum index item_vlan[] = {
 };
 
 static const enum index item_ipv4[] = {
+	ITEM_IPV4_VER_IHL,
 	ITEM_IPV4_TOS,
 	ITEM_IPV4_ID,
 	ITEM_IPV4_FRAGMENT_OFFSET,
@@ -2576,6 +2578,14 @@ static const struct token token_list[] = {
 		.next = NEXT(item_ipv4),
 		.call = parse_vc,
 	},
+	[ITEM_IPV4_VER_IHL] = {
+		.name = "version_ihl",
+		.help = "match header length",
+		.next = NEXT(item_ipv4, NEXT_ENTRY(COMMON_UNSIGNED),
+			     item_param),
+		.args = ARGS(ARGS_ENTRY(struct rte_flow_item_ipv4,
+				     hdr.version_ihl)),
+	},
 	[ITEM_IPV4_TOS] = {
 		.name = "tos",
 		.help = "type of service",
@@ -8193,7 +8203,8 @@ update_fields(uint8_t *buf, struct rte_flow_item *item, uint16_t next_proto)
 		break;
 	case RTE_FLOW_ITEM_TYPE_IPV4:
 		ipv4 = (struct rte_ipv4_hdr *)buf;
-		ipv4->version_ihl = 0x45;
+		if (!ipv4->version_ihl)
+			ipv4->version_ihl = RTE_IPV4_VHL_DEF;
 		if (next_proto && ipv4->next_proto_id == 0)
 			ipv4->next_proto_id = (uint8_t)next_proto;
 		break;
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 33857acf54..ab7e91ad6c 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -3654,6 +3654,7 @@ This section lists supported pattern items and their attributes, if any.
 
 - ``ipv4``: match IPv4 header.
 
+  - ``version_ihl {unsigned}``: IPv4 version and IP header length.
   - ``tos {unsigned}``: type of service.
   - ``ttl {unsigned}``: time to live.
   - ``proto {unsigned}``: next protocol ID.
-- 
2.31.1


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field
  2021-07-13  7:29 ` [dpdk-dev] [PATCH v2] " Gregory Etelson
@ 2021-07-13  8:07   ` Andrew Rybchenko
  2021-07-13  8:54     ` Gregory Etelson
  2021-07-13 11:11   ` Slava Ovsiienko
  1 sibling, 1 reply; 8+ messages in thread
From: Andrew Rybchenko @ 2021-07-13  8:07 UTC (permalink / raw)
  To: Ori Kam; +Cc: viacheslavo, Xiaoyun Li, Gregory Etelson, dev

@Ori, could you review it, please.

Thanks,
Andrew.

On 7/13/21 10:29 AM, Gregory Etelson wrote:
> The new flow item allows PMD to offload IPv4 IHL field for matching,
> if hardware supports that operation.
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> ---
> v2: replace UNSIGNED with COMMON_UNSIGNED following 21.08 API change.
> ---
>  app/test-pmd/cmdline_flow.c                 | 13 ++++++++++++-
>  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  1 +
>  2 files changed, 13 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> index 8fc0e1469d..34e043621c 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -171,6 +171,7 @@ enum index {
>  	ITEM_VLAN_INNER_TYPE,
>  	ITEM_VLAN_HAS_MORE_VLAN,
>  	ITEM_IPV4,
> +	ITEM_IPV4_VER_IHL,
>  	ITEM_IPV4_TOS,
>  	ITEM_IPV4_ID,
>  	ITEM_IPV4_FRAGMENT_OFFSET,
> @@ -1069,6 +1070,7 @@ static const enum index item_vlan[] = {
>  };
>  
>  static const enum index item_ipv4[] = {
> +	ITEM_IPV4_VER_IHL,
>  	ITEM_IPV4_TOS,
>  	ITEM_IPV4_ID,
>  	ITEM_IPV4_FRAGMENT_OFFSET,
> @@ -2576,6 +2578,14 @@ static const struct token token_list[] = {
>  		.next = NEXT(item_ipv4),
>  		.call = parse_vc,
>  	},
> +	[ITEM_IPV4_VER_IHL] = {
> +		.name = "version_ihl",
> +		.help = "match header length",
> +		.next = NEXT(item_ipv4, NEXT_ENTRY(COMMON_UNSIGNED),
> +			     item_param),
> +		.args = ARGS(ARGS_ENTRY(struct rte_flow_item_ipv4,
> +				     hdr.version_ihl)),
> +	},
>  	[ITEM_IPV4_TOS] = {
>  		.name = "tos",
>  		.help = "type of service",
> @@ -8193,7 +8203,8 @@ update_fields(uint8_t *buf, struct rte_flow_item *item, uint16_t next_proto)
>  		break;
>  	case RTE_FLOW_ITEM_TYPE_IPV4:
>  		ipv4 = (struct rte_ipv4_hdr *)buf;
> -		ipv4->version_ihl = 0x45;
> +		if (!ipv4->version_ihl)
> +			ipv4->version_ihl = RTE_IPV4_VHL_DEF;
>  		if (next_proto && ipv4->next_proto_id == 0)
>  			ipv4->next_proto_id = (uint8_t)next_proto;
>  		break;
> diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> index 33857acf54..ab7e91ad6c 100644
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> @@ -3654,6 +3654,7 @@ This section lists supported pattern items and their attributes, if any.
>  
>  - ``ipv4``: match IPv4 header.
>  
> +  - ``version_ihl {unsigned}``: IPv4 version and IP header length.
>    - ``tos {unsigned}``: type of service.
>    - ``ttl {unsigned}``: time to live.
>    - ``proto {unsigned}``: next protocol ID.
> 


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field
  2021-07-13  8:07   ` Andrew Rybchenko
@ 2021-07-13  8:54     ` Gregory Etelson
  2021-07-13 10:04       ` Andrew Rybchenko
  0 siblings, 1 reply; 8+ messages in thread
From: Gregory Etelson @ 2021-07-13  8:54 UTC (permalink / raw)
  To: Andrew Rybchenko, Ori Kam, Slava Ovsiienko; +Cc: Xiaoyun Li, dev

Hello,

The patch was reviewed and approved by @Slava Ovsiienko

Regards,
Gregory

> -----Original Message-----
> From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Sent: Tuesday, July 13, 2021 11:08
> To: Ori Kam <orika@nvidia.com>
> Cc: Slava Ovsiienko <viacheslavo@nvidia.com>; Xiaoyun Li
> <xiaoyun.li@intel.com>; Gregory Etelson <getelson@nvidia.com>;
> dev@dpdk.org
> Subject: Re: [PATCH v2] app/testpmd: add flow item to match on IPv4
> version_ihl field
> 
> External email: Use caution opening links or attachments
> 
> 
> @Ori, could you review it, please.
> 
> Thanks,
> Andrew.
> 
> On 7/13/21 10:29 AM, Gregory Etelson wrote:
> > The new flow item allows PMD to offload IPv4 IHL field for matching,
> > if hardware supports that operation.
> >
> > Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> > ---
> > v2: replace UNSIGNED with COMMON_UNSIGNED following 21.08 API
> change.
> > ---
> >  app/test-pmd/cmdline_flow.c                 | 13 ++++++++++++-
> >  doc/guides/testpmd_app_ug/testpmd_funcs.rst |  1 +
> >  2 files changed, 13 insertions(+), 1 deletion(-)
> >
> > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
> > index 8fc0e1469d..34e043621c 100644
> > --- a/app/test-pmd/cmdline_flow.c
> > +++ b/app/test-pmd/cmdline_flow.c
> > @@ -171,6 +171,7 @@ enum index {
> >       ITEM_VLAN_INNER_TYPE,
> >       ITEM_VLAN_HAS_MORE_VLAN,
> >       ITEM_IPV4,
> > +     ITEM_IPV4_VER_IHL,
> >       ITEM_IPV4_TOS,
> >       ITEM_IPV4_ID,
> >       ITEM_IPV4_FRAGMENT_OFFSET,
> > @@ -1069,6 +1070,7 @@ static const enum index item_vlan[] = {  };
> >
> >  static const enum index item_ipv4[] = {
> > +     ITEM_IPV4_VER_IHL,
> >       ITEM_IPV4_TOS,
> >       ITEM_IPV4_ID,
> >       ITEM_IPV4_FRAGMENT_OFFSET,
> > @@ -2576,6 +2578,14 @@ static const struct token token_list[] = {
> >               .next = NEXT(item_ipv4),
> >               .call = parse_vc,
> >       },
> > +     [ITEM_IPV4_VER_IHL] = {
> > +             .name = "version_ihl",
> > +             .help = "match header length",
> > +             .next = NEXT(item_ipv4, NEXT_ENTRY(COMMON_UNSIGNED),
> > +                          item_param),
> > +             .args = ARGS(ARGS_ENTRY(struct rte_flow_item_ipv4,
> > +                                  hdr.version_ihl)),
> > +     },
> >       [ITEM_IPV4_TOS] = {
> >               .name = "tos",
> >               .help = "type of service", @@ -8193,7 +8203,8 @@
> > update_fields(uint8_t *buf, struct rte_flow_item *item, uint16_t
> next_proto)
> >               break;
> >       case RTE_FLOW_ITEM_TYPE_IPV4:
> >               ipv4 = (struct rte_ipv4_hdr *)buf;
> > -             ipv4->version_ihl = 0x45;
> > +             if (!ipv4->version_ihl)
> > +                     ipv4->version_ihl = RTE_IPV4_VHL_DEF;
> >               if (next_proto && ipv4->next_proto_id == 0)
> >                       ipv4->next_proto_id = (uint8_t)next_proto;
> >               break;
> > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > index 33857acf54..ab7e91ad6c 100644
> > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > @@ -3654,6 +3654,7 @@ This section lists supported pattern items and
> their attributes, if any.
> >
> >  - ``ipv4``: match IPv4 header.
> >
> > +  - ``version_ihl {unsigned}``: IPv4 version and IP header length.
> >    - ``tos {unsigned}``: type of service.
> >    - ``ttl {unsigned}``: time to live.
> >    - ``proto {unsigned}``: next protocol ID.
> >


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field
  2021-07-13  8:54     ` Gregory Etelson
@ 2021-07-13 10:04       ` Andrew Rybchenko
  0 siblings, 0 replies; 8+ messages in thread
From: Andrew Rybchenko @ 2021-07-13 10:04 UTC (permalink / raw)
  To: Gregory Etelson, Ori Kam, Slava Ovsiienko; +Cc: Xiaoyun Li, dev

On 7/13/21 11:54 AM, Gregory Etelson wrote:
> Hello,
> 
> The patch was reviewed and approved by @Slava Ovsiienko

I don't see it in patchwork and mailing list.

Slava, could you send formal Acked-by or Reviewed-by, please.

Thanks,
Andrew.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field
  2021-07-13  7:29 ` [dpdk-dev] [PATCH v2] " Gregory Etelson
  2021-07-13  8:07   ` Andrew Rybchenko
@ 2021-07-13 11:11   ` Slava Ovsiienko
  2021-07-13 11:17     ` Andrew Rybchenko
  1 sibling, 1 reply; 8+ messages in thread
From: Slava Ovsiienko @ 2021-07-13 11:11 UTC (permalink / raw)
  To: Gregory Etelson, dev, andrew.rybchenko; +Cc: Ori Kam, Xiaoyun Li

> -----Original Message-----
> From: Gregory Etelson <getelson@nvidia.com>
> Sent: Tuesday, July 13, 2021 10:29
> To: dev@dpdk.org; andrew.rybchenko@oktetlabs.ru
> Cc: Gregory Etelson <getelson@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Xiaoyun Li
> <xiaoyun.li@intel.com>
> Subject: [PATCH v2] app/testpmd: add flow item to match on IPv4
> version_ihl field
> 
> The new flow item allows PMD to offload IPv4 IHL field for matching, if
> hardware supports that operation.
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [dpdk-dev] [PATCH v2] app/testpmd: add flow item to match on IPv4 version_ihl field
  2021-07-13 11:11   ` Slava Ovsiienko
@ 2021-07-13 11:17     ` Andrew Rybchenko
  0 siblings, 0 replies; 8+ messages in thread
From: Andrew Rybchenko @ 2021-07-13 11:17 UTC (permalink / raw)
  To: Slava Ovsiienko, Gregory Etelson, dev; +Cc: Ori Kam, Xiaoyun Li

On 7/13/21 2:11 PM, Slava Ovsiienko wrote:
>> -----Original Message-----
>> From: Gregory Etelson <getelson@nvidia.com>
>> Sent: Tuesday, July 13, 2021 10:29
>> To: dev@dpdk.org; andrew.rybchenko@oktetlabs.ru
>> Cc: Gregory Etelson <getelson@nvidia.com>; Slava Ovsiienko
>> <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Xiaoyun Li
>> <xiaoyun.li@intel.com>
>> Subject: [PATCH v2] app/testpmd: add flow item to match on IPv4
>> version_ihl field
>>
>> The new flow item allows PMD to offload IPv4 IHL field for matching, if
>> hardware supports that operation.
>>
>> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Reviewed-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> 

Applied, thanks


^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-07-13 11:17 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-05 11:52 [dpdk-dev] [PATCH] app/testpmd: add flow item to match on IPv4 version_ihl field Gregory Etelson
2021-07-11 10:25 ` Gregory Etelson
2021-07-13  7:29 ` [dpdk-dev] [PATCH v2] " Gregory Etelson
2021-07-13  8:07   ` Andrew Rybchenko
2021-07-13  8:54     ` Gregory Etelson
2021-07-13 10:04       ` Andrew Rybchenko
2021-07-13 11:11   ` Slava Ovsiienko
2021-07-13 11:17     ` Andrew Rybchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).