From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24FCFA0C47; Tue, 6 Jul 2021 15:36:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DA9CB41490; Tue, 6 Jul 2021 15:34:06 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2053.outbound.protection.outlook.com [40.107.93.53]) by mails.dpdk.org (Postfix) with ESMTP id 90382413A0 for ; Tue, 6 Jul 2021 15:34:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D96fpsFknMae0YPObiVlDODjqpDrcca+nTIvgs2OwRCvn7WrULNBfyc3Z8piiGD0bu6TKDCThKCyPEM+S3UBOD7z5bhMKdIrhdW2K2TQnrPWWkzk3ahEizpDbFhTEDeMwCkv+A9wgHFqk4cJqgZx8bAsn5bofOwh0RqQbUp7HxiqZf3aYgqVbiJVlmhI0y5L9RFDj2EkAnSk8w7VmnsJa52131/YNzlSOjxi05699oBReEfYsLm++xRshICCvtqmtTp39ge7Eorc3q19Cmgk27Vhy+gj2jwQb/+ml587LGD0jDS+ESfeZcMQeWthhf5HaW1Rfv+eakxXs+dcrZ9mAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jf0WosUb0J5nOPlTECv5/FZR9BpVRZ49Qsp8jXrWDVM=; b=fVKbP876bYPaDE7hH8EUmD7V9BvQrDxJ7ZQISZE7SvOa8ofIXJmK64o0hlQbVSr8yHuHOCb7rEGay5Fzo9c4D826bACUijIUpyb7XDCvrP2sxH1xOalH4G7YHeM970SZIb2TStZ7EOyJ29eXwhjyY/gawmEct6i70EE0LBQCNjrGf2ePkyOKc0G8qSwaao3QkuJKUK0XhLIT2kdgL4wl8FzwkjPDQv5UbxFIQi7pKpn2ilN0kpXrbDFQe6vT59Gw2z85Qo0DQ9QzqMv4msdQBD1z95ihWEQNKjlyMPszGwEWjKw2njVuEJbotwhHaRj8sssFxduj8pD446/X2Ldsbw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jf0WosUb0J5nOPlTECv5/FZR9BpVRZ49Qsp8jXrWDVM=; b=rkb504X7jTw7Enp1pNHccY/wGLLt14RZVuHPbkS4PFDlSya1Mj7TwreXyQZOKVAvE9GU3wjHMWPRb6kKx9og11h6cJqpWobvEqf5uwm+Os7ZTWRDaSdeR28d5gSXfhjY1nKAPOwxF9KjxPaBI+zG6dJrArm/DRxsi/dcIlAAstbj/D3hqGFWXbHYMGzlV2it7HCAwk1dLlmMpHWuNLJpRwcgUiX4VPXqyow2DW0U4bI6vL9O91ksO7GxwlCzhRGhlbJM2136ouJSSJOJpF8ofwug3ENMgr1zBKj7MKycCXx/SezSkyEpQJOZZysS/q8l9JoV4Tj16nzeLqnr4vJmPg== Received: from BN0PR04CA0069.namprd04.prod.outlook.com (2603:10b6:408:ea::14) by BY5PR12MB3698.namprd12.prod.outlook.com (2603:10b6:a03:194::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.31; Tue, 6 Jul 2021 13:34:04 +0000 Received: from BN8NAM11FT031.eop-nam11.prod.protection.outlook.com (2603:10b6:408:ea:cafe::fb) by BN0PR04CA0069.outlook.office365.com (2603:10b6:408:ea::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.22 via Frontend Transport; Tue, 6 Jul 2021 13:34:03 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT031.mail.protection.outlook.com (10.13.177.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4287.22 via Frontend Transport; Tue, 6 Jul 2021 13:34:03 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 6 Jul 2021 13:34:00 +0000 From: Suanming Mou To: , CC: , , Date: Tue, 6 Jul 2021 16:32:56 +0300 Message-ID: <20210706133257.3353-26-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210706133257.3353-1-suanmingm@nvidia.com> References: <20210527093403.1153127-1-suanmingm@nvidia.com> <20210706133257.3353-1-suanmingm@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d43b52db-3039-47ee-49c5-08d94082b8b4 X-MS-TrafficTypeDiagnostic: BY5PR12MB3698: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:202; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XToM1J0WVLrO0VXjygm9jnAiT6uNjrKGAsBFHzFgoKS4lxV1VoJda3/X5Mik1jZsLrUfmMC5oGsEk2JzTNpRfKpsZuajZ+2x/0V01Kl8AQJJHkPCm/MXShcX+y26lYcraFXzWx4+YfSWUuFqodvXmfZNutPoVByG7aljw4a1A5jaQA17RZDT9IugzoyveYtQzqJo+gsDYic68A760vrtpH8TjMsOP2t9bFuIaVuZAWJQ2sdGQGBfu1TQZEfixihTale8+LWTr0GoJMWovjkrEhcxcDRhYoqmbkVwHUMR+8AMGaJui+PAJpTNlp43nOPceW0Bwoksn+UdsuCY0MNhaA87PBH6CQpL9JY8udQBXQeM6Qwoe02ILjzQWME33uFoX58dS3QTkA8ww+QxvLStHAhtTR5aH/Vyi2JGiSMwwMKEjkmNbaVtVBggqh+C0Y277elHsKX71zXnnF1n7uvd8RgUHWSHt4mMi81BY+zTbGYjIPWWG2mIVgH8GATrU8r/+YRH1hs8THNqEJZ4Y151xVwqIwKhvAM4TEYaMPKORK9Um+CaSBncqVXphHoCAR7wMrbw8VMcVzn3C/3zcYlNTMVDjWdKN2KlH6UDxzBrFqEAHnBYRvo2I7S9SszYAqLVeHZJE3j70Yafjt7hCvE8Vj+VG3+iIJ8lRoQqq+7OKdSTpDNbV9TUTGb+scWQ6p6xJzONvd5H47gXxyNrO+VuvQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(346002)(39860400002)(376002)(136003)(36840700001)(46966006)(8676002)(47076005)(86362001)(356005)(316002)(36860700001)(36756003)(2906002)(2616005)(426003)(1076003)(83380400001)(55016002)(478600001)(186003)(7696005)(6666004)(36906005)(7636003)(70586007)(6636002)(82310400003)(6286002)(82740400003)(336012)(5660300002)(16526019)(54906003)(8936002)(110136005)(4326008)(26005)(70206006); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2021 13:34:03.6706 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d43b52db-3039-47ee-49c5-08d94082b8b4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT031.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB3698 Subject: [dpdk-dev] [PATCH v4 25/26] net/mlx5: optimize Rx queue match X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" As hrxq struct has the indirect table pointer, while matching the hrxq, better to use the hrxq indirect table instead of searching from the list. This commit optimizes the hrxq indirect table matching. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxq.c | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c index 7893b3edd4..23685d7654 100644 --- a/drivers/net/mlx5/mlx5_rxq.c +++ b/drivers/net/mlx5/mlx5_rxq.c @@ -2094,23 +2094,19 @@ mlx5_ind_table_obj_modify(struct rte_eth_dev *dev, } int -mlx5_hrxq_match_cb(void *tool_ctx, struct mlx5_list_entry *entry, void *cb_ctx) +mlx5_hrxq_match_cb(void *tool_ctx __rte_unused, struct mlx5_list_entry *entry, + void *cb_ctx) { - struct rte_eth_dev *dev = tool_ctx; struct mlx5_flow_cb_ctx *ctx = cb_ctx; struct mlx5_flow_rss_desc *rss_desc = ctx->data; struct mlx5_hrxq *hrxq = container_of(entry, typeof(*hrxq), entry); - struct mlx5_ind_table_obj *ind_tbl; - if (hrxq->rss_key_len != rss_desc->key_len || + return (hrxq->rss_key_len != rss_desc->key_len || memcmp(hrxq->rss_key, rss_desc->key, rss_desc->key_len) || - hrxq->hash_fields != rss_desc->hash_fields) - return 1; - ind_tbl = mlx5_ind_table_obj_get(dev, rss_desc->queue, - rss_desc->queue_num); - if (ind_tbl) - mlx5_ind_table_obj_release(dev, ind_tbl, hrxq->standalone); - return ind_tbl != hrxq->ind_table; + hrxq->hash_fields != rss_desc->hash_fields || + hrxq->ind_table->queues_n != rss_desc->queue_num || + memcmp(hrxq->ind_table->queues, rss_desc->queue, + rss_desc->queue_num * sizeof(rss_desc->queue[0]))); } /** -- 2.25.1