From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BD79A0C48; Tue, 6 Jul 2021 22:29:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F035841421; Tue, 6 Jul 2021 22:29:19 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 87CBC413F8 for ; Tue, 6 Jul 2021 22:29:16 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10037"; a="196470353" X-IronPort-AV: E=Sophos;i="5.83,329,1616482800"; d="scan'208";a="196470353" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Jul 2021 13:29:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.83,329,1616482800"; d="scan'208";a="486522089" Received: from silpixa00399126.ir.intel.com ([10.237.223.29]) by FMSMGA003.fm.intel.com with ESMTP; 06 Jul 2021 13:29:14 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Chengwen Feng , Jerin Jacob , Jerin Jacob , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Bruce Richardson Date: Tue, 6 Jul 2021 21:28:39 +0100 Message-Id: <20210706202841.661302-8-bruce.richardson@intel.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20210706202841.661302-1-bruce.richardson@intel.com> References: <1625231891-2963-1-git-send-email-fengchengwen@huawei.com> <20210706202841.661302-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [RFC UPDATE PATCH 7/9] dmadev: stats structure updates X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Drop the failed enqueue count since that is best tracked by the application so that retries of the same job can be counted as desired by the app developer. Since the "doorbell" function is separate from the actual functions to enqueue descriptors, track a separate stat for jobs which were submitted to hardware, in case the "enqueued" count includes jobs which were not yet "doorbelled". Signed-off-by: Bruce Richardson --- lib/dmadev/rte_dmadev.h | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/dmadev/rte_dmadev.h b/lib/dmadev/rte_dmadev.h index eb78f3805..bdb531a53 100644 --- a/lib/dmadev/rte_dmadev.h +++ b/lib/dmadev/rte_dmadev.h @@ -768,14 +768,10 @@ rte_dmadev_completed_fails(uint16_t dev_id, uint16_t vq_id, } struct rte_dmadev_stats { - uint64_t enqueue_fail_count; - /**< Conut of all operations which failed enqueued */ - uint64_t enqueued_count; - /**< Count of all operations which successful enqueued */ - uint64_t completed_fail_count; - /**< Count of all operations which failed to complete */ - uint64_t completed_count; - /**< Count of all operations which successful complete */ + uint64_t enqueued_count; /**< Count of operations which were successful enqueued */ + uint64_t submitted_count; /**< Count of operations which were submitted to hardware */ + uint64_t completed_fail_count; /**< Count of operations which failed to complete */ + uint64_t completed_count; /**< Count of operations which successful complete */ }; /** -- 2.30.2