From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 84C64A0C49; Wed, 7 Jul 2021 14:04:05 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E18D24150E; Wed, 7 Jul 2021 14:03:44 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2044.outbound.protection.outlook.com [40.107.92.44]) by mails.dpdk.org (Postfix) with ESMTP id EF35941504; Wed, 7 Jul 2021 14:03:41 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fnmfmOsTvrVpGhLR7WiZFuf2LAuzLASonUchQKC8lPR1xV0iKgrHEoR27/RDll/NdPJnBThmOg8A9rLB5oCu2x7Nd2AuS1O9Pfb/MyCbbCEGJNGFJ/VTYI6xOQ9/JQe66qlfF0KCdAXDZfYm8mEVgQ3TkyDY6gwHPXSFys+nDAFphlrpDAcVaygXLew9XznRCLISiIsaG0jsvtAH+pnUsuV39vbUrxQcd+rpPz715pHYJnZMtbczh4DxjbSHv1DPUqqRfp1f+5ZdTJgRB5ojVXEzSq08/UXflcUF+5t8a24o0amZtNRVHIwW/0IAiO3fXoJl5A1MuX5SBNIv8YOWAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjSLZMTHDj0qPCqThkSVPXkrz3GV7g2E+ySbDJlN5mA=; b=XwVXoI0E72wT+nGr+kkXs7APuCjW1gd0parUzdMzt1Pcrpub1si5NMHTzHJUQ1CkWm8XFk0T4Rp8QyOx/Mf2esPeb2VI/9XIe43qQnZ10MclR9NuF8bWgkmJxVELfxnToKHcQTzfadZu4X4yWtjOG7EiAeV9IQQUz2KeRNMY24Z+3hGEygFNZnnUA7vsnXuT0vJZIP/Gl952ZMe05VL/RRNEL+1jvqis0ODsnCKNA1bGgiNSVQKaB7hsPA7kVp5hQB1vZzFgAkE8uMR1ayeKBl9KsEypl+4GaET4S55ojWkbYW2iVeYrd2YsJtpezxCizy8Jk9YjdvYe3HvkaaREaA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjSLZMTHDj0qPCqThkSVPXkrz3GV7g2E+ySbDJlN5mA=; b=L5G/39Jxng0E+3B/uwlm0SBq6bCujmA/nPb9AN9xwGPKdoW4LHKJVQLj9LocsdY4WE8wKhlke9nGMkuJ/eUmZ+HewjMDCCgCwd+wKH12PlL6kuD7vvMnXmV3Es96YhBpN7CeN9IexVE8qHIH0jTT8FGRqr3/J81e8h2Yild/UDvIzug4zSWOSvYuERTvbriAAqKpAR0m4YVdDfCRSRMd3WSMFfN35QfBBNmZ76Pdozc1dmaq2qDAlAD0UDRhrBjZqEovwyAH3FL9O+NR6x1+PFMW50CEMX8QFY4eqOyK/e/gI5HgJ/EVOGTquCTzeVFgoLHcyxzC5EwQK/2pwsE/1w== Received: from BN9PR03CA0773.namprd03.prod.outlook.com (2603:10b6:408:13a::28) by DM6PR12MB3945.namprd12.prod.outlook.com (2603:10b6:5:1c2::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4287.27; Wed, 7 Jul 2021 12:03:40 +0000 Received: from BN8NAM11FT061.eop-nam11.prod.protection.outlook.com (2603:10b6:408:13a:cafe::37) by BN9PR03CA0773.outlook.office365.com (2603:10b6:408:13a::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Wed, 7 Jul 2021 12:03:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT061.mail.protection.outlook.com (10.13.177.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4308.20 via Frontend Transport; Wed, 7 Jul 2021 12:03:40 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 7 Jul 2021 12:03:38 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , Date: Wed, 7 Jul 2021 15:03:03 +0300 Message-ID: <20210707120303.2490006-4-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210707120303.2490006-1-michaelba@nvidia.com> References: <20210705052730.2283962-1-michaelba@nvidia.com> <20210707120303.2490006-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0d97384c-db6c-470b-5995-08d9413f42a5 X-MS-TrafficTypeDiagnostic: DM6PR12MB3945: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1169; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: h0+OECPwVcu9M77gp6aisebkdmxjvQB8jLzXRBbLb8P5sgF53lUtzqce5Peb+8RfRnPavxRw+ScXQJ5RtPAI76cxopaSLhvTZFVD4b1ywvIwHrQ/MWNXpR7bNXmze2SLPFNZZZFlELT0E7KyBy00g4HDhEBOLW/+YaJJjJH/u9autcfB4v5MpJHjgPz+Lh+9mmRWTD+4bpHprb3BXkLzWM/SsSP8Fwmut0CryTn1WpBDCSD1IP/xviAvJzmskU8HYK8+xsssWFDpGkBYBjH17ANR1dZsaDvx72hhl37hli8GTKRV4S4OxCutX3rX9XWUvj7abDwYl5iDxm41fH+btoRmDqj05loe/mslcy3exWk0/h+oFVLRrW2crAQm9MTlvPRVXHSws42YYoimPXv5pVPLX6rMoj7r6dTj6b+kTLK+TRqef+Tzk7k7KrCl9sGFVWVtOKSA3gTx7x7LQHVUn0KdJuHFoeeccoSxDmeCnvhb5y7hEks0N+/wr7kDMJpqr2EgpcirY9LE2QRHrmBEHXRVn9awmpbVq1+6I16R0Z3O8OV5VY+NVRYmm51Kc4l6InEF83ZbSn37Z196YR3iJiq8IAiE1O28g/Mpib49HHNrEr0WU+BEc7GPmoD7hMsUbcn/ZiExRI6/uymjhKEFMW0xdru2ZKChb/xsGXQlv4qxaZamgyhihHbk8ONavwbgOYPUislqWVyNroqLtcGqEw== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(39860400002)(136003)(396003)(376002)(346002)(36840700001)(46966006)(186003)(426003)(70586007)(6286002)(47076005)(86362001)(4744005)(82740400003)(82310400003)(36756003)(7636003)(8936002)(8676002)(6916009)(2906002)(2616005)(336012)(16526019)(70206006)(55016002)(7696005)(83380400001)(1076003)(5660300002)(356005)(36860700001)(4326008)(54906003)(478600001)(6666004)(26005)(450100002)(316002)(36906005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2021 12:03:40.4494 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0d97384c-db6c-470b-5995-08d9413f42a5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT061.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3945 Subject: [dpdk-dev] [PATCH_v3 3/3] regex/mlx5: fix redundancy in PCI remove function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In the PCI removal function, PMD releases all driver resources and cancels the regexdev registry. However, regexdev registration is accidentally canceled twice. Remove one of them. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: stable@dpdk.org Signed-off-by: Michael Baum --- drivers/regex/mlx5/mlx5_regex.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index f64dc2824c..1c5bf930ad 100644 --- a/drivers/regex/mlx5/mlx5_regex.c +++ b/drivers/regex/mlx5/mlx5_regex.c @@ -290,8 +290,6 @@ mlx5_regex_pci_remove(struct rte_pci_device *pci_dev) rte_regexdev_unregister(priv->regexdev); if (priv->ctx) mlx5_glue->close_device(priv->ctx); - if (priv->regexdev) - rte_regexdev_unregister(priv->regexdev); rte_free(priv); } return 0; -- 2.25.1