DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] eal: create runtime dir even when shared data is not used
@ 2021-07-01  9:34 Bruce Richardson
  2021-07-01 14:43 ` Morten Brørup
                   ` (2 more replies)
  0 siblings, 3 replies; 17+ messages in thread
From: Bruce Richardson @ 2021-07-01  9:34 UTC (permalink / raw)
  To: dev; +Cc: anatoly.burakov, Bruce Richardson

When multi-process is not wanted and DPDK is run with the "no-shconf"
flag, the telemetry library still needs a runtime directory to place the
unix socket for telemetry connections. Therefore, rather than not
creating the directory when this flag is set, we can change the code to
attempt the creation anyway, but not error out if it fails. If it
succeeds, then telemetry will be available, but if it fails, the rest of
DPDK will run without telemetry. This ensures that the "in-memory" flag
will allow DPDK to run even if the whole filesystem is read-only, for
example.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/eal/linux/eal.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c
index ba19fc6347..1e05ba3847 100644
--- a/lib/eal/linux/eal.c
+++ b/lib/eal/linux/eal.c
@@ -838,9 +838,8 @@ eal_parse_args(int argc, char **argv)
 		}
 	}
 
-	/* create runtime data directory */
-	if (internal_conf->no_shconf == 0 &&
-			eal_create_runtime_dir() < 0) {
+	/* create runtime data directory. In no_shconf mode, skip any errors */
+	if (eal_create_runtime_dir() < 0 && internal_conf->no_shconf == 0) {
 		RTE_LOG(ERR, EAL, "Cannot create runtime directory\n");
 		ret = -1;
 		goto out;
-- 
2.30.2


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2021-07-07 19:02 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-01  9:34 [dpdk-dev] [PATCH] eal: create runtime dir even when shared data is not used Bruce Richardson
2021-07-01 14:43 ` Morten Brørup
2021-07-01 14:56   ` Bruce Richardson
2021-07-02 12:55 ` [dpdk-dev] [PATCH v2 1/2] " Bruce Richardson
2021-07-02 12:55   ` [dpdk-dev] [PATCH v2 2/2] telemetry: add extra log message on socket bind failure Bruce Richardson
2021-07-02 14:22     ` Morten Brørup
2021-07-05 10:16       ` Power, Ciara
2021-07-05 14:11     ` David Marchand
2021-07-02 14:21   ` [dpdk-dev] [PATCH v2 1/2] eal: create runtime dir even when shared data is not used Morten Brørup
2021-07-05 14:11   ` David Marchand
2021-07-05 14:39     ` Bruce Richardson
2021-07-07 12:35       ` David Marchand
2021-07-07 12:41         ` Bruce Richardson
2021-07-07 19:02   ` Tyler Retzlaff
2021-07-07 12:52 ` [dpdk-dev] [PATCH v3 " Bruce Richardson
2021-07-07 12:52   ` [dpdk-dev] [PATCH v3 2/2] telemetry: add extra log message on socket bind failure Bruce Richardson
2021-07-07 15:00   ` [dpdk-dev] [PATCH v3 1/2] eal: create runtime dir even when shared data is not used David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).