From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6494CA0C4B; Mon, 12 Jul 2021 03:49:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC822411F4; Mon, 12 Jul 2021 03:48:11 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2077.outbound.protection.outlook.com [40.107.243.77]) by mails.dpdk.org (Postfix) with ESMTP id 6FCD8411DB for ; Mon, 12 Jul 2021 03:48:07 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JLbkPqgRT/RkFKR8/GuM65ryxMEwDg/xfuTfFW6kemkIuCKc8ozA8u+DijSMUa8YK+SHreIl8pOqU5/0Jpwx+mWs0CyfhTwMfa2Hy8MP5951O/Nrqlowc2ppMZqAxdFwGDZYxwoSVbhqwde9xf7B56KDRpR5S0K0iHV7zuGxeWZ4MJX2ZWZ48q1xCPegsvOXt7BpurAbWzNouspVXdhQDxY7KAt5ArPQlwPOauCvrCiqe4hXBAQQwh+dusf1Paj3jSlcVmi2MnV8JItwqCi9QOseT6FGzbgiz+iqR1/84X+Bh+TQl8BLUwL6Fc485UZft25fzGC0n1Ym36jXbNiy4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N+GN/q/xffVPrJb//urff1S6AxS4RYuu4sXwkCSHlFc=; b=nu0J617BYTIWXNkiB/h4mVjRTRRXLpNu3AQP0NFUvKWWRXiQvFCBIxV4FAgCHiMJ/lKccdGpDOJFmv9CLR4srGZERNDlNlUZjegQWZHJz8sQJHLRCejZ+rPQEyOtUQ3NCr5UTIl5dp6xahVq/UH7L2sEdpktze5ZOTTuSXKQdDNyGojQLF80c0c88r8/BZP7UjJyw6r9DuoMyAioBUNHWeEI6mELx11jMwTewalNohtj0Tnmv2YaiUoAKWoP9RJlZmN7fk7JdiJ/vGuUpVbCLnoT8r3verxWHAzI47P/+hz0wamrGdNH9A9tzfZzfNalB23ZKVoO4RkLLQH6+bPZ9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=N+GN/q/xffVPrJb//urff1S6AxS4RYuu4sXwkCSHlFc=; b=apjhZvn7+dUvTwY1tqVp74KsIRs27EERKMd76xZPopMqTYPZ+3gpN5ClRk/QjH71dKqmcYU5F8Csldq4dZJtEg2eAQBUioF2HdGakgfVbbiziaIW+X9s1MYhW9XLqvbs7RjJNrF6s9XVTRJDcSaTUw27wf4Ul6Zp0impdlRGeht3QuHiXsrbqxVzo1keNNvzywTvmE7q47AaWrVjUqszaKGhWZR0mJgkAo08F+wriah/pYRDQh3z7URTh6sfVEHU7CZ6WmhDMLKOsx4ISOogI1jVVpemMsDv0ZYZxtCVNbcFTILAnOXMLstMtLEJx4X57ZYEez05CdWzUpvXPGZIQg== Received: from BN8PR04CA0056.namprd04.prod.outlook.com (2603:10b6:408:d4::30) by BL0PR12MB4867.namprd12.prod.outlook.com (2603:10b6:208:17e::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.23; Mon, 12 Jul 2021 01:48:06 +0000 Received: from BN8NAM11FT024.eop-nam11.prod.protection.outlook.com (2603:10b6:408:d4:cafe::6d) by BN8PR04CA0056.outlook.office365.com (2603:10b6:408:d4::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Mon, 12 Jul 2021 01:48:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT024.mail.protection.outlook.com (10.13.177.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4308.20 via Frontend Transport; Mon, 12 Jul 2021 01:48:06 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Jul 2021 01:47:47 +0000 From: Suanming Mou To: , CC: , , Date: Mon, 12 Jul 2021 04:46:49 +0300 Message-ID: <20210712014654.32428-22-suanmingm@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20210712014654.32428-1-suanmingm@nvidia.com> References: <20210527093403.1153127-1-suanmingm@nvidia.com> <20210712014654.32428-1-suanmingm@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58f3d5fb-12ef-417f-1892-08d944d7184b X-MS-TrafficTypeDiagnostic: BL0PR12MB4867: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:628; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XVCQoupoVNs0sCPnqyXsLhCcNt0Fjt2+Bj1LkIlKtXOtKOoh/czm0as0f8SfN8RreMcnBAj4SX5P2cbLsod1loxPUGfAOMgXiXEJ+IFIO3rvow60P9gZBJx45M0dG16BooSlaaqDvi+XBnOVTK9xrlxOAVZfVfLah7rdEmtLUaB4dA3HJFDw265aDQFAC2w+bPKtaoKDWFEVZn06gSFqWvtG0l8WTlyrBwbpPV1EmJOd0bDYXXMHXnckpv7eVkr4cODk7kSDJAOWiMz7DwwWNo6PQgqFcsIuIKyfI5SIZjbvfJd8yfDlGRyXLuBLtOcJFwaqe8WS7bFe8uWUks1GUBV7M70gaT615tv5oNRATGsEUqp/eTEh7yfgmwwpBYnvHGl7Y5QAxQFmoOoNa2uCtcsE9KB3XZWabxgRRwD2M/WpSL0kFY2vBDJupxBUfGoZlfpYJVmogKiO7MB8utbYEEJ5UAsdQdzf2TS2AtWg5cKO1hK+ZLaULbNRzFRzTjnW8O33xvV1PhT6leTQ+ZDEQpQ+sP4NYUpBPefaJXdGnWXUPzCIVUkbreVrQOYeUYtfRZUPjWQPmIIxpfm9BuCK+G8Qiz6Ei5uSJtKcjsrTDGnX7oRxSHyMXYMiRcVnVVFUudrdXY5NxipTFZFdoPvB4pWylFs3Yvq3di7OKBwzPk4DSr7ZcAhFz8gND+gHhMMJquzOzEzt5WJZvGDb7r0wRsNSLsl+84Y23zB53+MGI7Q= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(136003)(376002)(39860400002)(346002)(46966006)(36840700001)(16526019)(336012)(36860700001)(5660300002)(54906003)(110136005)(82740400003)(34020700004)(186003)(426003)(36906005)(70206006)(55016002)(70586007)(26005)(316002)(6636002)(47076005)(8676002)(2906002)(6286002)(86362001)(83380400001)(8936002)(356005)(7636003)(82310400003)(478600001)(4326008)(36756003)(1076003)(7696005)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2021 01:48:06.3879 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58f3d5fb-12ef-417f-1892-08d944d7184b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT024.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4867 Subject: [dpdk-dev] [PATCH v5 21/26] net/mlx5: adjust the hash bucket size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" With the new per core optimization to the list, the hash bucket size can be tuned to a more accurate number. This commit adjusts the hash bucket size. Signed-off-by: Suanming Mou Acked-by: Matan Azrad --- drivers/net/mlx5/linux/mlx5_os.c | 2 +- drivers/net/mlx5/mlx5.c | 2 +- drivers/net/mlx5/mlx5_defs.h | 6 +++--- drivers/net/mlx5/mlx5_flow.c | 5 ++--- 4 files changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index b04e5f8ba6..969d265350 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -50,7 +50,7 @@ #include "mlx5_nl.h" #include "mlx5_devx.h" -#define MLX5_TAGS_HLIST_ARRAY_SIZE 8192 +#define MLX5_TAGS_HLIST_ARRAY_SIZE (1 << 15) #ifndef HAVE_IBV_MLX5_MOD_MPW #define MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED (1 << 2) diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index 640d36c6be..3b5c7840a8 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -376,7 +376,7 @@ static const struct mlx5_indexed_pool_config mlx5_ipool_cfg[] = { #define MLX5_FLOW_MIN_ID_POOL_SIZE 512 #define MLX5_ID_GENERATION_ARRAY_FACTOR 16 -#define MLX5_FLOW_TABLE_HLIST_ARRAY_SIZE 4096 +#define MLX5_FLOW_TABLE_HLIST_ARRAY_SIZE 1024 /** * Decide whether representor ID is a HPF(host PF) port on BF2. diff --git a/drivers/net/mlx5/mlx5_defs.h b/drivers/net/mlx5/mlx5_defs.h index 906aa43c5a..ca67ce8213 100644 --- a/drivers/net/mlx5/mlx5_defs.h +++ b/drivers/net/mlx5/mlx5_defs.h @@ -178,15 +178,15 @@ sizeof(struct rte_ipv4_hdr)) /* Size of the simple hash table for metadata register table. */ -#define MLX5_FLOW_MREG_HTABLE_SZ 4096 +#define MLX5_FLOW_MREG_HTABLE_SZ 64 #define MLX5_FLOW_MREG_HNAME "MARK_COPY_TABLE" #define MLX5_DEFAULT_COPY_ID UINT32_MAX /* Size of the simple hash table for header modify table. */ -#define MLX5_FLOW_HDR_MODIFY_HTABLE_SZ (1 << 16) +#define MLX5_FLOW_HDR_MODIFY_HTABLE_SZ (1 << 15) /* Size of the simple hash table for encap decap table. */ -#define MLX5_FLOW_ENCAP_DECAP_HTABLE_SZ (1 << 16) +#define MLX5_FLOW_ENCAP_DECAP_HTABLE_SZ (1 << 12) /* Hairpin TX/RX queue configuration parameters. */ #define MLX5_HAIRPIN_QUEUE_STRIDE 6 diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 45e90bb245..1c5d4c283a 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -8881,7 +8881,7 @@ mlx5_flow_tunnel_allocate(struct rte_eth_dev *dev, DRV_LOG(ERR, "Tunnel ID %d exceed max limit.", id); return NULL; } - tunnel->groups = mlx5_hlist_create("tunnel groups", 1024, false, true, + tunnel->groups = mlx5_hlist_create("tunnel groups", 64, false, true, priv->sh, mlx5_flow_tunnel_grp2tbl_create_cb, mlx5_flow_tunnel_grp2tbl_match_cb, @@ -8990,8 +8990,7 @@ int mlx5_alloc_tunnel_hub(struct mlx5_dev_ctx_shared *sh) return -ENOMEM; LIST_INIT(&thub->tunnels); rte_spinlock_init(&thub->sl); - thub->groups = mlx5_hlist_create("flow groups", - rte_align32pow2(MLX5_MAX_TABLES), + thub->groups = mlx5_hlist_create("flow groups", 64, false, true, sh, mlx5_flow_tunnel_grp2tbl_create_cb, mlx5_flow_tunnel_grp2tbl_match_cb, -- 2.25.1