From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3228FA0C50; Mon, 12 Jul 2021 09:07:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 692594069E; Mon, 12 Jul 2021 09:07:23 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2049.outbound.protection.outlook.com [40.107.236.49]) by mails.dpdk.org (Postfix) with ESMTP id 9C90D4117B; Mon, 12 Jul 2021 09:07:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YfFvc1N1i7Vh4AbIZRe5PRIT0FnhChbOvZCC8OT/75zQ+tUsF9DBmlsatlY0VI2xClv3PYco+69m+pp/QK/aG9xw71mIzHio2Borh2LgObEvXIwXNzcJPkjKoVdv/h5KGzM1E5tsyAdI/I0oFGmo2/rpx9rw/gjzEi+/1qEnkXD5tZ1eTUdYmjJ2Jj1zu1hHBRoEBtb4OKoMuRil8ZMOAp/Cbc0Rz/oFrQ8v929R4AOvlfawELzVRbjA9OOh8Fj7saKuo1ZGsntrMXeVc0Xd+ignmlqZ9OUe5ztaNL+humTL+IDYM/NlNEmvfP6ytc/8Pf7MahV92REfgtu1nHeKCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjSLZMTHDj0qPCqThkSVPXkrz3GV7g2E+ySbDJlN5mA=; b=fAk1EXp1lGj6vJFzQxWbP1d4hZHiPw+jm1pYSgBvhtvBBy8TxCMyCvRSw5bPD4EF1jZoH6nNIvIIWtKGiNGp/gl3bWzwnZQdRdlMnO6dbuLVB3Enf1kb2A6M4tQgNITT5xZ/Mj24CJt8vZeMMaiISaGmHWALpA0tI3tlnUyTDd1pv7G2kz8j+O3XM+BaIrljEAWb+thJTl+XILTD1gbkn75zRapxOcnjAzhYNlw+5i4vfaIC0Le9bGFU85x8Rz6UFbtnjHWxXF0Ro6/Ud7vuYu6FjHon7iGod71Ko6plogotoWvX8yDz/bq8AxUZECTNKwBWmJzdEDQfcLjoTwM5dA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RjSLZMTHDj0qPCqThkSVPXkrz3GV7g2E+ySbDJlN5mA=; b=d133ekhBAxdqyCnvdkPIKoRYpDmcplczRO1I7qOsyJ4Pjs0DYLihkUZlfUs0VGPJt4DRBo+xIctPzPI/IyqNSQbFtfnokFIAWzxN0m8g9cEYDwKIZTuYMqBBIcei3f7KJCYEvg4usRzEIhn6EBTQtt7oWQ41Ygd5lFOcITvtZAW/9BNQO9NhqoTh6GX2WyALz5Z7WINqs8eDaLCuydu2MQBpvltx1aaDdJ1ATlXgwPvNsdKq37T5yIW43RpDAD/P9G0GFHWt2lH8GR/l1SCH1wlVKrpBvlk5WjWaFpnm9TM1ti0NBCXfgaFAKvKuqMJPkG6ttq5pfOrK+7XO8X4jCA== Received: from CO2PR04CA0144.namprd04.prod.outlook.com (2603:10b6:104::22) by MWHPR12MB1917.namprd12.prod.outlook.com (2603:10b6:300:113::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.25; Mon, 12 Jul 2021 07:07:16 +0000 Received: from CO1NAM11FT017.eop-nam11.prod.protection.outlook.com (2603:10b6:104:0:cafe::1f) by CO2PR04CA0144.outlook.office365.com (2603:10b6:104::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4308.20 via Frontend Transport; Mon, 12 Jul 2021 07:07:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT017.mail.protection.outlook.com (10.13.175.108) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4308.20 via Frontend Transport; Mon, 12 Jul 2021 07:07:16 +0000 Received: from nvidia.com (172.20.187.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 12 Jul 2021 07:07:14 +0000 From: Michael Baum To: CC: Matan Azrad , Thomas Monjalon , "Ori Kam" , Date: Mon, 12 Jul 2021 10:06:44 +0300 Message-ID: <20210712070644.2848418-4-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210712070644.2848418-1-michaelba@nvidia.com> References: <20210707120303.2490006-2-michaelba@nvidia.com> <20210712070644.2848418-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3d312424-cab4-4738-bf53-08d94503ae6d X-MS-TrafficTypeDiagnostic: MWHPR12MB1917: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1169; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: B98ukWu+UzaYIcwCbicFFK1tTWjn0geXfXBb2RgELip3sFQfC7KwlMMKOCumtfT5Az5jco8QK7w1MW6VZrFupMxiogPDMrNJkal1WmJF9leQ3P+7KaDVmnuwl5EWTway6Feg1EuKlUN47erupizK1jyhjyZGFrLbKuxsRmnN2pR5tGVN/cjnFs2Y5LzuzNbQajVNot61mTiWZGvom2vHiK7D6XZlACouanfSJqit2dFuxzIQYvHpp+PZNzsUOqvLjqSd1XqzcOe4qksokD99YnZU/yMt3cs2vyM70quVJjKi8+zgzM93DZPZCiwYzvbu0MQbRgLkvHlx3iWFzouszXY8PKxNZEQ9RBrWk1YYaONu8RyBVZsx1XJI90focPTytMXxP92JvEhh4s+J33YCBm075xitDEeL2xp6E8OVKW9SRplIhvkwGuMw2YNCOT5bHjNY2Py/YBYh9Jdf20cp9ViTCTPhlOFZB+Q4lrqvXV8V7gR+Oihvu+1yWI3nk9hE1Wf6PwD/LnexZohCa4on6azhKw1doVnBqkrnE9E5R5gHIyUIgu1sSmEsw/jpIqCI7X/RKx6DkC7VAC+X1wmu6uiawFzj8miyIFQ6Qcqbx1VJbGIN6nnmxzld+EddQkD1gg7Ml7Ah2nMJWhn2mYlk6Vqno8WZBxJlR7BuiAtH1IqzXC4iXLwKyElDkAvjOHOhbDuDVBKfB0pLe7iG83RnpI+PB5D7lmvRKRC8Mvt2Y30= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(396003)(136003)(346002)(376002)(39860400002)(46966006)(36840700001)(2616005)(70206006)(36756003)(4744005)(336012)(186003)(6666004)(316002)(86362001)(7636003)(36906005)(6916009)(54906003)(55016002)(478600001)(70586007)(36860700001)(4326008)(83380400001)(5660300002)(16526019)(82310400003)(8676002)(1076003)(34020700004)(7696005)(82740400003)(356005)(6286002)(426003)(2906002)(8936002)(26005)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jul 2021 07:07:16.2243 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3d312424-cab4-4738-bf53-08d94503ae6d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT017.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR12MB1917 Subject: [dpdk-dev] [PATCH_v4 3/3] regex/mlx5: fix redundancy in PCI remove function X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In the PCI removal function, PMD releases all driver resources and cancels the regexdev registry. However, regexdev registration is accidentally canceled twice. Remove one of them. Fixes: b34d816363b5 ("regex/mlx5: support rules import") Cc: stable@dpdk.org Signed-off-by: Michael Baum --- drivers/regex/mlx5/mlx5_regex.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index f64dc2824c..1c5bf930ad 100644 --- a/drivers/regex/mlx5/mlx5_regex.c +++ b/drivers/regex/mlx5/mlx5_regex.c @@ -290,8 +290,6 @@ mlx5_regex_pci_remove(struct rte_pci_device *pci_dev) rte_regexdev_unregister(priv->regexdev); if (priv->ctx) mlx5_glue->close_device(priv->ctx); - if (priv->regexdev) - rte_regexdev_unregister(priv->regexdev); rte_free(priv); } return 0; -- 2.25.1