From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id C6793A0C4A;
Tue, 13 Jul 2021 03:13:51 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id B06E94069E;
Tue, 13 Jul 2021 03:13:51 +0200 (CEST)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
by mails.dpdk.org (Postfix) with ESMTP id 04AB94069D
for <dev@dpdk.org>; Tue, 13 Jul 2021 03:13:49 +0200 (CEST)
X-IronPort-AV: E=McAfee;i="6200,9189,10043"; a="189762594"
X-IronPort-AV: E=Sophos;i="5.84,235,1620716400"; d="scan'208";a="189762594"
Received: from orsmga001.jf.intel.com ([10.7.209.18])
by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
12 Jul 2021 18:13:48 -0700
X-IronPort-AV: E=Sophos;i="5.84,235,1620716400"; d="scan'208";a="493643511"
Received: from shwdenpg235.ccr.corp.intel.com ([10.253.106.22])
by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
12 Jul 2021 18:13:46 -0700
From: Alvin Zhang <alvinx.zhang@intel.com>
To: qi.z.zhang@intel.com, andrew.rybchenko@oktetlabs.ru,
ajit.khaparde@broadcom.com
Cc: dev@dpdk.org, Alvin Zhang <alvinx.zhang@intel.com>,
Aman Deep Singh <aman.deep.singh@intel.com>
Date: Tue, 13 Jul 2021 09:13:42 +0800
Message-Id: <20210713011342.19688-1-alvinx.zhang@intel.com>
X-Mailer: git-send-email 2.21.0.windows.1
In-Reply-To: <20210615081956.23656-1-alvinx.zhang@intel.com>
References: <20210615081956.23656-1-alvinx.zhang@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [dpdk-dev] [PATCH v4] ethdev: add IPv4 and L4 checksum RSS offload
types
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
This patch defines new RSS offload types for IPv4 and
L4(TCP/UDP/SCTP) checksum, which are required when users want
to distribute packets based on the IPv4 or L4 checksum field.
For example "flow create 0 ingress pattern eth / ipv4 / end
actions rss types ipv4-chksum end queues end / end", this flow
causes all matching packets to be distributed to queues on
basis of IPv4 checksum.
Signed-off-by: Alvin Zhang <alvinx.zhang@intel.com>
Reviewed-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Acked-by: Aman Deep Singh <aman.deep.singh@intel.com>
---
v3: Add L4 checksum RSS offload type
v4: Add doc and help string, update commit log
---
app/test-pmd/cmdline.c | 12 +++++++++---
app/test-pmd/config.c | 2 ++
lib/ethdev/rte_ethdev.h | 2 ++
3 files changed, 13 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 0268b18..93543d8 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -2254,6 +2254,10 @@ struct cmd_config_rss {
rss_conf.rss_hf = ETH_RSS_ECPRI;
else if (!strcmp(res->value, "mpls"))
rss_conf.rss_hf = ETH_RSS_MPLS;
+ else if (!strcmp(res->value, "ipv4-chksum"))
+ rss_conf.rss_hf = ETH_RSS_IPV4_CHKSUM;
+ else if (!strcmp(res->value, "l4-chksum"))
+ rss_conf.rss_hf = ETH_RSS_L4_CHKSUM;
else if (!strcmp(res->value, "none"))
rss_conf.rss_hf = 0;
else if (!strcmp(res->value, "level-default")) {
@@ -2325,7 +2329,7 @@ struct cmd_config_rss {
.help_str = "port config all rss "
"all|default|eth|vlan|ip|tcp|udp|sctp|ether|port|vxlan|geneve|"
"nvgre|vxlan-gpe|l2tpv3|esp|ah|pfcp|ecpri|mpls|none|level-default|"
- "level-outer|level-inner|<flowtype_id>",
+ "level-outer|level-inner|ipv4-chksum|l4-chksum|<flowtype_id>",
.tokens = {
(void *)&cmd_config_rss_port,
(void *)&cmd_config_rss_keyword,
@@ -2438,7 +2442,8 @@ struct cmd_config_rss_hash_key {
"ipv6-tcp-ex#ipv6-udp-ex#"
"l3-src-only#l3-dst-only#l4-src-only#l4-dst-only#"
"l2-src-only#l2-dst-only#s-vlan#c-vlan#"
- "l2tpv3#esp#ah#pfcp#pppoe#gtpu#ecpri#mpls");
+ "l2tpv3#esp#ah#pfcp#pppoe#gtpu#ecpri#mpls#"
+ "ipv4-chksum#l4-chksum");
cmdline_parse_token_string_t cmd_config_rss_hash_key_value =
TOKEN_STRING_INITIALIZER(struct cmd_config_rss_hash_key, key, NULL);
@@ -2451,7 +2456,8 @@ struct cmd_config_rss_hash_key {
"l2-payload|ipv6-ex|ipv6-tcp-ex|ipv6-udp-ex|"
"l3-src-only|l3-dst-only|l4-src-only|l4-dst-only|"
"l2-src-only|l2-dst-only|s-vlan|c-vlan|"
- "l2tpv3|esp|ah|pfcp|pppoe|gtpu|ecpri|mpls "
+ "l2tpv3|esp|ah|pfcp|pppoe|gtpu|ecpri|mpls|"
+ "ipv4-chksum|l4-chksum "
"<string of hex digits (variable length, NIC dependent)>",
.tokens = {
(void *)&cmd_config_rss_hash_key_port,
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 43c79b5..14968bf 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -140,6 +140,8 @@
{ "gtpu", ETH_RSS_GTPU },
{ "ecpri", ETH_RSS_ECPRI },
{ "mpls", ETH_RSS_MPLS },
+ { "ipv4-chksum", ETH_RSS_IPV4_CHKSUM },
+ { "l4-chksum", ETH_RSS_L4_CHKSUM },
{ NULL, 0 },
};
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index faf3bd9..63b0321 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -537,6 +537,8 @@ struct rte_eth_rss_conf {
#define ETH_RSS_PPPOE (1ULL << 31)
#define ETH_RSS_ECPRI (1ULL << 32)
#define ETH_RSS_MPLS (1ULL << 33)
+#define ETH_RSS_IPV4_CHKSUM (1ULL << 34)
+#define ETH_RSS_L4_CHKSUM (1ULL << 35) /* TCP/UDP/SCTP */
/*
* We use the following macros to combine with above ETH_RSS_* for
--
1.8.3.1