[dpdk-dev] [PATCH v1] net/ice/base: revert the change of first profile mask

[dpdk-dev] [PATCH v1] net/ice/base: revert the change of first profile mask

[Wenjun Wu]

Segmentation fault mentioned in patch[1] is related to hardware
issue.
This patch revert patch[1], since patch[1] may have protential
risk and side effect if the first profile mask is set to 0.

[1]:
commit 148fdf2d3537 ("net/ice/base: fix first profile mask")

Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>
---
 drivers/net/ice/base/ice_flex_pipe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c
index 829d88bba6..b3cea731f3 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -3432,7 +3432,7 @@ static void ice_init_prof_masks(struct ice_hw *hw, enum ice_block blk)
 	per_pf = ICE_PROF_MASK_COUNT / hw->dev_caps.num_funcs;
 
 	hw->blk[blk].masks.count = per_pf;
-	hw->blk[blk].masks.first = 0;
+	hw->blk[blk].masks.first = hw->pf_id * per_pf;
 
 	ice_memset(hw->blk[blk].masks.masks, 0,
 		   sizeof(hw->blk[blk].masks.masks), ICE_NONDMA_MEM);
-- 
2.25.1

[dpdk-dev] [PATCH v2] net/ice/base: revert the change of first profile mask

[Wenjun Wu]

Segmentation fault mentioned in patch[1] is related to hardware
issue.
This patch revert patch[1], since patch[1] may have potential
risk and side effect if the first profile mask is set to 0.

[1]:
commit 148fdf2d3537 ("net/ice/base: fix first profile mask")

Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>

---
v2: correct misspelling in commit message.
---
 drivers/net/ice/base/ice_flex_pipe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c
index 829d88bba6..b3cea731f3 100644
--- a/drivers/net/ice/base/ice_flex_pipe.c
+++ b/drivers/net/ice/base/ice_flex_pipe.c
@@ -3432,7 +3432,7 @@ static void ice_init_prof_masks(struct ice_hw *hw, enum ice_block blk)
 	per_pf = ICE_PROF_MASK_COUNT / hw->dev_caps.num_funcs;
 
 	hw->blk[blk].masks.count = per_pf;
-	hw->blk[blk].masks.first = 0;
+	hw->blk[blk].masks.first = hw->pf_id * per_pf;
 
 	ice_memset(hw->blk[blk].masks.masks, 0,
 		   sizeof(hw->blk[blk].masks.masks), ICE_NONDMA_MEM);
-- 
2.25.1

Re: [dpdk-dev] [PATCH v2] net/ice/base: revert the change of first profile mask

[Zhang, Qi Z]

> -----Original Message-----
> From: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Sent: Tuesday, July 13, 2021 10:31 AM
> To: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>
> Cc: Wu, Wenjun1 <wenjun1.wu@intel.com>
> Subject: [PATCH v2] net/ice/base: revert the change of first profile mask
> 
> Segmentation fault mentioned in patch[1] is related to hardware issue.
> This patch revert patch[1], since patch[1] may have potential risk and side
> effect if the first profile mask is set to 0.
> 
> [1]:
> commit 148fdf2d3537 ("net/ice/base: fix first profile mask")
> 
> Signed-off-by: Wenjun Wu <wenjun1.wu@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi