From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5B966A0A0C; Thu, 15 Jul 2021 15:20:39 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D43974014D; Thu, 15 Jul 2021 15:20:38 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 9204D40143 for ; Thu, 15 Jul 2021 15:20:36 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10045"; a="274371792" X-IronPort-AV: E=Sophos;i="5.84,242,1620716400"; d="scan'208";a="274371792" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jul 2021 06:20:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,242,1620716400"; d="scan'208";a="495427865" Received: from silpixa00400902.ir.intel.com ([10.243.23.84]) by FMSMGA003.fm.intel.com with ESMTP; 15 Jul 2021 06:20:33 -0700 From: Paulis Gributs To: xiaoyun.li@intel.com, ferruh.yigit@intel.com, anatoly.burakov@intel.com Cc: dev@dpdk.org, Paulis Gributs Date: Thu, 15 Jul 2021 13:20:15 +0000 Message-Id: <20210715132015.1587544-1-paulis.gributs@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Organization: Intel Corporation.... Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] app/testpmd: remove most uses of rte_eth_devices X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch removes most uses of the global variable rte_eth_devices from testpmd. This was done to avoid using the object directly which applications should not do. Most uses have been replaced with standard function calls, however the use of it in the show_macs function could not be replaced as no function call exists to get all mac addresses of a given port. Signed-off-by: Paulis Gributs --- app/test-pmd/testpmd.c | 80 +++++++++++++++++++++++++++++------------- app/test-pmd/txonly.c | 18 ++++++++-- 2 files changed, 71 insertions(+), 27 deletions(-) diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index 1cdd3cdd12..42d9804dab 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -857,16 +857,23 @@ dma_unmap_cb(struct rte_mempool *mp __rte_unused, void *opaque __rte_unused, int ret; RTE_ETH_FOREACH_DEV(pid) { - struct rte_eth_dev *dev = - &rte_eth_devices[pid]; + struct rte_eth_dev_info dev_info; - ret = rte_dev_dma_unmap(dev->device, memhdr->addr, 0, - memhdr->len); + ret = eth_dev_info_get_print_err(pid, &dev_info); + if (ret != 0) { + TESTPMD_LOG(DEBUG, + "unable to get device info for port %d on addr 0x%p," + "mempool unmapping will not be performed\n", + pid, memhdr->addr); + continue; + } + + ret = rte_dev_dma_unmap(dev_info.device, memhdr->addr, 0, memhdr->len); if (ret) { TESTPMD_LOG(DEBUG, "unable to DMA unmap addr 0x%p " "for device %s\n", - memhdr->addr, dev->data->name); + memhdr->addr, dev_info.device->name); } } ret = rte_extmem_unregister(memhdr->addr, memhdr->len); @@ -892,16 +899,22 @@ dma_map_cb(struct rte_mempool *mp __rte_unused, void *opaque __rte_unused, return; } RTE_ETH_FOREACH_DEV(pid) { - struct rte_eth_dev *dev = - &rte_eth_devices[pid]; + struct rte_eth_dev_info dev_info; - ret = rte_dev_dma_map(dev->device, memhdr->addr, 0, - memhdr->len); + ret = eth_dev_info_get_print_err(pid, &dev_info); + if (ret != 0) { + TESTPMD_LOG(DEBUG, + "unable to get device info for port %d on addr 0x%p," + "mempool mapping will not be performed\n", + pid, memhdr->addr); + continue; + } + ret = rte_dev_dma_map(dev_info.device, memhdr->addr, 0, memhdr->len); if (ret) { TESTPMD_LOG(DEBUG, "unable to DMA map addr 0x%p " "for device %s\n", - memhdr->addr, dev->data->name); + memhdr->addr, dev_info.device->name); } } } @@ -2968,6 +2981,9 @@ detach_device(struct rte_device *dev) void detach_port_device(portid_t port_id) { + int ret; + struct rte_eth_dev_info dev_info; + if (port_id_is_invalid(port_id, ENABLED_WARN)) return; @@ -2979,7 +2995,14 @@ detach_port_device(portid_t port_id) printf("Port was not closed\n"); } - detach_device(rte_eth_devices[port_id].device); + ret = eth_dev_info_get_print_err(port_id, &dev_info); + if (ret != 0) { + TESTPMD_LOG(ERR, + "Failed to get device info for port %d, not detaching\n", + port_id); + return; + } + detach_device(dev_info.device); } void @@ -3160,7 +3183,8 @@ rmv_port_callback(void *arg) int need_to_start = 0; int org_no_link_check = no_link_check; portid_t port_id = (intptr_t)arg; - struct rte_device *dev; + struct rte_eth_dev_info dev_info; + int ret; RTE_ETH_VALID_PORTID_OR_RET(port_id); @@ -3172,11 +3196,14 @@ rmv_port_callback(void *arg) stop_port(port_id); no_link_check = org_no_link_check; - /* Save rte_device pointer before closing ethdev port */ - dev = rte_eth_devices[port_id].device; close_port(port_id); - detach_device(dev); /* might be already removed or have more ports */ - + ret = eth_dev_info_get_print_err(port_id, &dev_info); + if (ret != 0) + TESTPMD_LOG(ERR, + "Failed to get device info for port %d, not detaching\n", + port_id); + else + detach_device(dev_info.device); /* might be already removed or have more ports */ if (need_to_start) start_packet_forwarding(0); } @@ -3467,13 +3494,9 @@ init_port_config(void) rte_pmd_ixgbe_bypass_init(pid); #endif - if (lsc_interrupt && - (rte_eth_devices[pid].data->dev_flags & - RTE_ETH_DEV_INTR_LSC)) + if (lsc_interrupt && (*port->dev_info.dev_flags & RTE_ETH_DEV_INTR_LSC)) port->dev_conf.intr_conf.lsc = 1; - if (rmv_interrupt && - (rte_eth_devices[pid].data->dev_flags & - RTE_ETH_DEV_INTR_RMV)) + if (rmv_interrupt && (*port->dev_info.dev_flags & RTE_ETH_DEV_INTR_RMV)) port->dev_conf.intr_conf.rmv = 1; } } @@ -3497,10 +3520,19 @@ void clear_port_slave_flag(portid_t slave_pid) uint8_t port_is_bonding_slave(portid_t slave_pid) { struct rte_port *port; + struct rte_eth_dev_info dev_info; + int ret; port = &ports[slave_pid]; - if ((rte_eth_devices[slave_pid].data->dev_flags & - RTE_ETH_DEV_BONDED_SLAVE) || (port->slave_flag == 1)) + ret = eth_dev_info_get_print_err(slave_pid, &dev_info); + if (ret != 0) { + TESTPMD_LOG(ERR, + "Failed to get device info for port id %d " + "cannot determine if the port is a bonded slave", + slave_pid); + return 0; + } + if ((*dev_info.dev_flags & RTE_ETH_DEV_BONDED_SLAVE) || (port->slave_flag == 1)) return 1; return 0; } diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index d55ee7ca00..3b7f2461bb 100644 --- a/app/test-pmd/txonly.c +++ b/app/test-pmd/txonly.c @@ -266,9 +266,21 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp, if (unlikely(timestamp_init_req != RTE_PER_LCORE(timestamp_idone))) { - struct rte_eth_dev *dev = &rte_eth_devices[fs->tx_port]; - unsigned int txqs_n = dev->data->nb_tx_queues; - uint64_t phase = tx_pkt_times_inter * fs->tx_queue / + struct rte_eth_dev_info dev_info; + unsigned int txqs_n; + uint64_t phase; + int ret; + + ret = eth_dev_info_get_print_err(fs->tx_port, &dev_info); + if (ret != 0) { + TESTPMD_LOG(ERR, + "Failed to get device info for port %d " + "could not finish timestamp init", + fs->tx_port); + return false; + } + txqs_n = dev_info.nb_tx_queues; + phase = tx_pkt_times_inter * fs->tx_queue / (txqs_n ? txqs_n : 1); /* * Initialize the scheduling time phase shift -- 2.25.1