From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26222A0547; Tue, 20 Jul 2021 00:00:29 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF9E14068F; Tue, 20 Jul 2021 00:00:28 +0200 (CEST) Received: from mail-pg1-f172.google.com (mail-pg1-f172.google.com [209.85.215.172]) by mails.dpdk.org (Postfix) with ESMTP id C48154068B for ; Tue, 20 Jul 2021 00:00:26 +0200 (CEST) Received: by mail-pg1-f172.google.com with SMTP id y4so20624936pgl.10 for ; Mon, 19 Jul 2021 15:00:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=b7iMQnQb3z/5OYqzMGUssLSOmj8UHKepla0QUrmWPQc=; b=Ge0C8r/7PruokReJPZGd72w84SYOdFvVonHmMwxBfKfQdLbof3Mhz3OXNMoEhaQTJz dsx8qBEEzIlKwnN0dQcXY3IMCoaIc+RksJcov4R06sNrXqsqr7IT+EBbRXdIqepQ6cw1 sfXPxxLOtWGUpSUTZqmyW3alFl8XmNgJpSlDB+I1xxMQ2+XqhaFeLDCA5p/lAXQWUobu Llr/XqovNJRxDRzUXQajP/L5dO9qe8cZFf8UEGCXqhUPogUR7tBPbrMT+HBU9NvFu766 cD5StrN3yx7sG69w5RuVHEw6BPk6mAXURN9fYtHTxTm9ECDby3kwBEMpPmyOg5Novlok E3VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=b7iMQnQb3z/5OYqzMGUssLSOmj8UHKepla0QUrmWPQc=; b=YGCOlM5m794Rog0SJvcEP5TOx6br+h4H0EbbomxR6c7C/VbIJOlgmTcbNn+n6Lynf7 QIUAvjczGu898sa1SY6kVrTLzeKguznMYtNPuzlBqELoKVZIgXj40LNA7VQ3DB4Cmilh esXMn7/i/1im1X9wR3f52ZfFsVliTy4D/2XzB8oFr3NJ3yuljLM0N5KhyiUkRVzLMQdI 8fPMFp8OjXoYxK+SvgXROl1iJ7yGznzHrfMah7uGG0mazeLLTP/scYzXdke6vozs5XUR PuPDIqJN6UCRyFxQ0Ao5VPqywrhLMpNtEQaE5fZCrQ1V3Bxo3rbdTHlYmDyXG35wTmsc qW7A== X-Gm-Message-State: AOAM5308ePPDjNZDynYEM9zR5Et1woL1/22uQmimnjZDGqaL+iNvVeGW WxRFHTf4df8cPKpWtoJkyOf2TQ== X-Google-Smtp-Source: ABdhPJwYdpnroAHpUAz4kZYsSWFz3FM6t01g8Es9BmfZbzAnQa8AaosXCh/a79rZqNfjQ8XTRM1BaA== X-Received: by 2002:a63:ed0a:: with SMTP id d10mr27687404pgi.82.1626732025899; Mon, 19 Jul 2021 15:00:25 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id bj15sm17510283pjb.6.2021.07.19.15.00.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Jul 2021 15:00:25 -0700 (PDT) Date: Mon, 19 Jul 2021 15:00:22 -0700 From: Stephen Hemminger To: Tyler Retzlaff Cc: dev@dpdk.org, anatoly.burakov@intel.com Message-ID: <20210719150022.249fe1a9@hermes.local> In-Reply-To: <20210719171534.GC7679@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <20210713201221.301248-1-stephen@networkplumber.org> <20210719171534.GC7679@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: fix argument to rte_bsf32_safe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 19 Jul 2021 10:15:34 -0700 Tyler Retzlaff wrote: > On Tue, Jul 13, 2021 at 01:12:21PM -0700, Stephen Hemminger wrote: > > The first argument to rte_bsf32_safe was incorrectly declared as > > a 64 bit value. This function only correctly handles on 32 bit values > > and the underlying function rte_bsf32 only accepts 32 bit values. > > This was introduced when the safe version was added and probably cause > > by copy/paste from the 64 bit version. > > there are multiple errors in this family of functions [1] both in usage > and signatures. we previously discussed rolling all fixes up into a single > patch and announcing an api break. > > a doc patch was submitted as per the process documented for breaking api > but received no replies [2] > > i have a full patch that corrects the whole family if you would like to > take it instead. contact me offline if you are interested. > > 1. http://mails.dpdk.org/archives/dev/2021-March/201590.html > 2. http://mails.dpdk.org/archives/dev/2021-March/201868.html > > the change stand-alone is correct so > > Acked-By: Tyler Retzlaff Thanks, I think the larger set should go into 21.11 where API/ABI break would be ok. My bit was all about fixing the bug where current code breaks C++ users.