From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
Cc: dev@dpdk.org, thomas@monjalon.net
Subject: Re: [dpdk-dev] RFC enabling dll/dso for dpdk on windows
Date: Mon, 19 Jul 2021 09:51:01 -0700 [thread overview]
Message-ID: <20210719165101.GA7679@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <20210719121212.6d78b06c@sovereign>
On Mon, Jul 19, 2021 at 12:12:12PM +0300, Dmitry Kozlyuk wrote:
> >
> > mingw emutls just makes it compile allowing the variables to be exported,
> > the binaries still won't work without loader support. or are you saying
> > they do?
> >
> > >
> > > No, it is not acceptable to add a generic feature supported by only one
> > > compiler. (FWIW, I'm displeased even by mlx5 being tied to clang.)
> > > Particularly, I don't understand how could MinGW and clang coexist
> > > if they export different sets of symbols. Apps will need to know
> > > if it's MingW- or clang-compiled DPDK? Sounds messy.
> >
> > it doesn't seem reasonable to reject the feature because mingw may or
> > may not work. mingw binaries are not worse off if the feature can be
> > enabled with clang. either way it is untested i am uncertain if it will
> > work with mingw and have no time budget to test it. if it made mingw
> > built binaries "worse" i would agree with you but the worst case
> > scenario is that it works exactly as well as it does now.
>
> My mistake, I thought we exported __emutls.VARNAME symbols (in which case
> MinGW DLLs would work without loader change). Since we don't, then you're
> right, we have the same set of exported symbols and can enable this feature.
> I'm willing to share the effort and help with MinGW.
sounds good to me, i'll work on a draft patch with you and when we have
something acceptable we'll formally post it.
thanks for helping out.
prev parent reply other threads:[~2021-07-19 16:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 19:21 Tyler Retzlaff
2021-07-08 20:39 ` Thomas Monjalon
2021-07-09 0:16 ` Tyler Retzlaff
2021-07-09 11:34 ` Thomas Monjalon
2021-07-09 16:09 ` Tyler Retzlaff
2021-07-08 20:49 ` Dmitry Kozlyuk
2021-07-09 1:03 ` Tyler Retzlaff
2021-07-16 9:40 ` Dmitry Kozlyuk
2021-07-19 3:45 ` Tyler Retzlaff
2021-07-19 9:12 ` Dmitry Kozlyuk
2021-07-19 16:51 ` Tyler Retzlaff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210719165101.GA7679@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).