From: Tomasz Duszynski <tduszynski@marvell.com>
To: <dev@dpdk.org>, Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>,
Sunil Kumar Kori <skori@marvell.com>,
Satha Rao <skoteshwar@marvell.com>, Ray Kinsella <mdr@ashroe.eu>
Cc: <thomas@monjalon.net>, <jerinj@marvell.com>,
Jakub Palider <jpalider@marvell.com>
Subject: [dpdk-dev] [PATCH 4/6] common/cnxk: reduce function visibility
Date: Mon, 26 Jul 2021 08:58:13 -0500 [thread overview]
Message-ID: <20210726135815.81201-5-tduszynski@marvell.com> (raw)
In-Reply-To: <20210726135815.81201-1-tduszynski@marvell.com>
From: Jakub Palider <jpalider@marvell.com>
Some functions are not used outside of local ROC scope. These need
updating classifiers and removal from header.
Signed-off-by: Jakub Palider <jpalider@marvell.com>
---
drivers/common/cnxk/roc_bphy_irq.c | 6 +++---
drivers/common/cnxk/roc_bphy_irq.h | 6 ------
drivers/common/cnxk/version.map | 3 ---
3 files changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/common/cnxk/roc_bphy_irq.c b/drivers/common/cnxk/roc_bphy_irq.c
index 882066ef3f..be3c4054af 100644
--- a/drivers/common/cnxk/roc_bphy_irq.c
+++ b/drivers/common/cnxk/roc_bphy_irq.c
@@ -123,7 +123,7 @@ roc_bphy_intr_fini(struct roc_bphy_irq_chip *irq_chip)
plt_free(irq_chip);
}
-void
+static void
roc_bphy_irq_stack_remove(int cpu)
{
struct roc_bphy_irq_stack *curr_stack;
@@ -153,7 +153,7 @@ roc_bphy_irq_stack_remove(int cpu)
pthread_mutex_unlock(&stacks_mutex);
}
-void *
+static void *
roc_bphy_irq_stack_get(int cpu)
{
#define ARM_STACK_ALIGNMENT (2 * sizeof(void *))
@@ -221,7 +221,7 @@ roc_bphy_intr_handler(unsigned int irq_num)
roc_atf_ret();
}
-int
+static int
roc_bphy_irq_handler_set(struct roc_bphy_irq_chip *chip, int irq_num,
void (*isr)(int irq_num, void *isr_data),
void *isr_data)
diff --git a/drivers/common/cnxk/roc_bphy_irq.h b/drivers/common/cnxk/roc_bphy_irq.h
index 19ec5fdc4d..0d1335b201 100644
--- a/drivers/common/cnxk/roc_bphy_irq.h
+++ b/drivers/common/cnxk/roc_bphy_irq.h
@@ -32,13 +32,7 @@ struct roc_bphy_intr {
__roc_api struct roc_bphy_irq_chip *roc_bphy_intr_init(void);
__roc_api void roc_bphy_intr_fini(struct roc_bphy_irq_chip *irq_chip);
-__roc_api void roc_bphy_irq_stack_remove(int cpu);
-__roc_api void *roc_bphy_irq_stack_get(int cpu);
__roc_api void roc_bphy_intr_handler(unsigned int irq_num);
-__roc_api int
-roc_bphy_irq_handler_set(struct roc_bphy_irq_chip *chip, int irq_num,
- void (*handler)(int irq_num, void *isr_data),
- void *isr_data);
__roc_api bool roc_bphy_intr_available(struct roc_bphy_irq_chip *irq_chip,
int irq_num);
__roc_api int roc_bphy_handler_clear(struct roc_bphy_irq_chip *chip,
diff --git a/drivers/common/cnxk/version.map b/drivers/common/cnxk/version.map
index 2cbcc4b93a..7dfc6d8a27 100644
--- a/drivers/common/cnxk/version.map
+++ b/drivers/common/cnxk/version.map
@@ -43,9 +43,6 @@ INTERNAL {
roc_bphy_intr_handler;
roc_bphy_intr_init;
roc_bphy_intr_register;
- roc_bphy_irq_handler_set;
- roc_bphy_irq_stack_get;
- roc_bphy_irq_stack_remove;
roc_clk_freq_get;
roc_cpt_afs_print;
roc_cpt_dev_clear;
--
2.25.1
next prev parent reply other threads:[~2021-07-26 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 13:58 [dpdk-dev] [PATCH 0/6] common/cnxk: sync with local codebase Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 1/6] common/cnxk: return saner error codes Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 2/6] common/cnxk: remove duplicated constant Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 3/6] raw/cnxk_bphy: don't include irq header directly Tomasz Duszynski
2021-07-26 13:58 ` Tomasz Duszynski [this message]
2021-07-26 13:58 ` [dpdk-dev] [PATCH 5/6] common/cnxk: align function naming Tomasz Duszynski
2021-07-26 13:58 ` [dpdk-dev] [PATCH 6/6] raw/cnxk_bphy: use named value for queue count Tomasz Duszynski
2021-09-28 9:18 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210726135815.81201-5-tduszynski@marvell.com \
--to=tduszynski@marvell.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=jpalider@marvell.com \
--cc=kirankumark@marvell.com \
--cc=mdr@ashroe.eu \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
--cc=skoteshwar@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).