[dpdk-dev] [PATCH 0/2] vhost: v21.11 deprecation notices

[dpdk-dev] [PATCH 0/2] vhost: v21.11 deprecation notices

[Maxime Coquelin]

Two deprecations planned for DPDK v21.11 in Vhost:
 - marking vDPA driver API as internal
 - prefixing Vhost ops struct with rte_

Maxime Coquelin (2):
  vhost: announce vDPA driver API marking as internal
  vhost: notice Vhost ops struct renaming

 doc/guides/rel_notes/deprecation.rst | 7 +++++++
 1 file changed, 7 insertions(+)

-- 
2.31.1

[dpdk-dev] [PATCH 1/2] vhost: announce vDPA driver API marking as internal

[Maxime Coquelin]

This patch announces the marking if all the vDPA driver API
as internal.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 9584d6bfd7..b34bed61a6 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -147,3 +147,7 @@ Deprecation Notices
 * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific
   content. On Linux and FreeBSD, supported prior to DPDK 20.11,
   original structure will be kept until DPDK 21.11.
+
+* vhost: ``rte_vdpa_register_device``, ``rte_vdpa_unregister_device``,
+  ``rte_vhost_host_notifier_ctrl`` and ``rte_vdpa_relay_vring_used`` vDPA
+  driver API will be marked as internal in DPDK v21.11.
-- 
2.31.1

[dpdk-dev] [PATCH 2/2] vhost: notice Vhost ops struct renaming

[Maxime Coquelin]

This patch announce the renaming of struct vhost_device_ops
to rte_vhost_device_ops in DPDK v21.11.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b34bed61a6..76ebf162bd 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -151,3 +151,6 @@ Deprecation Notices
 * vhost: ``rte_vdpa_register_device``, ``rte_vdpa_unregister_device``,
   ``rte_vhost_host_notifier_ctrl`` and ``rte_vdpa_relay_vring_used`` vDPA
   driver API will be marked as internal in DPDK v21.11.
+
+* vhost: rename ``struct vhost_device_ops`` to ``struct rte_vhost_device_ops``
+  int DPDK v21.11.
-- 
2.31.1

Re: [dpdk-dev] [PATCH 1/2] vhost: announce vDPA driver API marking as internal

[Xia, Chenbo]

Hi Maxime,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Thursday, July 29, 2021 10:43 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; amorenoz@redhat.com;
> Richardson, Bruce <bruce.richardson@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; thomas@monjalon.net; aconole@redhat.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH 1/2] vhost: announce vDPA driver API marking as internal
> 
> This patch announces the marking if all the vDPA driver API
> as internal.

Marking if all -> marking all?

And API -> APIs

With things fixed:

Acked-by: Chenbo Xia <chenbo.xia@intel.com>

> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 9584d6bfd7..b34bed61a6 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -147,3 +147,7 @@ Deprecation Notices
>  * cmdline: ``cmdline`` structure will be made opaque to hide platform-
> specific
>    content. On Linux and FreeBSD, supported prior to DPDK 20.11,
>    original structure will be kept until DPDK 21.11.
> +
> +* vhost: ``rte_vdpa_register_device``, ``rte_vdpa_unregister_device``,
> +  ``rte_vhost_host_notifier_ctrl`` and ``rte_vdpa_relay_vring_used`` vDPA
> +  driver API will be marked as internal in DPDK v21.11.
> --
> 2.31.1

Re: [dpdk-dev] [PATCH 2/2] vhost: notice Vhost ops struct renaming

[Xia, Chenbo]

Hi Maxime,

> -----Original Message-----
> From: Maxime Coquelin <maxime.coquelin@redhat.com>
> Sent: Thursday, July 29, 2021 10:43 PM
> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; amorenoz@redhat.com;
> Richardson, Bruce <bruce.richardson@intel.com>; Yigit, Ferruh
> <ferruh.yigit@intel.com>; thomas@monjalon.net; aconole@redhat.com
> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
> Subject: [PATCH 2/2] vhost: notice Vhost ops struct renaming
> 
> This patch announce the renaming of struct vhost_device_ops
> to rte_vhost_device_ops in DPDK v21.11.

Announce -> announces

With things fixed:

Acked-by: Chenbo Xia <chenbo.xia@intel.com>

> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index b34bed61a6..76ebf162bd 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -151,3 +151,6 @@ Deprecation Notices
>  * vhost: ``rte_vdpa_register_device``, ``rte_vdpa_unregister_device``,
>    ``rte_vhost_host_notifier_ctrl`` and ``rte_vdpa_relay_vring_used`` vDPA
>    driver API will be marked as internal in DPDK v21.11.
> +
> +* vhost: rename ``struct vhost_device_ops`` to ``struct
> rte_vhost_device_ops``
> +  int DPDK v21.11.
> --
> 2.31.1

Re: [dpdk-dev] [PATCH 1/2] vhost: announce vDPA driver API marking as internal

[Maxime Coquelin]

On 7/30/21 7:32 AM, Xia, Chenbo wrote:
> Hi Maxime,
> 
>> -----Original Message-----
>> From: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Sent: Thursday, July 29, 2021 10:43 PM
>> To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; amorenoz@redhat.com;
>> Richardson, Bruce <bruce.richardson@intel.com>; Yigit, Ferruh
>> <ferruh.yigit@intel.com>; thomas@monjalon.net; aconole@redhat.com
>> Cc: Maxime Coquelin <maxime.coquelin@redhat.com>
>> Subject: [PATCH 1/2] vhost: announce vDPA driver API marking as internal
>>
>> This patch announces the marking if all the vDPA driver API
>> as internal.
> 
> Marking if all -> marking all?

I meant marking of

> And API -> APIs
> 
> With things fixed:
> 
> Acked-by: Chenbo Xia <chenbo.xia@intel.com>

Thanks, I'll post a v2.

Maxime

>>
>> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>> ---
>>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/doc/guides/rel_notes/deprecation.rst
>> b/doc/guides/rel_notes/deprecation.rst
>> index 9584d6bfd7..b34bed61a6 100644
>> --- a/doc/guides/rel_notes/deprecation.rst
>> +++ b/doc/guides/rel_notes/deprecation.rst
>> @@ -147,3 +147,7 @@ Deprecation Notices
>>  * cmdline: ``cmdline`` structure will be made opaque to hide platform-
>> specific
>>    content. On Linux and FreeBSD, supported prior to DPDK 20.11,
>>    original structure will be kept until DPDK 21.11.
>> +
>> +* vhost: ``rte_vdpa_register_device``, ``rte_vdpa_unregister_device``,
>> +  ``rte_vhost_host_notifier_ctrl`` and ``rte_vdpa_relay_vring_used`` vDPA
>> +  driver API will be marked as internal in DPDK v21.11.
>> --
>> 2.31.1
> 

Re: [dpdk-dev] [PATCH 2/2] vhost: notice Vhost ops struct renaming

[Adrian Moreno]

On 7/29/21 4:42 PM, Maxime Coquelin wrote:
> This patch announce the renaming of struct vhost_device_ops
> to rte_vhost_device_ops in DPDK v21.11.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index b34bed61a6..76ebf162bd 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -151,3 +151,6 @@ Deprecation Notices
>  * vhost: ``rte_vdpa_register_device``, ``rte_vdpa_unregister_device``,
>    ``rte_vhost_host_notifier_ctrl`` and ``rte_vdpa_relay_vring_used`` vDPA
>    driver API will be marked as internal in DPDK v21.11.
> +
> +* vhost: rename ``struct vhost_device_ops`` to ``struct rte_vhost_device_ops``
> +  int DPDK v21.11.
> 

With nits spotted by Chenbo,

Acked-by: Adrian Moreno <amorenoz@redhat.com>