DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] doc: announce the deprecation of lcore state FINISHED
@ 2021-07-30 19:59 Honnappa Nagarahalli
  2021-08-05  6:13 ` [dpdk-dev] 回复: " Feifei Wang
  0 siblings, 1 reply; 4+ messages in thread
From: Honnappa Nagarahalli @ 2021-07-30 19:59 UTC (permalink / raw)
  To: dev, honnappa.nagarahalli, thomas, konstantin.ananyev, feifei.wang
  Cc: ruifeng.wang, nd

Lcore state FINISHED is used by the worker thread to indicate that
it has completed the assigned task. The state is changed to
WAIT by another thread after it observes the updated state. This
additional step is redundant. After this deprecation, the worker
thread will update the state to WAIT.

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
More discussion at:
http://patches.dpdk.org/project/dpdk/patch/20210224212018.17576-4-honnappa.nagarahalli@arm.com/

 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 9584d6bfd7..3adbde9e94 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -11,6 +11,10 @@ here.
 Deprecation Notices
 -------------------
 
+* eal: The lcore state FINISHED will be removed from the enum
+  rte_lcore_state_t. The lcore state WAIT is enough to represent the same
+  state.
+
 * kvargs: The function ``rte_kvargs_process`` will get a new parameter
   for returning key match count. It will ease handling of no-match case.
 
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-dev] 回复:  [PATCH] doc: announce the deprecation of lcore state FINISHED
  2021-07-30 19:59 [dpdk-dev] [PATCH] doc: announce the deprecation of lcore state FINISHED Honnappa Nagarahalli
@ 2021-08-05  6:13 ` Feifei Wang
  2021-08-07 13:31   ` Jerin Jacob
  0 siblings, 1 reply; 4+ messages in thread
From: Feifei Wang @ 2021-08-05  6:13 UTC (permalink / raw)
  To: Honnappa Nagarahalli, dev, Honnappa Nagarahalli, thomas,
	konstantin.ananyev
  Cc: Ruifeng Wang, nd, nd

> -----邮件原件-----
> 发件人: dev <dev-bounces@dpdk.org> 代表 Honnappa Nagarahalli
> 发送时间: Saturday, July 31, 2021 3:59 AM
> 收件人: dev@dpdk.org; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; thomas@monjalon.net;
> konstantin.ananyev@intel.com; Feifei Wang (Arm Technology China)
> <Feifei.Wang@arm.com>
> 抄送: Ruifeng Wang <Ruifeng.Wang@arm.com>; nd <nd@arm.com>
> 主题: [dpdk-dev] [PATCH] doc: announce the deprecation of lcore state
> FINISHED
> 
> Lcore state FINISHED is used by the worker thread to indicate that it has
> completed the assigned task. The state is changed to WAIT by another
> thread after it observes the updated state. This additional step is redundant.
> After this deprecation, the worker thread will update the state to WAIT.
> 
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> ---
Acked-by: Feifei Wang <feifei.wang2@arm.com>

> More discussion at:
> http://patches.dpdk.org/project/dpdk/patch/20210224212018.17576-4-
> honnappa.nagarahalli@arm.com/
> 
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 9584d6bfd7..3adbde9e94 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -11,6 +11,10 @@ here.
>  Deprecation Notices
>  -------------------
> 
> +* eal: The lcore state FINISHED will be removed from the enum
> +  rte_lcore_state_t. The lcore state WAIT is enough to represent the
> +same
> +  state.
> +
>  * kvargs: The function ``rte_kvargs_process`` will get a new parameter
>    for returning key match count. It will ease handling of no-match case.
> 
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] 回复: [PATCH] doc: announce the deprecation of lcore state FINISHED
  2021-08-05  6:13 ` [dpdk-dev] 回复: " Feifei Wang
@ 2021-08-07 13:31   ` Jerin Jacob
  2021-08-07 14:59     ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Jerin Jacob @ 2021-08-07 13:31 UTC (permalink / raw)
  To: Feifei Wang
  Cc: Honnappa Nagarahalli, dev, thomas, konstantin.ananyev, Ruifeng Wang, nd

On Thu, Aug 5, 2021 at 11:43 AM Feifei Wang <Feifei.Wang2@arm.com> wrote:
>
> > -----邮件原件-----
> > 发件人: dev <dev-bounces@dpdk.org> 代表 Honnappa Nagarahalli
> > 发送时间: Saturday, July 31, 2021 3:59 AM
> > 收件人: dev@dpdk.org; Honnappa Nagarahalli
> > <Honnappa.Nagarahalli@arm.com>; thomas@monjalon.net;
> > konstantin.ananyev@intel.com; Feifei Wang (Arm Technology China)
> > <Feifei.Wang@arm.com>
> > 抄送: Ruifeng Wang <Ruifeng.Wang@arm.com>; nd <nd@arm.com>
> > 主题: [dpdk-dev] [PATCH] doc: announce the deprecation of lcore state
> > FINISHED
> >
> > Lcore state FINISHED is used by the worker thread to indicate that it has
> > completed the assigned task. The state is changed to WAIT by another
> > thread after it observes the updated state. This additional step is redundant.
> > After this deprecation, the worker thread will update the state to WAIT.
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > ---
> Acked-by: Feifei Wang <feifei.wang2@arm.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>


>
> > More discussion at:
> > http://patches.dpdk.org/project/dpdk/patch/20210224212018.17576-4-
> > honnappa.nagarahalli@arm.com/
> >
> >  doc/guides/rel_notes/deprecation.rst | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 9584d6bfd7..3adbde9e94 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -11,6 +11,10 @@ here.
> >  Deprecation Notices
> >  -------------------
> >
> > +* eal: The lcore state FINISHED will be removed from the enum
> > +  rte_lcore_state_t. The lcore state WAIT is enough to represent the
> > +same
> > +  state.
> > +
> >  * kvargs: The function ``rte_kvargs_process`` will get a new parameter
> >    for returning key match count. It will ease handling of no-match case.
> >
> > --
> > 2.17.1
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-dev] 回复: [PATCH] doc: announce the deprecation of lcore state FINISHED
  2021-08-07 13:31   ` Jerin Jacob
@ 2021-08-07 14:59     ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2021-08-07 14:59 UTC (permalink / raw)
  To: Honnappa Nagarahalli
  Cc: Feifei Wang, dev, dev, konstantin.ananyev, Ruifeng Wang, nd, Jerin Jacob

> > > Lcore state FINISHED is used by the worker thread to indicate that it has
> > > completed the assigned task. The state is changed to WAIT by another
> > > thread after it observes the updated state. This additional step is redundant.
> > > After this deprecation, the worker thread will update the state to WAIT.
> > >
> > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > > Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> > > ---
> > Acked-by: Feifei Wang <feifei.wang2@arm.com>
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks.



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-08-07 14:59 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-30 19:59 [dpdk-dev] [PATCH] doc: announce the deprecation of lcore state FINISHED Honnappa Nagarahalli
2021-08-05  6:13 ` [dpdk-dev] 回复: " Feifei Wang
2021-08-07 13:31   ` Jerin Jacob
2021-08-07 14:59     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).