From: Thomas Monjalon <thomas@monjalon.net> To: dev@dpdk.org Cc: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Bruce Richardson <bruce.richardson@intel.com> Subject: [dpdk-dev] [PATCH v2] devtools: test different build types Date: Tue, 3 Aug 2021 00:45:17 +0200 Message-ID: <20210802224518.1179190-1-thomas@monjalon.net> (raw) In-Reply-To: <20210412215339.2439530-1-thomas@monjalon.net> All builds were of type debugoptimized. It is kept only for builds having an ABI check. Others will have the default build type (release), except if specified differently as in the x86 generic build which will be a test of the non-optimized debug build type. Some static builds will test the minsize build type. Signed-off-by: Thomas Monjalon <thomas@monjalon.net> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> --- v2: fix init of var buildtype --- devtools/test-meson-builds.sh | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 9ec8e2bc7e..7bd305a669 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -92,13 +92,16 @@ load_env () # <target compiler> command -v $targetcc >/dev/null 2>&1 || return 1 } -config () # <dir> <builddir> <meson options> +config () # <dir> <builddir> <ABI check> <meson options> { dir=$1 shift builddir=$1 shift + abicheck=$1 + shift if [ -f "$builddir/build.ninja" ] ; then + [ $abicheck = ABI ] || return 0 # for existing environments, switch to debugoptimized if unset # so that ABI checks can run if ! $MESON configure $builddir | @@ -114,7 +117,9 @@ config () # <dir> <builddir> <meson options> else options="$options -Dexamples=l3fwd" # save disk space fi - options="$options --buildtype=debugoptimized" + if [ $abicheck = ABI ] ; then + options="$options --buildtype=debugoptimized" + fi for option in $DPDK_MESON_OPTIONS ; do options="$options -D$option" done @@ -165,7 +170,7 @@ build () # <directory> <target cc | cross file> <ABI check> [meson options] cross= fi load_env $targetcc || return 0 - config $srcdir $builds_dir/$targetdir $cross --werror $* + config $srcdir $builds_dir/$targetdir $abicheck $cross --werror $* compile $builds_dir/$targetdir if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION @@ -179,7 +184,7 @@ build () # <directory> <target cc | cross file> <ABI check> [meson options] fi rm -rf $abirefdir/build - config $abirefdir/src $abirefdir/build $cross \ + config $abirefdir/src $abirefdir/build $abicheck $cross \ -Dexamples= $* compile $abirefdir/build install_target $abirefdir/build $abirefdir/$targetdir @@ -211,11 +216,13 @@ for c in gcc clang ; do for s in static shared ; do if [ $s = shared ] ; then abicheck=ABI + buildtype= else abicheck=skipABI # save time and disk space + buildtype='--buildtype=minsize' fi export CC="$CCACHE $c" - build build-$c-$s $c $abicheck --default-library=$s + build build-$c-$s $c $abicheck $buildtype --default-library=$s unset CC done done @@ -227,7 +234,7 @@ generic_isa='nehalem' if ! check_cc_flags "-march=$generic_isa" ; then generic_isa='corei7' fi -build build-x86-generic cc skipABI -Dcheck_includes=true \ +build build-x86-generic cc skipABI --buildtype=debug -Dcheck_includes=true \ -Dlibdir=lib -Dcpu_instruction_set=$generic_isa $use_shared # 32-bit with default compiler -- 2.31.1
next prev parent reply other threads:[~2021-08-02 22:45 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-12 21:53 [dpdk-dev] [PATCH] " Thomas Monjalon 2021-05-21 15:03 ` David Marchand 2021-07-23 20:26 ` Andrew Rybchenko 2021-08-02 22:45 ` Thomas Monjalon [this message] 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 0/5] more build tests Thomas Monjalon 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 1/5] net/qede: fix minsize build Thomas Monjalon 2021-08-09 5:15 ` [dpdk-dev] [EXT] " Devendra Singh Rawat 2021-08-09 7:11 ` Rasesh Mody 2021-09-15 15:16 ` David Marchand 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 2/5] regex/mlx5: " Thomas Monjalon 2021-08-11 8:48 ` Ruifeng Wang 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 3/5] vdpa/mlx5: " Thomas Monjalon 2021-08-09 6:43 ` Matan Azrad 2021-08-11 8:48 ` Ruifeng Wang 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 4/5] test/crypto: " Thomas Monjalon 2021-08-11 8:48 ` Ruifeng Wang 2021-08-08 12:51 ` [dpdk-dev] [PATCH v3 5/5] devtools: test different build types Thomas Monjalon 2021-09-15 20:27 ` [dpdk-dev] [PATCH v3 0/5] more build tests Ferruh Yigit 2021-09-16 7:05 ` David Marchand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20210802224518.1179190-1-thomas@monjalon.net \ --to=thomas@monjalon.net \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=bruce.richardson@intel.com \ --cc=dev@dpdk.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git