From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 705C9A0A0C; Sun, 8 Aug 2021 14:52:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4761941174; Sun, 8 Aug 2021 14:51:55 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id C6C774117E for ; Sun, 8 Aug 2021 14:51:53 +0200 (CEST) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7E7405C00D8; Sun, 8 Aug 2021 08:51:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sun, 08 Aug 2021 08:51:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; s=fm1; bh=oMpwMIIkQeAkX oQGL2zpp6Ef+GLmB1ae5ewAamYSTJo=; b=IxcLpO0LqX8mZ86q+etjLQwcB2fzO 7/HFKHbT6rZd1is9kKLDG1+58Rp6RIDywb2Lsq9V3eoG8ga6GRuiMZA27O3tMzms 9+p+B9CMzcPCZxoTCuDvYDvDcTGN9HdI9oNuRMiy0/UXEmWisRQfHNDaX+7cANpV p81n2LbMnAxTRCEsJDwqHJYdQE3zGFS6kl5vYSmCdDRr8b4aZpje/XlX7/o6kaGV IjCC+bMAlEmEx52ZQLanrZTH4shquYaQfA18yQaUGgXsId7NtPS0v89eGAylDcCD fskqE76cWiziypjCl9jomY3uuBQk9IIc+ZVB53lTPbvirDrp2BZnpfCKw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:date:from :in-reply-to:message-id:mime-version:references:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=oMpwMIIkQeAkXoQGL2zpp6Ef+GLmB1ae5ewAamYSTJo=; b=qwDQ8leM lrhc5SinqxjI3+6pk+o0RBwI8aYKfnCOWj+qWDGgPEVsGUJkfKyHAZ/7DeBMyRVe N7fD71tBu2x+vCU1hJeDFCdahEk6bhsEhFdFTLK+ClViSF55bY0DOwVjo7zB6Bjq fs9eof86/AWCMZWeQVTBE0sUtfxb/dBGDSmIr1vQgl83Qpoy2GJN8rQxvUELC2fe q3VJ0y2dxMTxXr4K2zd3k7ZryvaPZBtqg9Onvtb/VatR7IvoMRjfsQL1mompCL7x BeBYl1bGY8YWvyRSMKFCQTcwtuh+OM78ei1goLishvzGQaNfFRCgdPqwOe6yfKYF chOpk9A1RXkZmA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrjeehgdehjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkofgjfhgggfestdekredtredttdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedvhefgiedvjeegtdevheefhfetleefgfeivefgffevfeejgedtgfeu tdehtdegveenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 8 Aug 2021 08:51:52 -0400 (EDT) From: Thomas Monjalon To: dev@dpdk.org Cc: bruce.richardson@intel.com, david.marchand@redhat.com, Andrew Rybchenko Date: Sun, 8 Aug 2021 14:51:38 +0200 Message-Id: <20210808125139.3573701-6-thomas@monjalon.net> X-Mailer: git-send-email 2.31.1 In-Reply-To: <20210808125139.3573701-1-thomas@monjalon.net> References: <20210412215339.2439530-1-thomas@monjalon.net> <20210808125139.3573701-1-thomas@monjalon.net> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 5/5] devtools: test different build types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All builds were of type debugoptimized. It is kept only for builds having an ABI check. Others will have the default build type (release), except if specified differently as in the x86 generic build which will be a test of the non-optimized debug build type. Some static builds will test the minsize build type. Signed-off-by: Thomas Monjalon Acked-by: Andrew Rybchenko --- This patch cannot be merged now because it makes clang 11.1.0 crashing. --- devtools/test-meson-builds.sh | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 9ec8e2bc7e..7bd305a669 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -92,13 +92,16 @@ load_env () # command -v $targetcc >/dev/null 2>&1 || return 1 } -config () # +config () # { dir=$1 shift builddir=$1 shift + abicheck=$1 + shift if [ -f "$builddir/build.ninja" ] ; then + [ $abicheck = ABI ] || return 0 # for existing environments, switch to debugoptimized if unset # so that ABI checks can run if ! $MESON configure $builddir | @@ -114,7 +117,9 @@ config () # else options="$options -Dexamples=l3fwd" # save disk space fi - options="$options --buildtype=debugoptimized" + if [ $abicheck = ABI ] ; then + options="$options --buildtype=debugoptimized" + fi for option in $DPDK_MESON_OPTIONS ; do options="$options -D$option" done @@ -165,7 +170,7 @@ build () # [meson options] cross= fi load_env $targetcc || return 0 - config $srcdir $builds_dir/$targetdir $cross --werror $* + config $srcdir $builds_dir/$targetdir $abicheck $cross --werror $* compile $builds_dir/$targetdir if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION @@ -179,7 +184,7 @@ build () # [meson options] fi rm -rf $abirefdir/build - config $abirefdir/src $abirefdir/build $cross \ + config $abirefdir/src $abirefdir/build $abicheck $cross \ -Dexamples= $* compile $abirefdir/build install_target $abirefdir/build $abirefdir/$targetdir @@ -211,11 +216,13 @@ for c in gcc clang ; do for s in static shared ; do if [ $s = shared ] ; then abicheck=ABI + buildtype= else abicheck=skipABI # save time and disk space + buildtype='--buildtype=minsize' fi export CC="$CCACHE $c" - build build-$c-$s $c $abicheck --default-library=$s + build build-$c-$s $c $abicheck $buildtype --default-library=$s unset CC done done @@ -227,7 +234,7 @@ generic_isa='nehalem' if ! check_cc_flags "-march=$generic_isa" ; then generic_isa='corei7' fi -build build-x86-generic cc skipABI -Dcheck_includes=true \ +build build-x86-generic cc skipABI --buildtype=debug -Dcheck_includes=true \ -Dlibdir=lib -Dcpu_instruction_set=$generic_isa $use_shared # 32-bit with default compiler -- 2.31.1