From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46F31A0C57; Sat, 14 Aug 2021 13:31:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE7B44068F; Sat, 14 Aug 2021 13:31:11 +0200 (CEST) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by mails.dpdk.org (Postfix) with ESMTP id E22BB4013F for ; Sat, 14 Aug 2021 13:31:10 +0200 (CEST) Received: by mail-lf1-f45.google.com with SMTP id w20so25019599lfu.7 for ; Sat, 14 Aug 2021 04:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oBoVcu+IwTtvKQoqXZk5rNccJnXB+PkhY/9bBm2Vv/s=; b=NRTh83oL3v+/lz/u7qV4+pwr+FBxEws0epHLyc0/rJ96ZbQHFxJpD8SzrNzD8yZCsT bTDC1YbnOyEcwfzuTUZXwv35R5o8DOsC8bhKO4DkOumuxU0RbL8S0HsOaLbjJXLIvnKB 3suL1RWR+ZnIOniGSVFx8vPuqONQ43xk7r/eVOVDUDm3IyzFekXB6M5fXjQZRYLg4mdc xVfDCbW8aAfzAuJ7fR/qCzs4SFT8/yFoMxIO/Iw73yr45fmoO/G6Y06bMfb34AyGQ4CG JqWQITW/ozV2jPgyhekXyFs7uaO45VBSk5Xq1cp+hEZZuszf+vCl3Gu79YtzrqzLKta9 XLHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oBoVcu+IwTtvKQoqXZk5rNccJnXB+PkhY/9bBm2Vv/s=; b=azqGKwX+hc0xtGF9NQH2wv8P/a7LqycAx+rwya+IRvMX0mLzrVL84mkBs32oNx/O8x IHAUVFo5xk90CnBhPS45b9TyT93Y9LO3yt9B9g0dM+Q21r2Kal8VJ1lto2MzTLEH+Nc1 2AGLC/qp8drx71LT0N4LlQgsgAquvQ/fTztCoZTTI3938XSgYENTqytedo1Dy0OXbBOU GD0V1yw/bP80Gdl98WnkO4lP/jTKIaqtzUrn/wzGmJjfXHqf4+dmvxmPU2+pqGTflF1M OHI8wFQi5bPz08rqVpTP5LhzhpbIpuzFjNXudKhQQNFwyBplE+xpP+mxdgSAz5U3lx1M 12yw== X-Gm-Message-State: AOAM532dTgz+4XRN+a8aP8d3HapTZL33nIIp9grZ3X8UvhZddTMf4Frq VVQBhc3BK8QRA2hNtcBjfA8= X-Google-Smtp-Source: ABdhPJxsG4/JoVrGV+w6T66ahaiGuNN9Yz9SQxuLlVsou8L2L8NpW4cTu1psXSegyW6DQF05+9m5mg== X-Received: by 2002:ac2:4317:: with SMTP id l23mr4811662lfh.116.1628940670484; Sat, 14 Aug 2021 04:31:10 -0700 (PDT) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id s28sm395062lfp.45.2021.08.14.04.31.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 14 Aug 2021 04:31:09 -0700 (PDT) Date: Sat, 14 Aug 2021 14:31:08 +0300 From: Dmitry Kozlyuk To: William Tu Cc: dev@dpdk.org, Igor Chauskin , Evgeny Schemeilin , Shai Brandes , Michal Krawczyk , Marcin Wojtas , Narcisa Ana Maria Vasile Message-ID: <20210814143108.128803ef@sovereign> In-Reply-To: <20210814033609.58553-1-u9012063@gmail.com> References: <20210814033609.58553-1-u9012063@gmail.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH RFC] net/ena: Add Windows support. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi William, 2021-08-14 03:36 (UTC+0000), William Tu: > I don't have a physical Windows testbed so I want to see if I can > get virtual nic working, in this case ENA driver on AWS. > The patch passes build on Windows, but I haven't tested loading > the ena driver. > I want to know if this is the right direction, > or whether I also need to change other places in ENA driver? Cc'ing maintainers. > I copy some of the pthread code from > https://nachtimwald.com/2019/04/05/cross-platform-thread-wrapper/ We don't want to add more pthread shims, pthread.h in DPDK will go away. Condition variable support should be added to the new threading API: http://inbox.dpdk.org/dev/1628017291-3756-1-git-send-email-navasile@linux.microsoft.com I suppose it can be done independently of the new threading API series. When copying code to DPDK from elsewhere, please adapt its style to DPDK conventions (e.g. `RTE_UNUSED(foo)` instead if `(void)foo`) and mind the license if big pieces are copied verbatim (this is not the case here). > https://stackoverflow.com/questions/10905892/equivalent-of-gettimeday-for-windows POSIX gettimeofday() should be replaced with standard C timespec_get(). > Thanks. > > Signed-off-by: William Tu > --- > drivers/net/ena/base/ena_com.c | 4 +- > drivers/net/ena/base/ena_plat.h | 2 +- > drivers/net/ena/base/ena_plat_dpdk.h | 14 +++- > drivers/net/ena/meson.build | 5 -- > lib/eal/version.map | 2 +- > lib/eal/windows/include/pthread.h | 105 ++++++++++++++++++++++++++ > lib/eal/windows/include/rte_windows.h | 1 + > 7 files changed, 120 insertions(+), 13 deletions(-) This should be a series of two patches: 1) adding condition variable wrappers to EAL; 2) supporting net/ena for Windows.