From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F463A0547; Tue, 17 Aug 2021 01:03:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2F4240143; Tue, 17 Aug 2021 01:03:51 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id D127740142 for ; Tue, 17 Aug 2021 01:03:50 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id oa17so28890271pjb.1 for ; Mon, 16 Aug 2021 16:03:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OJ1AtV/vmkYB4xiwgNqyJF04fCRX+dHAabJYN9nFkZA=; b=USqSKgPsYX3WPsyT/1drtmuLbuheCJVqjxr4xmzetws4c0S+T9fmCTPZHBL4fph02W Gu7SMGEuKK+J3tvlb80fl1kmKN0a9tQY3BzKaXrnGa8ERFIHLcIxtZJbhuvYSjCxAZFp uMLXksvUzQeb21DvupPmHv42y+1QB6Qxw1fauVruMcJqBSBZ5p00leGpdlbKq/i5PQbw NLktxKgpqSqFFxou1WMsiPHIysE5VIp/ep1mRj0eCCqH5JoeSidDuAngSV7BH9imE1qi 8B6MAKad7JxhnnrnuDBRalRzhZUJWwhhUQfo1gdEfX9P3hfvmZRiMDR2bGyq1a9HwxTe MS8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OJ1AtV/vmkYB4xiwgNqyJF04fCRX+dHAabJYN9nFkZA=; b=f85TOE2KpHgw9CkL+M2tkAteWoxKBRPHLV6q4z3w+jRAgwLpzyM/Z0iKt5gA+C/rAD NAxfbq2LkV3YC17WN/5VY5YgzCW7D4FaxrCM+5TE/FcvsoGHgAkbCurQWIfyWgo2OavN es/DBP9OW7+4DkcnYXYcH5+aj29bewhqiDHMGK7IGStG/C0ubQ8ErCzkSxlYrmWzyz2V xhh71cshXKJTBQxrGUKxTZj+AN9BgEdD1GQz0GNDwkJHXaY/qs73nbkMafpsEG0+91UT Me3KkVu+fnbs0MzoyDfn3fWbQA4erGxo+4hkEQePSOKkWIDXtKOzXKI+9hzA1WJb0vjA fCtg== X-Gm-Message-State: AOAM532R2EFg60YhID+e8U7AloTtqiR8fYYGnxipfkcvawtmJJqKHKs6 Hd1ZJVrQ4ZkDzFSVeFYmjgFLcw== X-Google-Smtp-Source: ABdhPJz6cym8Hyk4nmUedf33f2MHKfePI5690Bjnvw71puUPLCF2kogwPuPZkDWchWWaNZItQbAVCA== X-Received: by 2002:a62:1d44:0:b0:3e2:18ae:f3dc with SMTP id d65-20020a621d44000000b003e218aef3dcmr486990pfd.48.1629155029980; Mon, 16 Aug 2021 16:03:49 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id u21sm200730pfh.163.2021.08.16.16.03.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Aug 2021 16:03:49 -0700 (PDT) Date: Mon, 16 Aug 2021 16:03:47 -0700 From: Stephen Hemminger To: Aman Singh Cc: dev@dpdk.org Message-ID: <20210816160347.0a35723a@hermes.local> In-Reply-To: <20210816095728.17193-3-aman.deep.singh@intel.com> References: <20210816095728.17193-1-aman.deep.singh@intel.com> <20210816095728.17193-3-aman.deep.singh@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC address bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 16 Aug 2021 15:27:28 +0530 Aman Singh wrote: > Added macros to simplify print of MAC address. > The six bytes of a MAC address are extracted in > a macro here, to improve code readablity. > > Signed-off-by: Aman Singh > Reviewed-by: Ferruh Yigit > --- > The change in the document will be done in seperate patch. > To ensure document has direct reference of the code as shown in > commit 413c75c33c40 ("doc: show how to include code in guides"). NAK The DPDK already has rte_ether_format_addr() why does so much code not use it?