From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 384E3A0548; Tue, 17 Aug 2021 17:25:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11FD440DF5; Tue, 17 Aug 2021 17:25:48 +0200 (CEST) Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) by mails.dpdk.org (Postfix) with ESMTP id A41444014E for ; Tue, 17 Aug 2021 17:25:46 +0200 (CEST) Received: by mail-pl1-f181.google.com with SMTP id u1so8123416plr.1 for ; Tue, 17 Aug 2021 08:25:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=J+Ka/8NxpLXKFG0iVQ33++zrmWPGsCQk88pCaT8PnSQ=; b=AglsN2lRVEooIRDbGkYXzLZ8eXixQfWSBL6QW5hHPk5F+ZAlj0Xa/eayKWGodLn/yC vnU33An35qoCOUnWbiEEoMj60IDSpCiOf+e6A5u/WbXSkSC81rHPGZUGAHqh8W6C/Twz 1npw+Og+GW7g0x2bEVO5GwOFTZtxLCt68fyBkHSf3A7Rqy2W3laEIRhhtwCwXBgfJ8XV MDVZKz+RjEhvB+cPnRK1hy41rL4SkcfjbCkPiSG/1juRzmgEXh0Otuyowj6vETysRUFf CZpVOlo5gda0UeUEUEZmWdhd5TPHTCDfOOBk9XJPx3eMkIo1X+K0KtLfXn0TiEOdNWf/ OQQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=J+Ka/8NxpLXKFG0iVQ33++zrmWPGsCQk88pCaT8PnSQ=; b=Nar1jlrWdtPjhOsaMC3KS5pd1zvWIKUbHhIJFM2+aTIfNjlNd/XA4/Q+HAb7iIHI9C gySpvhwxMAHNQJobTl3a3FPtI5ElHoFBmBOAuHtUGq6c/JqruN1nTg4CGrnvAi1u1fVe pHm3bLAFiHlG74thc2d0LvzhtxrCEdZwVvOEKkxmyaOLs8aUGafzYgjCgBMWwO6YBn9U b/Oa0Qhhhyu8M2v8bVeEENnLImfPw82co6hoRdbB2XRJZRrQG69cw1S/BDAgisaUQVJs V+jO/Gd8RUd+z+wRZLhhV4FXDYu4/Y7/P/fm4BR0kvCrZZOhObDy8yS8E9yvy2fH22m0 lWOg== X-Gm-Message-State: AOAM532CrYy5dExVVMWumTRFH0tazBmAbT8qUIjT40Q9XvglD4U9SQcE X3UoO+dWDD2p+YraMwgiXFdG9Q== X-Google-Smtp-Source: ABdhPJwwX6BvU+UNx5qRIue7kX0NkpGu7Lw3m7vDrZeUgc0krvl90DiXwb5FpGKh3rMW/n1TiyEHmQ== X-Received: by 2002:a17:90a:8905:: with SMTP id u5mr4022456pjn.95.1629213945871; Tue, 17 Aug 2021 08:25:45 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id d14sm3107003pfl.90.2021.08.17.08.25.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Aug 2021 08:25:45 -0700 (PDT) Date: Tue, 17 Aug 2021 08:25:43 -0700 From: Stephen Hemminger To: Ferruh Yigit Cc: Aman Singh , Message-ID: <20210817082543.21ae2483@hermes.local> In-Reply-To: <8b0c151c-fc49-59f2-863c-233f419f4d40@intel.com> References: <20210816095728.17193-1-aman.deep.singh@intel.com> <20210816095728.17193-3-aman.deep.singh@intel.com> <20210816160347.0a35723a@hermes.local> <8b0c151c-fc49-59f2-863c-233f419f4d40@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v4 2/2] net: added macro to extract MAC address bytes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 17 Aug 2021 09:11:17 +0100 Ferruh Yigit wrote: > On 8/17/2021 12:03 AM, Stephen Hemminger wrote: > > On Mon, 16 Aug 2021 15:27:28 +0530 > > Aman Singh wrote: > > > >> Added macros to simplify print of MAC address. > >> The six bytes of a MAC address are extracted in > >> a macro here, to improve code readablity. > >> > >> Signed-off-by: Aman Singh > >> Reviewed-by: Ferruh Yigit > >> --- > >> The change in the document will be done in seperate patch. > >> To ensure document has direct reference of the code as shown in > >> commit 413c75c33c40 ("doc: show how to include code in guides"). > > > > NAK > > The DPDK already has rte_ether_format_addr() > > why does so much code not use it? > > > > 'rte_ether_format_addr()' formats string to a buffer, but most of the times the > need is just to log and having a buffer for it is unnecessary. > > Both macros look useful to me. Yes, but it would be good if same format was used everywhere.