From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F9BCA0548; Tue, 17 Aug 2021 11:02:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2A8FE40DF5; Tue, 17 Aug 2021 11:02:16 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 0FC6E4014E for ; Tue, 17 Aug 2021 11:02:14 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10078"; a="214177228" X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="214177228" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 02:02:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,328,1620716400"; d="scan'208";a="449192639" Received: from wuwenjun.sh.intel.com ([10.67.110.178]) by fmsmga007.fm.intel.com with ESMTP; 17 Aug 2021 02:02:12 -0700 From: Wenjun Wu To: dev@dpdk.org, jingjing.wu@intel.com, beilei.xing@intel.com Cc: Wenjun Wu Date: Tue, 17 Aug 2021 16:44:01 +0800 Message-Id: <20210817084401.183739-1-wenjun1.wu@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210817065307.160335-1-wenjun1.wu@intel.com> References: <20210817065307.160335-1-wenjun1.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 1/2] net/iavf: fix default RSS field for IP fragment packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Previously, hash value is calculated by src IP address, dst IP address and IP ID. However, default RSS field only needs src and dst IP address. This patch removes IP ID from default RSS field for IP fragment packets to improve default RSS configuration. Fixes: 9e29a278bc0c ("net/iavf: support default RSS for IP fragment") Signed-off-by: Wenjun Wu --- drivers/net/iavf/iavf_hash.c | 26 ++------------------------ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index 2b03dad858..eba55ecea5 100644 --- a/drivers/net/iavf/iavf_hash.c +++ b/drivers/net/iavf/iavf_hash.c @@ -624,34 +624,12 @@ iavf_rss_hash_set(struct iavf_adapter *ad, uint64_t rss_hf, bool add) } if (rss_hf & ETH_RSS_FRAG_IPV4) { - struct virtchnl_proto_hdrs hdr = { - .tunnel_level = TUNNEL_LEVEL_OUTER, - .count = 3, - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv4, - { - VIRTCHNL_PROTO_HDR_IPV4_FRAG, - FIELD_SELECTOR(VIRTCHNL_PROTO_HDR_IPV4_FRAG_PKID), - {BUFF_NOUSED}, - }, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv4_tmplt; iavf_add_del_rss_cfg(ad, &rss_cfg, add); } if (rss_hf & ETH_RSS_FRAG_IPV6) { - struct virtchnl_proto_hdrs hdr = { - .tunnel_level = TUNNEL_LEVEL_OUTER, - .count = 3, - .proto_hdr = { - proto_hdr_eth, - proto_hdr_ipv6, - proto_hdr_ipv6_frag, - }, - }; - rss_cfg.proto_hdrs = hdr; + rss_cfg.proto_hdrs = outer_ipv6_tmplt; iavf_add_del_rss_cfg(ad, &rss_cfg, add); } -- 2.25.1