From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B4E98A0548; Tue, 17 Aug 2021 15:47:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 734454128F; Tue, 17 Aug 2021 15:45:49 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2041.outbound.protection.outlook.com [40.107.94.41]) by mails.dpdk.org (Postfix) with ESMTP id A2FF54127F for ; Tue, 17 Aug 2021 15:45:47 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=feBQ122Zkd9NRz8d+JkwflPH69odHla6wYW4QkpEEgfsdBxBMvPIQsOSpdWdKZqFOls57kvr8zllRdBkN0GFQOt4s65ILLjQRWA7DDvUHOKx7s37Y2/a8Ih7pvf7m6qqqsVR730SDXX1vCPQPWDkq5SWJSazVtvEM2s/eesrMt3J83OV6IA37U3Ls/FQOa07aMmJlAUNPEeUo3bjyEbnRxFTSYmpHydLzWEr4dWUlsGS89uU1ZjMNPRHpbtspw6lBqrDbEBJTLIedhXDcQ0s2cnIzuQZG6IqQz+ka9CU+p5IPrqExS6KcxZ7nHir4nOqzTMzJvVgWXN2lh2MJyXn/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sJN2hoRADqWSQdIxVABqPFrthujMNibU2GBbDDmXAsE=; b=aCsGPqbq89sIbikiihywO34sYITGlisYNCm/5WvAR9mNJaSC2oGmldVxMKGkE55zJfVOtIsa92Gj6lhs/X9iD0uMlKl4ZnqK+42Co+eiZYHnZuwh3CC4JNPHw0fVL0Nk0wCvAZgcgLfA9OJPu6hqvynST32rMhSxVsCDzUCE+NV1UJeiNPayT77YOtPotut2MLOdRIXILPF30RuuIyqvRfFXcyPUhF1un41fj3dtMNHFSkfLrMvS9a3tlZTGH1JOuYxABDzn7HiaO3qzTNvkTo0tH38t8nKHgyWDYrgb5uNoJ+IK/+FhcQwCGkIuNtlAHoRjlQSQajvpgy2SoAKN5A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sJN2hoRADqWSQdIxVABqPFrthujMNibU2GBbDDmXAsE=; b=TTkJ8e7RO0F9yuJrKd9yC3IVCsLHQcn68nBMOmm+4BgnX01IMV21TPBVNgPwCA1Cqk9dapGhPGN4dwekpGul4s5u3+eK2b18MPTwvTxLLN1MKfeHaU5JoCzZbAoz9Wk+lhqRXc8K0U4j8lq1V443+XYfyQfE6mjHtUw885l99k6GVDG4tW1U/vyIebUwI74x5CDtie1C5opOXpQ86LsBoy6VqlVjz9j/kbhT31VDZvSIl96o1/GgAVZKSsjR+vrGP0k20nt+SHRt14Af5VXO+6Pa04i6wmjpr4HRt67ut6BvRcVKH+VZXgk7d6c4+sgGDOelgpzheJpvO1vI/GHJLg== Received: from MWHPR19CA0012.namprd19.prod.outlook.com (2603:10b6:300:d4::22) by BN6PR12MB1268.namprd12.prod.outlook.com (2603:10b6:404:1a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.21; Tue, 17 Aug 2021 13:45:46 +0000 Received: from CO1NAM11FT033.eop-nam11.prod.protection.outlook.com (2603:10b6:300:d4:cafe::e9) by MWHPR19CA0012.outlook.office365.com (2603:10b6:300:d4::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.18 via Frontend Transport; Tue, 17 Aug 2021 13:45:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by CO1NAM11FT033.mail.protection.outlook.com (10.13.174.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4415.14 via Frontend Transport; Tue, 17 Aug 2021 13:45:45 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 13:45:42 +0000 Received: from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 17 Aug 2021 13:45:40 +0000 From: Michael Baum To: CC: Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko Date: Tue, 17 Aug 2021 16:44:37 +0300 Message-ID: <20210817134441.1966618-18-michaelba@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210817134441.1966618-1-michaelba@nvidia.com> References: <20210817134441.1966618-1-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3c4e1b45-7a22-4b68-d891-08d96185506c X-MS-TrafficTypeDiagnostic: BN6PR12MB1268: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8273; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: o6Y7y4QeYunhzU+5MxYHWX9xj27dnSyYO50jokSdNVHaStdJwHhn+3RyOFxD8l4YwBm4b59clD46vya2GNznqOmz8H/etyaG+2JwPAwu8XajdjmeqsKNhLf4zYIjAfAtN02Gv1xbTLn4duWalmKygRLulSDGy82WJGWL2mwz8f3JrVMtxJ/nv0K+aF0LDVkn6a5YxYX4dGXzJlKsMXJubddUlSKDTa2Mrhd3H7u+xLLB6Nx27ft0nXA2VdqB7VMUTC9vhAa2MrNDP9uScKdWuiltcLPkw98hzCB5o97fW/pGTWceWv83vJoU7DUUs9PUttTegyawHWPF8uNdMCg2UQK9J7HdcX7rQMasPAMupHMDDM7e8nNperIKt/cxLw0mrto0uBfTQ67CPR8Bg2IdgREenXWuxXERe0aCWXSCbcggTIQDIb/WZBRrqTy7s1H8I3lzBQ6Tr0KyQsMdIcephxJQpW7Yl/3WGtbk48fzw8szwsx1EleqINjO89vcxHWVVKw/mT8hfC6xOqDED2rQg/f0Sr76ro+yzHkwtjaWB9X8j1DT80zchosdcAq5JKBjzjmzGLKSHl5C5dy3hMFrbkNp7ce0ldkiJRyZdRuiKLpC8Hv3AY65F06XaW24+PdqQ3oIO07EflNGx8nW+D2yyjCGwK52oEmfl5uXNAnC6HHpP1Yv2rLARoCoD0ef4g4ANM1j5kN6yHY3h0zTt8sSfA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(136003)(376002)(39860400002)(346002)(396003)(46966006)(36840700001)(1076003)(82740400003)(16526019)(36860700001)(26005)(478600001)(5660300002)(7696005)(55016002)(36756003)(47076005)(2906002)(70586007)(70206006)(186003)(83380400001)(54906003)(4326008)(316002)(8676002)(336012)(6286002)(86362001)(107886003)(6916009)(82310400003)(6666004)(356005)(7636003)(2616005)(426003)(8936002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Aug 2021 13:45:45.5872 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3c4e1b45-7a22-4b68-d891-08d96185506c X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT033.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1268 Subject: [dpdk-dev] [RFC 17/21] regex/mlx5: use HCA attributes from context device X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Use HCA attributes from context device structure, instead of query it for itself. Signed-off-by: Michael Baum --- drivers/regex/mlx5/mlx5_regex.c | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/drivers/regex/mlx5/mlx5_regex.c b/drivers/regex/mlx5/mlx5_regex.c index 3772007d24..ed3cd8972e 100644 --- a/drivers/regex/mlx5/mlx5_regex.c +++ b/drivers/regex/mlx5/mlx5_regex.c @@ -126,24 +126,12 @@ mlx5_regex_dev_probe(struct mlx5_common_device *mlx5_dev) { struct mlx5_regex_priv *priv = NULL; struct mlx5_dev_ctx *dev_ctx = &mlx5_dev->ctx; - struct mlx5_hca_attr attr; char name[RTE_REGEXDEV_NAME_MAX_LEN]; const char *ibdev_name = mlx5_os_get_ctx_device_name(dev_ctx->ctx); int ret; uint32_t val; DRV_LOG(INFO, "Probe device \"%s\".", ibdev_name); - ret = mlx5_devx_cmd_query_hca_attr(dev_ctx->ctx, &attr); - if (ret) { - DRV_LOG(ERR, "Unable to read HCA capabilities."); - rte_errno = ENOTSUP; - return -rte_errno; - } else if (!attr.regex || attr.regexp_num_of_engines == 0) { - DRV_LOG(ERR, "Not enough capabilities to support RegEx, maybe " - "old FW/OFED version?"); - rte_errno = ENOTSUP; - return -rte_errno; - } if (mlx5_regex_engines_status(dev_ctx->ctx, 2)) { DRV_LOG(ERR, "RegEx engine error."); rte_errno = ENOMEM; @@ -156,7 +144,7 @@ mlx5_regex_dev_probe(struct mlx5_common_device *mlx5_dev) rte_errno = ENOMEM; return -rte_errno; } - priv->sq_ts_format = attr.sq_ts_format; + priv->sq_ts_format = dev_ctx->hca_attr.sq_ts_format; priv->dev_ctx = dev_ctx; priv->nb_engines = 2; /* attr.regexp_num_of_engines */ ret = mlx5_devx_regex_register_read(priv->dev_ctx->ctx, 0, @@ -190,8 +178,8 @@ mlx5_regex_dev_probe(struct mlx5_common_device *mlx5_dev) priv->regexdev->dev_ops = &mlx5_regexdev_ops; priv->regexdev->enqueue = mlx5_regexdev_enqueue; #ifdef HAVE_MLX5_UMR_IMKEY - if (!attr.umr_indirect_mkey_disabled && - !attr.umr_modify_entity_size_disabled) + if (!dev_ctx->hca_attr.umr_indirect_mkey_disabled && + !dev_ctx->hca_attr.umr_modify_entity_size_disabled) priv->has_umr = 1; if (priv->has_umr) priv->regexdev->enqueue = mlx5_regexdev_enqueue_gga; -- 2.25.1