From: Joyce Kong <joyce.kong@arm.com>
To: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com,
honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com
Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org
Subject: [dpdk-dev] [PATCH] test/service_cores: fix wrong comment
Date: Thu, 19 Aug 2021 01:11:25 -0500 [thread overview]
Message-ID: <20210819061125.19929-1-joyce.kong@arm.com> (raw)
Change the inaccurate comment of 'set pass flag'
to 'clear pass flag' as the '*pass_test = 0' code
actually implements clearing.
Fixes: f038a81e1c56 ("service: add unit tests")
Cc: stable@dpdk.org
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test/test_service_cores.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c
index ece104054e..8659a1526c 100644
--- a/app/test/test_service_cores.c
+++ b/app/test/test_service_cores.c
@@ -68,7 +68,7 @@ static int32_t dummy_mt_unsafe_cb(void *args)
rte_delay_ms(250);
__atomic_store_n(lock, 0, __ATOMIC_RELAXED);
} else {
- /* 2nd thread will fail to take lock, so set pass flag */
+ /* 2nd thread will fail to take lock, so clear pass flag */
*pass_test = 0;
}
--
2.17.1
next reply other threads:[~2021-08-19 6:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 6:11 Joyce Kong [this message]
2021-08-19 8:13 ` Van Haaren, Harry
2021-10-12 18:48 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819061125.19929-1-joyce.kong@arm.com \
--to=joyce.kong@arm.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).