From: Joyce Kong <joyce.kong@arm.com>
To: Nicolas Chautru <nicolas.chautru@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,
honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com, nd@arm.com
Subject: [dpdk-dev] [PATCH v1 1/8] examples/bbdev_app: use compiler atomics for flag sync
Date: Thu, 19 Aug 2021 02:09:01 -0500 [thread overview]
Message-ID: <20210819070908.25773-2-joyce.kong@arm.com> (raw)
In-Reply-To: <20210819070908.25773-1-joyce.kong@arm.com>
Convert rte_atomic usages to compiler atomic built-ins
for global_exit_flag sync.
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
examples/bbdev_app/main.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c
index 5251db0b16..75c620ea75 100644
--- a/examples/bbdev_app/main.c
+++ b/examples/bbdev_app/main.c
@@ -18,7 +18,6 @@
#include <getopt.h>
#include <signal.h>
-#include <rte_atomic.h>
#include <rte_common.h>
#include <rte_eal.h>
#include <rte_cycles.h>
@@ -167,7 +166,7 @@ static const struct app_config_params def_app_config = {
.num_dec_cores = 1,
};
-static rte_atomic16_t global_exit_flag;
+static uint16_t global_exit_flag;
/* display usage */
static inline void
@@ -279,7 +278,7 @@ static void
signal_handler(int signum)
{
printf("\nSignal %d received\n", signum);
- rte_atomic16_set(&global_exit_flag, 1);
+ __atomic_store_n(&global_exit_flag, 1, __ATOMIC_RELAXED);
}
static void
@@ -328,7 +327,7 @@ check_port_link_status(uint16_t port_id)
fflush(stdout);
for (count = 0; count <= MAX_CHECK_TIME &&
- !rte_atomic16_read(&global_exit_flag); count++) {
+ !__atomic_load_n(&global_exit_flag, __ATOMIC_RELAXED); count++) {
memset(&link, 0, sizeof(link));
link_get_err = rte_eth_link_get_nowait(port_id, &link);
@@ -682,7 +681,7 @@ stats_loop(void *arg)
{
struct stats_lcore_params *stats_lcore = arg;
- while (!rte_atomic16_read(&global_exit_flag)) {
+ while (!__atomic_load_n(&global_exit_flag, __ATOMIC_RELAXED)) {
print_stats(stats_lcore);
rte_delay_ms(500);
}
@@ -928,7 +927,7 @@ processing_loop(void *arg)
const bool run_decoder = (lcore_conf->core_type &
(1 << RTE_BBDEV_OP_TURBO_DEC));
- while (!rte_atomic16_read(&global_exit_flag)) {
+ while (!__atomic_load_n(&global_exit_flag, __ATOMIC_RELAXED)) {
if (run_encoder)
run_encoding(lcore_conf);
if (run_decoder)
@@ -1062,7 +1061,7 @@ main(int argc, char **argv)
.align = __alignof__(struct rte_mbuf *),
};
- rte_atomic16_init(&global_exit_flag);
+ __atomic_store_n(&global_exit_flag, 0, __ATOMIC_RELAXED);
sigret = signal(SIGTERM, signal_handler);
if (sigret == SIG_ERR)
--
2.17.1
next prev parent reply other threads:[~2021-08-19 7:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 7:09 [dpdk-dev] [PATCH v1 0/8] use compiler atomic builtins for examples Joyce Kong
2021-08-19 7:09 ` Joyce Kong [this message]
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 2/8] examples/multi_process: use compiler atomics for sync Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 3/8] examples/kni: use compiler atomics for status sync Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 4/8] examples/performance-thread: use compiler atomics for sync Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 5/8] examples/l2fwd-jobstats: use compiler atomics for stats sync Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 6/8] examples/vm_power_manager: use compiler atomics for sync Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 7/8] examples/server_node_efd: " Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 8/8] examples: remove unnecessary include of atomic Joyce Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819070908.25773-2-joyce.kong@arm.com \
--to=joyce.kong@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=nicolas.chautru@intel.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).