From: Joyce Kong <joyce.kong@arm.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,
honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com, nd@arm.com
Subject: [dpdk-dev] [PATCH v1 3/8] examples/kni: use compiler atomics for status sync
Date: Thu, 19 Aug 2021 02:09:03 -0500 [thread overview]
Message-ID: <20210819070908.25773-4-joyce.kong@arm.com> (raw)
In-Reply-To: <20210819070908.25773-1-joyce.kong@arm.com>
Convert rte_atomic usages to compiler atomic builit-ins
for kni_stop and kni_pause sync.
Signed-off-by: Joyce Kong <joyce.kong@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
examples/kni/main.c | 27 +++++++++++++--------------
1 file changed, 13 insertions(+), 14 deletions(-)
diff --git a/examples/kni/main.c b/examples/kni/main.c
index beabb3c848..ad1f569e18 100644
--- a/examples/kni/main.c
+++ b/examples/kni/main.c
@@ -27,7 +27,6 @@
#include <rte_eal.h>
#include <rte_per_lcore.h>
#include <rte_launch.h>
-#include <rte_atomic.h>
#include <rte_lcore.h>
#include <rte_branch_prediction.h>
#include <rte_interrupts.h>
@@ -131,8 +130,8 @@ static int kni_change_mtu(uint16_t port_id, unsigned int new_mtu);
static int kni_config_network_interface(uint16_t port_id, uint8_t if_up);
static int kni_config_mac_address(uint16_t port_id, uint8_t mac_addr[]);
-static rte_atomic32_t kni_stop = RTE_ATOMIC32_INIT(0);
-static rte_atomic32_t kni_pause = RTE_ATOMIC32_INIT(0);
+static uint32_t kni_stop;
+static uint32_t kni_pause;
/* Print out statistics on packets handled */
static void
@@ -185,7 +184,7 @@ signal_handler(int signum)
if (signum == SIGRTMIN || signum == SIGINT || signum == SIGTERM) {
printf("\nSIGRTMIN/SIGINT/SIGTERM received. "
"KNI processing stopping.\n");
- rte_atomic32_inc(&kni_stop);
+ __atomic_fetch_add(&kni_stop, 1, __ATOMIC_RELAXED);
return;
}
}
@@ -311,8 +310,8 @@ main_loop(__rte_unused void *arg)
kni_port_params_array[i]->lcore_rx,
kni_port_params_array[i]->port_id);
while (1) {
- f_stop = rte_atomic32_read(&kni_stop);
- f_pause = rte_atomic32_read(&kni_pause);
+ f_stop = __atomic_load_n(&kni_stop, __ATOMIC_RELAXED);
+ f_pause = __atomic_load_n(&kni_pause, __ATOMIC_RELAXED);
if (f_stop)
break;
if (f_pause)
@@ -324,8 +323,8 @@ main_loop(__rte_unused void *arg)
kni_port_params_array[i]->lcore_tx,
kni_port_params_array[i]->port_id);
while (1) {
- f_stop = rte_atomic32_read(&kni_stop);
- f_pause = rte_atomic32_read(&kni_pause);
+ f_stop = __atomic_load_n(&kni_stop, __ATOMIC_RELAXED);
+ f_pause = __atomic_load_n(&kni_pause, __ATOMIC_RELAXED);
if (f_stop)
break;
if (f_pause)
@@ -856,9 +855,9 @@ kni_change_mtu(uint16_t port_id, unsigned int new_mtu)
{
int ret;
- rte_atomic32_inc(&kni_pause);
+ __atomic_fetch_add(&kni_pause, 1, __ATOMIC_RELAXED);
ret = kni_change_mtu_(port_id, new_mtu);
- rte_atomic32_dec(&kni_pause);
+ __atomic_fetch_sub(&kni_pause, 1, __ATOMIC_RELAXED);
return ret;
}
@@ -877,14 +876,14 @@ kni_config_network_interface(uint16_t port_id, uint8_t if_up)
RTE_LOG(INFO, APP, "Configure network interface of %d %s\n",
port_id, if_up ? "up" : "down");
- rte_atomic32_inc(&kni_pause);
+ __atomic_fetch_add(&kni_pause, 1, __ATOMIC_RELAXED);
if (if_up != 0) { /* Configure network interface up */
ret = rte_eth_dev_stop(port_id);
if (ret != 0) {
RTE_LOG(ERR, APP, "Failed to stop port %d: %s\n",
port_id, rte_strerror(-ret));
- rte_atomic32_dec(&kni_pause);
+ __atomic_fetch_sub(&kni_pause, 1, __ATOMIC_RELAXED);
return ret;
}
ret = rte_eth_dev_start(port_id);
@@ -893,12 +892,12 @@ kni_config_network_interface(uint16_t port_id, uint8_t if_up)
if (ret != 0) {
RTE_LOG(ERR, APP, "Failed to stop port %d: %s\n",
port_id, rte_strerror(-ret));
- rte_atomic32_dec(&kni_pause);
+ __atomic_fetch_sub(&kni_pause, 1, __ATOMIC_RELAXED);
return ret;
}
}
- rte_atomic32_dec(&kni_pause);
+ __atomic_fetch_sub(&kni_pause, 1, __ATOMIC_RELAXED);
if (ret < 0)
RTE_LOG(ERR, APP, "Failed to start port %d\n", port_id);
--
2.17.1
next prev parent reply other threads:[~2021-08-19 7:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 7:09 [dpdk-dev] [PATCH v1 0/8] use compiler atomic builtins for examples Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 1/8] examples/bbdev_app: use compiler atomics for flag sync Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 2/8] examples/multi_process: use compiler atomics for sync Joyce Kong
2021-08-19 7:09 ` Joyce Kong [this message]
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 4/8] examples/performance-thread: " Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 5/8] examples/l2fwd-jobstats: use compiler atomics for stats sync Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 6/8] examples/vm_power_manager: use compiler atomics for sync Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 7/8] examples/server_node_efd: " Joyce Kong
2021-08-19 7:09 ` [dpdk-dev] [PATCH v1 8/8] examples: remove unnecessary include of atomic Joyce Kong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819070908.25773-4-joyce.kong@arm.com \
--to=joyce.kong@arm.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).