From: Yu Wenjun <yuwenjun0x@163.com>
To: qiming.yang@intel.com, qi.z.zhang@intel.com
Cc: dev@dpdk.org, stable@dpdk.org, Yu Wenjun <yuwenjun0x@163.com>
Subject: [dpdk-dev] [PATCH] net/ice: fix deadlock in ice_flow_query()
Date: Thu, 19 Aug 2021 20:10:02 +0800 [thread overview]
Message-ID: <20210819121002.1433-1-yuwenjun0x@163.com> (raw)
It will cause deadlock when use switch-default, so fix it
Signed-off-by: Yu Wenjun<yuwenjun0x@163.com>
---
drivers/net/ice/ice_generic_flow.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ice/ice_generic_flow.c b/drivers/net/ice/ice_generic_flow.c
index 66b5743abf..c2fa75f165 100644
--- a/drivers/net/ice/ice_generic_flow.c
+++ b/drivers/net/ice/ice_generic_flow.c
@@ -2518,15 +2518,16 @@ ice_flow_query(struct rte_eth_dev *dev,
ret = flow->engine->query_count(ad, flow, count, error);
break;
default:
- return rte_flow_error_set(error, ENOTSUP,
+ ret = rte_flow_error_set(error, ENOTSUP,
RTE_FLOW_ERROR_TYPE_ACTION,
actions,
"action not supported");
+ goto out;
}
}
+out:
rte_spinlock_unlock(&pf->flow_ops_lock);
-
return ret;
}
--
2.32.0.windows.1
next reply other threads:[~2021-08-19 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 12:10 Yu Wenjun [this message]
2021-08-29 13:06 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819121002.1433-1-yuwenjun0x@163.com \
--to=yuwenjun0x@163.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).