From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C7E7A0C46; Tue, 24 Aug 2021 09:14:49 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB56840687; Tue, 24 Aug 2021 09:14:48 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id C8F064014E; Tue, 24 Aug 2021 09:14:47 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10085"; a="204449056" X-IronPort-AV: E=Sophos;i="5.84,346,1620716400"; d="scan'208";a="204449056" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2021 00:14:45 -0700 X-IronPort-AV: E=Sophos;i="5.84,346,1620716400"; d="scan'208";a="535677848" Received: from dpdk.cd.intel.com ([10.240.178.133]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2021 00:14:43 -0700 From: Jie Wang To: dev@dpdk.org Cc: qi.z.zhang@intel.com, Jie Wang , stable@dpdk.org Date: Tue, 24 Aug 2021 15:13:17 +0000 Message-Id: <20210824151317.129271-1-jie1x.wang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210820135458.317056-1-jie1x.wang@intel.com> References: <20210820135458.317056-1-jie1x.wang@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2] net/ice: fix queue config in DCF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" When DCF configures rx_queues, it may cause the pointer of rx_queues to go out of bounds. This patch expands the scope of the judgment condition to fix this issue. Fixes: 4b0d391f0eab ("net/ice: add queue config in DCF") Cc: stable@dpdk.org Signed-off-by: Jie Wang --- v2: assign values to rxq.vsi_id and rxq.queue_id, ensure rxq.vsi_id is equal to txq.vsi_id and rxq.queue_id is equal to txq.queue_id. --- drivers/net/ice/ice_dcf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_dcf.c b/drivers/net/ice/ice_dcf.c index 4c2e0c7216..a68b355cb8 100644 --- a/drivers/net/ice/ice_dcf.c +++ b/drivers/net/ice/ice_dcf.c @@ -882,11 +882,11 @@ ice_dcf_configure_queues(struct ice_dcf_hw *hw) } vc_qp->rxq.vsi_id = hw->vsi_res->vsi_id; vc_qp->rxq.queue_id = i; - vc_qp->rxq.max_pkt_size = rxq[i]->max_pkt_len; if (i >= hw->eth_dev->data->nb_rx_queues) continue; + vc_qp->rxq.max_pkt_size = rxq[i]->max_pkt_len; vc_qp->rxq.ring_len = rxq[i]->nb_rx_desc; vc_qp->rxq.dma_ring_addr = rxq[i]->rx_ring_dma; vc_qp->rxq.databuffer_size = rxq[i]->rx_buf_len; -- 2.25.1