From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A8E5A0548; Thu, 26 Aug 2021 20:06:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 085DB41225; Thu, 26 Aug 2021 20:06:21 +0200 (CEST) Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by mails.dpdk.org (Postfix) with ESMTP id DBD9040140 for ; Thu, 26 Aug 2021 20:06:19 +0200 (CEST) Received: by mail-pg1-f180.google.com with SMTP id r2so3707588pgl.10 for ; Thu, 26 Aug 2021 11:06:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=ZPb+cdxHypaR+5w5DloqO4YMiq7vK53PjW1vNI146b8=; b=HDB8GVipuw9ySnl5kFyiQ8PR8KVbeqKPgmyJfvluDhPJhBQBdskPG8/OKfK+ZI5sEe RJRLGDXMk/Acw2uMKt/dF3E4lxpX3Zb4ttFBdn+bi7X+/Tpqp2t8EZNAf1RPsO31axhl jCaSqbyifQLXmXawZyZ947heunpZKF+IIWmlv8ZcVAbqjYFTvMj3aw+LlsHk8YqeLGEk mSvGnpplBV/dioE5bQ5q81+s+9WahVV01pkAu7fKcusYFZeoJMt+/pGdE5UKXP9V8LRJ +hl4jrYZSYzKFmGC2lBpVCWjadZG5sZyaTpXLPSUiUP5ZZvZjgGqZ2svv46e5ZHqUMjN UtAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=ZPb+cdxHypaR+5w5DloqO4YMiq7vK53PjW1vNI146b8=; b=oIW8qcgd1dtP9dNZLQJXNOcxMROcJ4QqDPoUmKtF3iopfUuua0py+qLdAHWqvyRktB +RLXhIgYKuZHh2F4RxKTbNjU9INQe0B+XuyXPBtwM3Y+WhUKAXXQKk5obDdI1Yl2d1Cy 1GnEx5Vm4qTtzzv3Al37polNaY41d0eOOdu7gueRhSf/VIQrivF8MssmcWjh/ZvFhQP3 FDcmkA9EBti49R16PQ/xu3zO8cCuX18RgGZJrnxVvQfyvGxE2BQw9WR1BK+jMDbbkx0O bgSdNosr1a0hujcJYOo6Vqa6fFTW5fwcAZ+sR6JJwh/4lu1Qtf1aNRLkMMCd3sokKawJ YA6w== X-Gm-Message-State: AOAM530ITWUpLMMvU4eEiNrpg74u/nh3QcNNag1tKj7jPVh4kV+TCoJj WjnTIMSUBlbplhpRU8pYZHkFTg== X-Google-Smtp-Source: ABdhPJznvG29tb1d3SJPSHkhU0waaEF1MeRuunsU8vlVjbv9fcHsR128V2kxVMLd+25VoIO7ngmCjw== X-Received: by 2002:a63:f346:: with SMTP id t6mr4344146pgj.345.1630001178879; Thu, 26 Aug 2021 11:06:18 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id e3sm3601618pfi.189.2021.08.26.11.06.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Aug 2021 11:06:18 -0700 (PDT) Date: Thu, 26 Aug 2021 11:06:15 -0700 From: Stephen Hemminger To: Igor Ryzhov Cc: dev , Ferruh Yigit , Dan Gora Message-ID: <20210826110615.00b84400@hermes.local> In-Reply-To: References: <20210704160610.62682-1-iryzhov@nfware.com> <20210826151911.15699-1-iryzhov@nfware.com> <20210826101535.7b9c08c1@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v5 1/3] kni: rework rte_kni_update_link using ioctl X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 26 Aug 2021 20:46:47 +0300 Igor Ryzhov wrote: > Could you please clarify where exactly do I need to use rtnl lock? > From what I understand, netif_carrier_on/off can be called without the lock. Just a basic concern. The new stuff looks ok. If you follow what current upstream virtio is doing, it should be safe. See drivers/net/virtio/virtio_net.c, looks like more is needed? Do you call ethtool_validate_speed() and ethtool_validate_duplex()? Also, in virtio the driver does stop/wakeup of tx queues on carrier change.