From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 654A1A0547; Thu, 26 Aug 2021 19:25:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9794941240; Thu, 26 Aug 2021 19:24:53 +0200 (CEST) Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-eopbgr1400111.outbound.protection.outlook.com [40.107.140.111]) by mails.dpdk.org (Postfix) with ESMTP id 8F95640140 for ; Thu, 26 Aug 2021 13:55:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RdPPFwCnbUZaEJtNPg8TciCJPXAESzwjB5oRp8tUa8gk2UBi4InlMIBLOPFTVoE/CRPs/FTo8zD8SGzECqAswDilBQwbmJHGB2CTX7lBtIy6zXC8QTXQc2Ow2OVhzZjcvJShvbxQ7cHr7xeOW0TGQJ/YCeENxeqaypvXSdiQ1iI45DAyunG0aVEyUfPc8is64cXVQMBtdG5PqqFeyLRIVtW2yIM8ENKRNVqOp0FzCmGoTSERosDyjYBn9UzoJJQxgNOsYAEs1xYUtpeiBTfUiliFMPw16z3dtt52KzKceChaoahq1RnTCISA+zUXY77BGLgwNHP+3lvBZxOZ1yp+DQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nBl6OVW4nm9FcmMxWlbRGTNtz5QRyMVwweF2vqduBz8=; b=HYcDEaS/EzWT/exVvvLASv6dVQV/7sBozBFPkDP+ApmgD1nQ5XDclas+skBY03NsWYVdv4NdzvwSmxrQTsB4YUU8TMHnqawte2fYQt9EFT9cmEUZy/8e1qNRd+xOQNVf5Tg9emkFcstBJQzZCHRR6bEUzBfuFwWlyj01Pchfzz+T+n8gdrUgAujMuJSyuuCcGxh8vVQqNoMThUAikC3RcPIiABXBGzpXbmtCghdKxItssG8ggyvffBHJgeO8r/uHXBX92d12h5UlrxgW7Tbr+I5OgHuki2SBYqWGJ8wpYTkRfss5CzX+EowcDwjLMofbSxUc8BmDPXWmoda5ISaR7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=connect.ust.hk; dmarc=pass action=none header.from=connect.ust.hk; dkim=pass header.d=connect.ust.hk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connect.ust.hk; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=nBl6OVW4nm9FcmMxWlbRGTNtz5QRyMVwweF2vqduBz8=; b=2UDcpvbrbAEHF86GUW+KHYKDWB5CBjaAD/W8wz3UuWsZr41nCmI0GKr1yo0EXhfYqFA4Q5VaHhH04jSDcU4UzRqpKRfYaF4YcH62ohjF7lJHiyIVHkvTYW2NX1mmdRBd/KCbT94l0ZGWypb5txm6FIB+hY8G2syAlhsZUtNVIXQ= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=connect.ust.hk; Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) by TYCP286MB1332.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:bf::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.19; Thu, 26 Aug 2021 11:55:11 +0000 Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1]) by TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1%6]) with mapi id 15.20.4436.027; Thu, 26 Aug 2021 11:55:11 +0000 From: Chengfeng Ye To: asomalap@amd.com Cc: dev@dpdk.org, Chengfeng Ye Date: Thu, 26 Aug 2021 04:54:52 -0700 Message-Id: <20210826115452.89350-1-cyeaa@connect.ust.hk> X-Mailer: git-send-email 2.17.1 Content-Type: text/plain X-ClientProxiedBy: HK2P15301CA0021.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::31) To TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from ubuntu.localdomain (218.253.253.162) by HK2P15301CA0021.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.0 via Frontend Transport; Thu, 26 Aug 2021 11:55:11 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c5ad1969-6a4b-4332-87b4-08d968885bb1 X-MS-TrafficTypeDiagnostic: TYCP286MB1332: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hC+Ll128fPLiZ4vXg8dx5zlX5Iy3luLXLVrxk2iYp+PRSBYxuwjFU3LRBwkWpyqKa9ymkcCB15W451VtN8vFdwLiLh9L7auQcF05isfKtpDseECd0CkuLdEkXkHMwYkW407fBf2R5S5ciPFqSXa23idg/jNAGkd9Mc0/xl3HscJmsJd0Omv9jTyCw4TIi7MfzAi78Q1ImBEV5Q9RzjbyOQwZx38zWysR5Y/VifE4GLJgecYYRmZh5/wt24vakhwz/yaQnEbN6LfqDCU7gmByInrUXs7mS47zA5CzQk/bpylNiksf5QfArZqRZbsIIgeQ0lAaK5Pz++JsZSr6Aakf0gdj7t0WpvM2K9GzfYjBWW3Xsh7wruJVhWBL47rDFjcvpeU/kOW9yCMEGy5UykCkrn3SpFyhNvMfwPGF2+dWYF5yqtL+0Zq0UXxUjk7G+ybaNgu9mGgPwvLjm8dfVtkEgvkB3Uhd/DITUmu5ShY0IJqeUQWH07c+6IRTIhY73ojGuAFD5yucj1YjBS8QwSrjuzcAwAihRPjE/4eAxDWCr9mvbtqp5Vp2UClgtpaYVVPPzNwac2YPIpJ7Xss7AKQOIjVkL9eRGQT35psSrtS0DNAReiGblizmZDLSh/NhaRk3nPsS2PU5EUyoL3KdhBA9xpAIO1sgDn7Vy6GTQomdc4rokXGmqpE7WEj9ISBijeZd8tR2OMh1vzqaMnt5L+x0N2OqYzEZbYJWXAp6ZeO1B94= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(376002)(346002)(39830400003)(396003)(366004)(136003)(107886003)(786003)(52116002)(26005)(2906002)(1076003)(4326008)(478600001)(316002)(5660300002)(956004)(66476007)(186003)(6666004)(2616005)(8936002)(8676002)(66556008)(6506007)(38100700002)(38350700002)(83380400001)(6916009)(86362001)(36756003)(66946007)(6512007)(6486002)(70780200001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AmKXLv4g5tZKLdTIjv4CF2QNbY1kL1CGs2WhEAbal0ZTQUzyB7XBIM/HWJ3t?= =?us-ascii?Q?rquwe/CAFuHKuSfQCWGU5SZO9PD48/rWhlodaftqtAgTgH3uS7oCOEGkTkJ9?= =?us-ascii?Q?NejN2pop6zbs6HZsD50CTuTkaNF45OOGPzCaGNJad+igeVeXRBlU/IVk3OgM?= =?us-ascii?Q?WkZC+WgQnE7bMZLsXyx3ge1xEFErABokKnuLVP5SbOFE5/P0Pju8XSiSXcX7?= =?us-ascii?Q?VMSiKTIZq/IROhvm84HkEH8fcSBy58EoJLO8k31bP4gLjcJ6EpetaBXLISkX?= =?us-ascii?Q?6ufO5fFI3PBPavZ/X5VlR5y+PX4ynpq2ZJTWaDF9O5cayf2ZFLZPQJRdKfrp?= =?us-ascii?Q?z1Hp/B5sMYtPJhZlkjfB5aFkTb3hw8SO2a3L0qeOmyn7cH/HxH8LZtM72FNA?= =?us-ascii?Q?MIrsh1Qk5JeO+r30DoCNQ3U56IKJL19oefCqvx6X7wApdHX7+P6nA+ovAQ2w?= =?us-ascii?Q?+8tLk942dKWS8Qd5C2i1VKbnwLoYQFP9VXpOf4h38Q7VofYFbGS2ob4q8foa?= =?us-ascii?Q?pPgTxaZjMlVejQhFWXI4trDbw6tTjQmlDYrBK/U+w8tdRP5Lgzrq93lRwZCC?= =?us-ascii?Q?njcIuMJC3Y0vig4JHu0Jdb4oocCe6VKs6N8uD0tnezX/Pr6zXh3Bj+HKOjW+?= =?us-ascii?Q?1fkR1B1I+q3lecQGs4NJPmzQ/A4FLPgY4CR9g/3Q7qiDa67oV1Q0jCC11cBW?= =?us-ascii?Q?YHYGqM+7bnRRLHK/qaW2JnMNfhKP+TunHelND2IpnSTMJ4DIyK1tcUj4sakk?= =?us-ascii?Q?GvrEW5KNqCGjR+22sMBAaB4++qtOgbpppt/Fha0Un40lI48Nm222ugah+jfk?= =?us-ascii?Q?TqU/5EMJnWteoSmGA9J1RJe3qeGic20v5IcJe18GgTE0eL1fImZyH02GbxMO?= =?us-ascii?Q?G/pZ+bJnGcfUBgHN/yM88NNuOWXlxFKzwbSNtrVq/7Z2DetLxm8OdhVzzRBI?= =?us-ascii?Q?hPkfmGoxwEfnqZZak1rh0LAxVWgJgOIXESh+BVrkVBDswpJiOT8jjNS+s9Nd?= =?us-ascii?Q?KWuN9CTG5xy4iQ5Ey1iGf4W1lhuTAHiTha2PssFh+V5qnH+gO/Nwr7BZff5b?= =?us-ascii?Q?6xoh/WNelNnlPlXihQuNtZRR5+p+7iWy9YniiWNJj6sqFC6H2WygDFTwr5KX?= =?us-ascii?Q?hu/ld2oXFycHoyLRvrJElXYEAS+e5y93LKvOPvHW16sxZ2ux2eAjyMoOCX6E?= =?us-ascii?Q?ddaOssu9yoGbVnrBgzVg5fqMZ8JnmbVLeYKB1kVdeXPwZJYkSfr37YkiXlsX?= =?us-ascii?Q?TdvoM6T1HVJG25tkvYiTKJBM+vrGyXfjyc6YTFuDbwhCQubj60rSlfhVaFh+?= =?us-ascii?Q?e7Ppm2V19ZtQiGDpoHrm+gHF?= X-OriginatorOrg: connect.ust.hk X-MS-Exchange-CrossTenant-Network-Message-Id: c5ad1969-6a4b-4332-87b4-08d968885bb1 X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2021 11:55:11.5018 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 6c1d4152-39d0-44ca-88d9-b8d6ddca0708 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: AJUo+QnTnw4s9Qeoigg+prs9CKtWQB2gI+mbkyN4UX1ZbGY83ZNllE6kIvcK/lfCaPkeStrJYrrYkFSfUYhhNw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB1332 X-Mailman-Approved-At: Thu, 26 Aug 2021 19:24:49 +0200 Subject: [dpdk-dev] [PATCH] net/axgbe: fix protential unreleased lock problem in axgbe_i2c_xfer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The lock pdata->i2c_mutex is not released if the function return in these two patched branches, which may lead to deadlock problem if this lock is acuired again. The patch is to fix this problem. Cc: cyeaa@connect.ust.hk Bugzilla ID: 777 Signed-off-by: Chengfeng Ye --- drivers/net/axgbe/axgbe_i2c.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/axgbe/axgbe_i2c.c b/drivers/net/axgbe/axgbe_i2c.c index ab3738a12e..a2798f484e 100644 --- a/drivers/net/axgbe/axgbe_i2c.c +++ b/drivers/net/axgbe/axgbe_i2c.c @@ -233,6 +233,7 @@ static int axgbe_i2c_xfer(struct axgbe_port *pdata, struct axgbe_i2c_op *op) ret = axgbe_i2c_disable(pdata); if (ret) { PMD_DRV_LOG(ERR, "failed to disable i2c master\n"); + pthread_mutex_unlock(&pdata->i2c_mutex); return ret; } @@ -249,6 +250,7 @@ static int axgbe_i2c_xfer(struct axgbe_port *pdata, struct axgbe_i2c_op *op) ret = axgbe_i2c_enable(pdata); if (ret) { PMD_DRV_LOG(ERR, "failed to enable i2c master\n"); + pthread_mutex_unlock(&pdata->i2c_mutex); return ret; } -- 2.17.1