From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 547D6A0547; Thu, 26 Aug 2021 19:25:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDA3541247; Thu, 26 Aug 2021 19:24:54 +0200 (CEST) Received: from JPN01-OS2-obe.outbound.protection.outlook.com (unknown [40.107.141.112]) by mails.dpdk.org (Postfix) with ESMTP id 899FA40140 for ; Thu, 26 Aug 2021 14:24:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=R5LomZVsQqXLpqaU/+tBl4btYE9252b1KDkjs7CVUBTrEBBKMDcH0HzfwCxdCSjIcFN9K+jv79UUv0GwTRIO+sNA/97MKnXKEwU3KfyLZSpmk476xHuIUzgThlZ+FfKKajGr58LBNxuf/0U7VQHEWHX22PSOxfTavpEDY3Jjw+YBaZG7rqu5x/p+iqUk9ROas+eSAwJyv1Vg+skGbfERBlhjVrbkpz95Czx7Jie7kHh92b8WsoHPE6GHvyrp3n9zjhWZ8QOh5l7u106DTEyf7qJ/U6be3mw18rONqmlyyEOGfEvX1mLgSDRbMlb4f2thOiZnYIzsun8mjOVjN0SjNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EO+LC/PpKHVmBCd4hm09pgxWCNtvjAyundkV5GM0YKs=; b=j9Ck1/ChsAvUwUoCbHMhPHYAIZQirrdIDlU74r7VYOEj9FEwSMYIomlh16frl3UXa72wlkLTvcPwMGXPGNLS0waJC+rsW+pckBywbh78zQwqd0yPoJQVp6uSVpV44YcrAVEAIwycfa0La9fS9exFZ/Y+BH+NoqBlTsHR5HWCXcUtdIS9PSAwFWcU0ejBqFouvIjH6zREJ/QWocEmQTdCuoR4i/NjM3pKquIbxWkdICRPA4pmowsJP0NUXePk47Pw2CJAyaNrx/CTF1zr7zUOhz7b5NrnwsB3wqZs0eMktLrxVzJQWErDe7A9w25u8BwqptHhPA8SQy9cfLSJBCpDlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=connect.ust.hk; dmarc=pass action=none header.from=connect.ust.hk; dkim=pass header.d=connect.ust.hk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connect.ust.hk; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EO+LC/PpKHVmBCd4hm09pgxWCNtvjAyundkV5GM0YKs=; b=LkbNzWrJCMeulAaaDSHhvU8lG/6DybJAgXJg2/zw4enJyiyjJxmOaxHgdWGpWxrWvbP7Mgwu5taxsLFmxTt+WSBcFUxAUq9+SxVlfXD5gAYUDdW3VXFagQP7K91/SUx7q9IbnCeC6fPpGubnkjxLPTObbjO161HfAeMOIJCHoiU= Authentication-Results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=connect.ust.hk; Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) by TYBP286MB0270.JPNP286.PROD.OUTLOOK.COM (2603:1096:404:802b::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.19; Thu, 26 Aug 2021 12:24:17 +0000 Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1]) by TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1%6]) with mapi id 15.20.4436.027; Thu, 26 Aug 2021 12:24:17 +0000 From: Chengfeng Ye To: matan@nvidia.com, viacheslavo@nvidia.com, tzahio@nvidia.com Cc: dev@dpdk.org, Chengfeng Ye Date: Thu, 26 Aug 2021 05:24:05 -0700 Message-Id: <20210826122405.89830-1-cyeaa@connect.ust.hk> X-Mailer: git-send-email 2.17.1 Content-Type: text/plain X-ClientProxiedBy: HK2PR0302CA0010.apcprd03.prod.outlook.com (2603:1096:202::20) To TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from ubuntu.localdomain (218.253.253.162) by HK2PR0302CA0010.apcprd03.prod.outlook.com (2603:1096:202::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.10 via Frontend Transport; Thu, 26 Aug 2021 12:24:16 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c969bade-4fcf-4017-23bc-08d9688c6c73 X-MS-TrafficTypeDiagnostic: TYBP286MB0270: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2582; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: M5TS5O9Thh+6Bc1SRH1oKgjkFTQcLDTQmFub1UeaQ8Nov03S0gtPKXWvrEGuIr/gwpSuKO68b0AKVML2blZNiN1Z6CPkaoabf8SUgRKeSyLmBNNG4tfyfcphK1FQ+WqB+7SmZjyd6X0idz3/U12z8y2HNxiKExw/OstoTazWxxijZUBdYzTFwnHGDAG9Q2yECaRsMwQqzIgJlfyrqBeIVvCHttluoN/RWVWgjO5pL6fd/o/sX6i+1oLYENXDejhOtJpaAvQQY6nLsPbNWJ60mDPfZncPCRg+OGev3TOnd4AxXvSpZ/eiJ2SpcHcmDszAT0K+POD8wLeoyu7jHMn437xga6SXvTyTVni8u5biry424J6kN34o06Bj7aF4PFAu42bRdGRaoRFyC70jeAYIfRtCbMoD0BcbxZxepqW8Fn+iwdAdPU1jc2A66av4US/HJpCI6f3pM7yFnPrqJl6F2Mp06m+cQ9ZpjjwbLeWyo75fkFnOdW3AdmIEoYrJnNMwL/igOKNFnv0Vk5ExL0uCMZEv+bTCSRrq08vuefJ2NWE40x15QKkS7jySU95oadTQViTveIjb1Ch7/e43NzvGn/yiTYMoyScUmGpgxYmm2eE4j39rTQrE/q20YW5eKgmqyeb1hcbZMG6Alj4ExvrN3So71JHWfYgIcjgvXqGvps4zgfny3EXvMj4mSgg9NAT6o1uLzo0vlLAEL38Esx1YCA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(366004)(376002)(39840400004)(2906002)(6512007)(956004)(6506007)(8676002)(8936002)(2616005)(186003)(52116002)(66946007)(26005)(83380400001)(6666004)(4326008)(316002)(786003)(478600001)(38100700002)(38350700002)(4744005)(5660300002)(1076003)(66556008)(66476007)(107886003)(36756003)(86362001)(6486002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oLIIAnQOP0c4O3ZIBliBOuifOoaax5YTF3Az7unD+TVd++v2aErr+O5Xg7lR?= =?us-ascii?Q?7MUFc7UwQfMsccGvOn7jqcvBFESqyKKIDSw6603lqUPjHkYerFG9iJkuQwkM?= =?us-ascii?Q?xQmEYbLpVYwyMiWT70UGlSdiCWQ0GHuVGe9EHySwAAM4SIfHz4Qg9tNBvwgm?= =?us-ascii?Q?/DLfAWfLmc5cqq6snnpVOFGgC+1wJXWqZDD6HOKbf8iN+4lKUs5ap6eYcdS0?= =?us-ascii?Q?N5FCP7AAUJAtVKjxnUmDgZxZZ9gvHrw9dz/NCS3IxCTNf5Rrf9iVyM8vAmC6?= =?us-ascii?Q?AVkOiC5Qo/1kl/DecIVeULRXGQzwJk1n8nnhSlIurq/nHCha7loZcHaBImqm?= =?us-ascii?Q?5rTQL5xqpfjUCNsISlpz0iaHJZdeBfMFSS2ryEjRCrudBX+JWP47z28wAOnB?= =?us-ascii?Q?j1pSuPeufXPNBFYTYl42XNj2WsflM4PO62Z4R7xwlFdrsj83DnKguFTD0Lc9?= =?us-ascii?Q?AxPquXD1qTeXC3+2IFZqGdWx7O4ghEkDVNmv1gz7pq7LNhi9VCmfgV2BYl6n?= =?us-ascii?Q?1p28GwlKpzqgsvPg0RW9BtWT1gZWLEravwv129u9GmRDN56wcjqTgQyp7lTQ?= =?us-ascii?Q?PKxYWZ242rkofW5NSKChIttFd4hyJ0/giQmDLuUj/COKWtkJiqZu1WFaAy7P?= =?us-ascii?Q?LKaz2EEj4Pf3MUgVNGoGrM7z841WFgqaF8UH0dCf3V674j5NKlc6QDfvC3qq?= =?us-ascii?Q?FAOLRscTXMpLtgC8oBZ6esPMxn9ax9pVmeFCi9FrGZfNdttmKqBj0comBNe9?= =?us-ascii?Q?V4ewNDcq/cxWOi46UfJj9qiZyc6R+GEeE+slkLZ8phGV/9PNA8GuOm5Zc9R+?= =?us-ascii?Q?h6PrAdHnYBQnY98550Z5jqrAc4rXHn8lFDinYGBmiOVCru5y9tn7NrSwkAH2?= =?us-ascii?Q?ZgX3IY0+BnnqqDa5eTHyeUoJWJTwAQT0Dwrp7RfMUC57E6HspvKlHw9vwz4w?= =?us-ascii?Q?LOWawirAh/k9kzHNxAGIp04+YICIXTvEDZ283ktiUM4zKAEHQWlgAKERQDAq?= =?us-ascii?Q?wucQhrKayi0vgimikSKv95+CUsRkl9Vl/yZarZWYJvn9nkHg/k1G1S4Nk89D?= =?us-ascii?Q?pHRuZZi2G+rpY4QrnkyaFNVXeF/eA7VwrWcE1qRW5Zz8vRX1sAq2sQlq8jbK?= =?us-ascii?Q?tnMItFiJfWrru7ITxWFtjTU1HZ+x6Uw5q64Fg3ML/fNbrPllg+b+wG0o2pps?= =?us-ascii?Q?fKzcFR/Br2n8h2DD/HEW2W+9rwcNDHziKlAvz1GJYaeGGYB3X0OYnwORIPd5?= =?us-ascii?Q?z3QIVMnSLFwfMhZGKlPagb7s/G655EerWjJXFYsAwbXgpwu2PB99tnhaJzZs?= =?us-ascii?Q?U822KQAyjDVbt+9mv3VSXLB5?= X-OriginatorOrg: connect.ust.hk X-MS-Exchange-CrossTenant-Network-Message-Id: c969bade-4fcf-4017-23bc-08d9688c6c73 X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2021 12:24:17.5732 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 6c1d4152-39d0-44ca-88d9-b8d6ddca0708 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LkzpjOl3x5lYDLbPINMLSf6KV+x5IG7C3pHDfa6e1TKa0ERZcVH7OMDP7k7m7+xv26YuH1F7Dh2cUYsDDkQczQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYBP286MB0270 X-Mailman-Approved-At: Thu, 26 Aug 2021 19:24:49 +0200 Subject: [dpdk-dev] [PATCH] net/mlx5: fix protential unreleased lock problem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The lock sh->txpp.mutex isn't correctly released if the function return in the patched branch, which may lead to deadlock if this lock is acuired again. The patch is to fix this problem. Cc: cyeaa@connect.ust.hk Bugzilla ID: 774 Signed-off-by: Chengfeng Ye --- drivers/net/mlx5/mlx5_txpp.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_txpp.c b/drivers/net/mlx5/mlx5_txpp.c index 4f6da9f2d1..0ece788a84 100644 --- a/drivers/net/mlx5/mlx5_txpp.c +++ b/drivers/net/mlx5/mlx5_txpp.c @@ -961,8 +961,12 @@ mlx5_txpp_stop(struct rte_eth_dev *dev) MLX5_ASSERT(!ret); RTE_SET_USED(ret); MLX5_ASSERT(sh->txpp.refcnt); - if (!sh->txpp.refcnt || --sh->txpp.refcnt) + if (!sh->txpp.refcnt || --sh->txpp.refcnt) { + ret = pthread_mutex_unlock(&sh->txpp.mutex); + MLX5_ASSERT(!ret); + RTE_SET_USED(ret); return; + } /* No references any more, do actual destroy. */ mlx5_txpp_destroy(sh); ret = pthread_mutex_unlock(&sh->txpp.mutex); -- 2.17.1