From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13C3CA0C54; Fri, 27 Aug 2021 03:22:58 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EE5041247; Fri, 27 Aug 2021 03:22:51 +0200 (CEST) Received: from JPN01-TY1-obe.outbound.protection.outlook.com (mail-eopbgr1400102.outbound.protection.outlook.com [40.107.140.102]) by mails.dpdk.org (Postfix) with ESMTP id AC6FC40140 for ; Thu, 26 Aug 2021 20:56:16 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Aux4sCwWku6+uCjEcfiO2kAWVzyHTjsCDfdPAdWZEofs/6nRP18TGYrKXSoYDpEm7IjvybVS/XGIZ9BqXJ4/BGPPeP1RD1Ta3tRrlxjzG/wGC+Agj/Filwe3sahBqk8HbZT1LrqhZ12k4szFDCXnr8seL2JJT+6+tKzmEx29y8H+Jv9svYj1NxX3v1r2vNKH9otLFE8P3Nzdutvut3sNKz2rwMCZMZpGwZ6MjupJMld24RPsnZf/5Bcp/rjC2rADfvmIlugtHIpNF+JTuA7J7gXMMovDJI06i+phHcOC2YtR5P+dpSV+96Dn4xWQnAugltG2XPPXpFqLcM6wW2uCpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qNo7Ax8sUSybGITEMa7tKDiN7ndPsyAoLPLAu0znZHM=; b=ZEswYdbkYRDJbSpptzEUWV4vmYQEDcFmSZfWPnRjPjsjgEGetyxiBojsx6oriAwT3mneQ/x7cwKKqYpWb9QkiPPQs9q9D4HMGcDBEKFuzhYNr6csUmWBuDgf/GIAk1IiAfgcicEeDQ9TCrrj+1Dmg7QnYGKR2NnY/0TGq5XDtd38kfEkSs5Gc/nMBJdvyFPz7RK9npJb7neGKqKfUvPPJPVyM58VMPeH/Qcc3KwxhJlqD36oOzQPxoBTGKUXtvPfRmSZKAQI7wJn0fFFIN53NzlEC1j741BGs6Q1na5+W5P9iKvsIbxUgnAkQGSOdp0COCQKBpSzC45TCHOIDlFqew== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=connect.ust.hk; dmarc=pass action=none header.from=connect.ust.hk; dkim=pass header.d=connect.ust.hk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connect.ust.hk; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qNo7Ax8sUSybGITEMa7tKDiN7ndPsyAoLPLAu0znZHM=; b=REiVyhGBkX7FODk7D/ITzMXrXFBP04/5wEQzcIYxKBVjJRI4p19kjG1YkZ8esB4kFXNFs7e+wsIhZdY++4TKfwf3S/IFhMEPG9mzURI/6snKkmZojknnAjLDROliz0dsZ7byaWUg5xWfSbBHaHRDJubtqFROxhg0n7H9b28FTgM= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=connect.ust.hk; Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) by TYCP286MB1092.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b3::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.19; Thu, 26 Aug 2021 18:56:14 +0000 Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1]) by TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1%6]) with mapi id 15.20.4436.027; Thu, 26 Aug 2021 18:56:14 +0000 From: Chengfeng Ye To: asomalap@amd.com Cc: dev@dpdk.org, Chengfeng Ye Date: Thu, 26 Aug 2021 11:55:59 -0700 Message-Id: <20210826185559.107237-1-cyeaa@connect.ust.hk> X-Mailer: git-send-email 2.17.1 Content-Type: text/plain X-ClientProxiedBy: HK2P15301CA0003.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::13) To TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from ubuntu.localdomain (218.253.253.162) by HK2P15301CA0003.APCP153.PROD.OUTLOOK.COM (2603:1096:202:1::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.0 via Frontend Transport; Thu, 26 Aug 2021 18:56:13 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 66cb0bbd-8f59-4acb-07df-08d968c32d87 X-MS-TrafficTypeDiagnostic: TYCP286MB1092: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5797; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dx4ybFjx5U+0zp666aluIMx7FMEdhvqCQ6mk4U1b66cjJRkQdpUcKIuRpnmO6n3Bdw+2AeMXZGYP9SGFKpwNTZ+C0Ushs026J4EGmzJUkQOqAXvjAodkfdmDMJrdrYan+VXn3T/cO5/4tQOChIl2LEurSPmf2oUnJQXoF58BdKt8do5w1q2hlmv4sAV5nB+eBkmFtK9WjLVJ60tU5pVTcO+PkyQfJG1O9D1kSiimYfOyabs8oYbfCrPuD7xCkagB/hEhhw55oEg4amVG8yGZwug12ri+qkuXS5SQM1TskiW8qyGcrFUHKYI814OS2I9kgWx02Vk2zHpK5/auFFDo+/iL8GycZ3IaFqjZQMqkqrfmRaz3iXBdjPhqHSnjPRLUeliCA+aGmwOjaqIU2VrVeoEvm47CIWbJiDystvJKlXKSpGGiDtP/Mjy2kIkY1cYGtF6Aa8NZdoZwHRg/NZT3P76AXNkUSHFxVLMkPNPuV8H6OtrG81RIZnIIVok7s+m79Ko7FumgSaj4yQp5MrS4nGdvGCyMgmUPgWw/P0KnCCmuUqgjZzPyodcaGNtpQfpwItBWS0m4BbGkY35YDHh/e3+sdVS1Wm/NNma6JrVl2IscXAbdQsRMom7pgyKSx/zjzGb+f5tDEG2IIZIN7p3bQ6Toz3y39l/UAFJQNvSMotmpuhMw/sPkDs1VhLmbdoD0ilVgt8DM96s/QaUOmmP1Vmw4BQsv8xyb+XPLWEvfYmw= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(136003)(346002)(366004)(396003)(39850400004)(376002)(956004)(6512007)(2616005)(6916009)(38350700002)(6486002)(66476007)(38100700002)(66556008)(1076003)(786003)(316002)(26005)(186003)(2906002)(66946007)(8676002)(86362001)(8936002)(4326008)(6506007)(52116002)(36756003)(6666004)(478600001)(83380400001)(107886003)(5660300002)(70780200001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GnzQYo2iNKjha7sZjmosvH2j9zYB1lZej578O+rOdcmveh/c2VmlTR8aQgaU?= =?us-ascii?Q?qf7Xo7WOj+lp1FGK4Rwv/6ztkJ58bn4wD8ncGRa1XD2GBSnFxFYO1kms+Vs7?= =?us-ascii?Q?cQTnCBpEsEA8FZu8Om2IlTPEyTi3jBGb4WBtJE9+34QGFEroT+bvYSEAE+KP?= =?us-ascii?Q?/rW8cHkj5ZCD0Uf7PHH1ud8CgpFyKeV8H5gJdt7HzZO1K6zx42mdaeHkUTH0?= =?us-ascii?Q?dYxhDLYWcboWsJUYbHQOb1cFbTn65s+TXYnr23JRGFKRnzHbzCZVlhy4GvBD?= =?us-ascii?Q?68D4wNj9p/1i3hEweD6O6R0v+8XIZZ5Js++Odh+4EzWbNR4IGgE0hdNGfswF?= =?us-ascii?Q?LDQ6J9JKZQEBnbovsobfFRZhoU30CsSkdIU6Bmy0KPbCGaOH+EkfNW3o/Z50?= =?us-ascii?Q?r5z9M8e8QaUVo8tjteIhy232gC4MwPdaU0vVSOfciGFT8blbQsXdN7RFoXDw?= =?us-ascii?Q?ddoVHLdBEEibTGdW9UXBXd083N3J7Saj1frhBi+FYHhx/VqQKCNpRUgJItqK?= =?us-ascii?Q?Km2lZKoldFnHYPp++X2OHjxHzmCExFhLn0Z+417VUb61oncQut28gW7H0+wB?= =?us-ascii?Q?ApiCxyBeR8V+G9iz/8M1EuruXjSAvWjsxnGwZ4IXZS+MgFpuzf34PFpvr6z7?= =?us-ascii?Q?+C0vb3jXF/iNYzPYsz9SyW9tBx4VCsS/iS3YIJPz0fEtOfmTfStl9YWJtTas?= =?us-ascii?Q?sIMcxPau/MH0iGV6ZXFjM1sxH6zf9F8dm4IoldXdPlojhBjAkVwwessZb5P2?= =?us-ascii?Q?r1qTyqJocFmDktooshHEPiL4wYSnYp8OXNGGjgQ/sK5cSnbzXdPB4YICupBt?= =?us-ascii?Q?QSqDnvoN78JkjaCh2WA+ELfd98ThZiu/79hpxuHG4y7n4wVXTSp91gmazUgz?= =?us-ascii?Q?TIzOIqbpHu7UetYdlPgwKjJKCkCbvGu+bnIVZ7A2ZTh9T9fyF8Cu8Cj0eODY?= =?us-ascii?Q?iBfWy6f/ywkTGXHMsqGxu9B2rNKkXmC7BhRHqd3Xfsmudi+IvPtEKogVsvRI?= =?us-ascii?Q?R37808jAeORHol/mLQGZN5tR67ifKk5NPNTouHaqHKTzXI1wKdqWv6idEvCW?= =?us-ascii?Q?T3FDIaOBA20P8gXjqkmBMuuaYwbPwESfqlYNBlfaFsv+vdE6ZSoOjeVcZUfd?= =?us-ascii?Q?oPf34DDd3d3B2bK7o5s0e3fP74IEvv63rNK/KoMvPQ9kQJoCWc7hKGa/F/oH?= =?us-ascii?Q?AG3nDmvAAelLIVCeTEsWHu3sU8q53d9+99EERU2CZ4BollfwIswJwQVMOB9w?= =?us-ascii?Q?dgc+qBLvK2aCak10A6wjvhBmHQrUvA2Mf+SSgQ1P08ezf9pOht6uNdGwNrKp?= =?us-ascii?Q?tutTgVThCKe+Nti8Ty29QlSL?= X-OriginatorOrg: connect.ust.hk X-MS-Exchange-CrossTenant-Network-Message-Id: 66cb0bbd-8f59-4acb-07df-08d968c32d87 X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2021 18:56:14.3482 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 6c1d4152-39d0-44ca-88d9-b8d6ddca0708 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zarrJ2kxC8giy2JpoTKDIj9KztkeNP/bjy/CC9Tfrdrlpnknmdi5V9C4PLWBg2NTJJIcmhFmnISHZyWepIwb0g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB1092 X-Mailman-Approved-At: Fri, 27 Aug 2021 03:22:49 +0200 Subject: [dpdk-dev] [PATCH v2] net/axgbe: fix potential unreleased lock problem in axgbe_i2c_xfer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The lock pdata->i2c_mutex is not released if the function return in these two patched branches, which may lead to deadlock problem if this lock is acquired again. Cc: cyeaa@connect.ust.hk Bugzilla ID: 777 Signed-off-by: Chengfeng Ye --- drivers/net/axgbe/axgbe_i2c.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/axgbe/axgbe_i2c.c b/drivers/net/axgbe/axgbe_i2c.c index ab3738a12e..a2798f484e 100644 --- a/drivers/net/axgbe/axgbe_i2c.c +++ b/drivers/net/axgbe/axgbe_i2c.c @@ -233,6 +233,7 @@ static int axgbe_i2c_xfer(struct axgbe_port *pdata, struct axgbe_i2c_op *op) ret = axgbe_i2c_disable(pdata); if (ret) { PMD_DRV_LOG(ERR, "failed to disable i2c master\n"); + pthread_mutex_unlock(&pdata->i2c_mutex); return ret; } @@ -249,6 +250,7 @@ static int axgbe_i2c_xfer(struct axgbe_port *pdata, struct axgbe_i2c_op *op) ret = axgbe_i2c_enable(pdata); if (ret) { PMD_DRV_LOG(ERR, "failed to enable i2c master\n"); + pthread_mutex_unlock(&pdata->i2c_mutex); return ret; } -- 2.17.1