From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81145A0C54; Fri, 27 Aug 2021 03:23:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86D7541258; Fri, 27 Aug 2021 03:22:53 +0200 (CEST) Received: from JPN01-OS2-obe.outbound.protection.outlook.com (unknown [40.107.141.125]) by mails.dpdk.org (Postfix) with ESMTP id A62B540140 for ; Thu, 26 Aug 2021 21:03:12 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=myWVfKTBpwQyviYV+UsStQXlxWmeic+Rj2M69xkZkMQsr9YBB5fv+C1J9cN+nG6hnz9zzR5K5zZznWz5Vioxwp7HHI2o6TgWnSuAyCIIdc4473MmqBDz6SU1J5HnckjkzaqSRyADqAiYq7X5wpZ5dCVfvghyghRp0zxgv8hJmm5ohSokcMQmjbK+Q8vr2wAcdw+HD9SqUsvzbDsUkYAn6/XnXJi03MSEMZ188ZbixKgAor1mbncBNToPrb2/5HdxA09+dTmqpKBST0VKjqrG1g54CH+oVTLVWr0MXWSGY7hOoUaT98cihcUarNtJFYlqLq29jZeU6wTCMc063sOt9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PJ+YWcUqMnqTIBXhJr46ZeVgZmyg5dMEEYVfvWmVDwg=; b=WZRVw0zoXBIKDmHx6851H4HXKkwAEEq/CtSjyr6dIrwbKbBIQr5umWR8Dnd8yNJbPNZPpDK0KUFHGz/gic/s44zBX/PBx9jeGXf/Ee4SWi3zarijcY6s2e2Sm5hjErimUwTYtdEYZcfu8g0FgBbrWXkna7PdHV/ujC1kgi81wUgfgDT1wcmfitDWM31aLvYX5pbKTZSKTz6BbLjJbobTgvQxXYuQZj+LvfPFxjxY8v74XrdZtlIigWAuDRMh1TwGQfZxzYNJDa7C4rp0S3rzwVjcFazxj0SK5zyQzQxZH+PVN/j8OvJT6FoEwymWvrczrcVE+h9X8SqQ8L1y2bEO9A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=connect.ust.hk; dmarc=pass action=none header.from=connect.ust.hk; dkim=pass header.d=connect.ust.hk; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connect.ust.hk; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=PJ+YWcUqMnqTIBXhJr46ZeVgZmyg5dMEEYVfvWmVDwg=; b=CVLbWcOkZw3O7quTtRLO49IgZXk2GAFVTj4HfS5rloyBzyseSbalfw4TbFnhPmGlzj1kVAbGQoPn8oMQ16GaaTunUmWlp3Mq6QbVMj04em57z+ZcGdZsbPoImXU+sDpj6B1GFe9rmdys2Z2K7tBz3Nz8GTLxzNSsfi5JiGmUPwk= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=connect.ust.hk; Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) by TYCP286MB1425.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:c0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.20; Thu, 26 Aug 2021 19:03:07 +0000 Received: from TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1]) by TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM ([fe80::b9cf:11ff:5f5a:32c1%6]) with mapi id 15.20.4436.027; Thu, 26 Aug 2021 19:03:07 +0000 From: Chengfeng Ye To: asomalap@amd.com Cc: dev@dpdk.org, Chengfeng Ye Date: Thu, 26 Aug 2021 12:02:58 -0700 Message-Id: <20210826190258.108062-1-cyeaa@connect.ust.hk> X-Mailer: git-send-email 2.17.1 Content-Type: text/plain X-ClientProxiedBy: HK2PR04CA0086.apcprd04.prod.outlook.com (2603:1096:202:15::30) To TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:b7::8) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from ubuntu.localdomain (218.253.253.162) by HK2PR04CA0086.apcprd04.prod.outlook.com (2603:1096:202:15::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.18 via Frontend Transport; Thu, 26 Aug 2021 19:03:06 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 46c970ee-5421-4116-66fb-08d968c423a2 X-MS-TrafficTypeDiagnostic: TYCP286MB1425: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6430; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: XVA0GisbvMRm5l+oEgQpYaUJaC2jNu2NuBZhT4114izBjXddSvmPDlUVWRTR96MeElMC7fgIJE2mXUed07l3vXjKDPQPe05lyBzZCL+nYG0vlGGOKPbEEloecPC3tBHHmAuGqYWVHTVBhonFFASZ82u4HOVYDfp7vLL8OUHt2Tdd6BBy/suRF+okz5GqfLvHM/uZxNQ00bZq0d0VN0Q0eyBWoqjFYEKx/TI11L5+JpagfS+hvXVhJJwFLoUBdpfchl76PaoIqSnc1V+5kgWGk5jcndCUxO+/W01jbaqFqx0iECS8jpvS+AveRc+q2bEGiI6czr9EQRNVu3I94DnsJ0q4RAuvHh62mHuuN2vkbQisg0NyyeAursO+y48PtPVlMW/f1j0QfCZgq87v0eSxYH2LY9jlWYpzKYdIbGn4jM2l+aKBoeAn2CCqhZDmB3Fx3yOfb/up8y9GEVbR/PBB3q9HWnRyIZffzEynNSUGhP9+5ot9lgnaNqqbx6ygP3eCf2D+vPK9GlFU+hpUDk0p4AbvsdU1NBNRmC6nHKe+eZ7I0kZpsGNN/MTavpvkOvYkh3EVJN9gfAE9SdJrdvOZsRpUY0kgUhTf3UVOSYEZS89dIzQUR64oVkM6iHCeTNmatVC8Dtf2TwrBIh05LnmUwO8J64g+F3OKJxdA0EVflX+upUUhSZl9MqdIv5W2Q4yGK8rv2hggGlDX+GFDJbJk8Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(4636009)(396003)(39850400004)(366004)(136003)(346002)(376002)(38100700002)(38350700002)(4326008)(52116002)(6666004)(786003)(316002)(6486002)(83380400001)(8676002)(26005)(107886003)(66946007)(66476007)(66556008)(8936002)(6512007)(2906002)(6916009)(36756003)(956004)(2616005)(186003)(6506007)(1076003)(86362001)(5660300002)(478600001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?BoyS9JK8gcELXeUFwYZlHF/LRDRHrzn5DmVH4ixE4UeT7guI+CkAUUKZWGKJ?= =?us-ascii?Q?GeeQLUNrTMCcdNOFyBe8yYnoXmurrUAmxd+tDsiVDokdfQeiLWQ7XSQE1NTg?= =?us-ascii?Q?nb1R7ZEGuh8DF/9p9ys22jyTHThLYex4ALe5O+44srwHVbFmGndozlxHh3Dw?= =?us-ascii?Q?67AzirQdqrKFGIZXrjb1nTSdIFRCsxyCnNoh3/J3PWnRNtxiRwAxf65d/3ok?= =?us-ascii?Q?5owfecMptgpE+Jjz5rT/R3Orhwhc9BJBzuflcWeLB6ElD6bJerIa8Rs6TzRq?= =?us-ascii?Q?qivSo01/o7TeP3hZOLk5lXj7owuPDIOsLITSa1pM23KYcaxoMtW0m+UtIqiI?= =?us-ascii?Q?YM/pxUu1B3Q97+g8YLkL64I5/8uJJcdUGxj0QrY796Iq/oZQ6Fhb9Khmj1eg?= =?us-ascii?Q?BOjPRQJBYbazMSG/jOmRWpmhxMOOX+83y+uEznqguYqZ3CGCT11K0ATYQSol?= =?us-ascii?Q?DftOjNhgLr4oiQXz38fS3snOT9nSr9SKm/AftjD3OTfM9DnfJtXV6pXfr6LG?= =?us-ascii?Q?oebEJfOTe4/Lt3Y3pFaiiS5iFLJEU9xwfja+2p/3xCnajIstgdCYI4vc/wZF?= =?us-ascii?Q?NKvI06lu4L7SVcWjGU5MSrbQbvZBGeJt9T48H0a3heGoOrhx+E8VVidY8hYx?= =?us-ascii?Q?NaIku01RknJjVfZ5s7vMtL44qernUOguiJSOzzWLcLsKy3/KAZgLa3j7iCpa?= =?us-ascii?Q?dLEczoOPHrXFgt0b921OlMUveluukYcHGVPsXdzzxtXmDlIijd7pX3R05jpi?= =?us-ascii?Q?Fn4JFTM2ch9y83LWuf/xVtQCWH3xfeFo5bUGgWpVGt6F1R6/nW6V/SqLx3zB?= =?us-ascii?Q?B+KZcr+XAhcwW5ps+DtPtRvCBpAQD8XFgpELXprI69G91fTmswroyCXabzzJ?= =?us-ascii?Q?x9kd5DiUpWx1x37c9YCBdWk9CyC3LZQ9HdNFCuEnNpImeb8E/W11VzKIDtXB?= =?us-ascii?Q?3iaPlkLn7kcBQKS9Uc0uvJxvGDBW6XhU/1Oa4KFWj/MTFen7D7bN+67VtXJT?= =?us-ascii?Q?kfoE0s6VKhILLVbOdXOuGEpi0wxCEhdtZPqzBgOyVreGcFEuBSdZeoF3wYPR?= =?us-ascii?Q?XZFe2h5ncnyOJtv/teKGzpaNroKDzKdFIAvqFbc4y+EcRmq64asx+EJGjVmM?= =?us-ascii?Q?vLPNIHn1cdtZsst37jvj6kJtRZkExkQQiqonBensrzdHZQHBu+1tl1uZigah?= =?us-ascii?Q?SQcaxO6aUaZvPzGrRzkNXqQKGuwFgx/AVHh9YeDcT1cwqP1t6E+A7pTfyyoa?= =?us-ascii?Q?tfaVyzd+O3mF/qAA1oDTQUSJaChyA5BZHGWeHmHdMRkLHw+idJjg0/Bv+1Zt?= =?us-ascii?Q?3DsHE9cts3XMdQDEETZo913v?= X-OriginatorOrg: connect.ust.hk X-MS-Exchange-CrossTenant-Network-Message-Id: 46c970ee-5421-4116-66fb-08d968c423a2 X-MS-Exchange-CrossTenant-AuthSource: TYCP286MB1188.JPNP286.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Aug 2021 19:03:07.2560 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 6c1d4152-39d0-44ca-88d9-b8d6ddca0708 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3ruTpJzH2UpAXWk3qt3vrATe1fXY7kwMerT7ylGVMk+RPm8715fRsbOAeSL2v3B3L0aO+FeSo58UilS6RiGrZw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCP286MB1425 X-Mailman-Approved-At: Fri, 27 Aug 2021 03:22:49 +0200 Subject: [dpdk-dev] [PATCH v2] net/axgbe: fix potential unreleased lock problem X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The lock pdata->phy_mutex may not be correctly released if the function return in these two branches, which may lead to deadlock if the lock is acquired again. Cc: cyeaa@connect.ust.hk Bugzilla ID: 776 Signed-off-by: Chengfeng Ye --- drivers/net/axgbe/axgbe_phy_impl.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index 02236ec192..cf39095ee4 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -418,8 +418,10 @@ static int axgbe_phy_get_comm_ownership(struct axgbe_port *pdata) */ pthread_mutex_lock(&pdata->phy_mutex); - if (phy_data->comm_owned) + if (phy_data->comm_owned) { + pthread_mutex_unlock(&pdata->phy_mutex); return 0; + } /* Clear the mutexes */ XP_IOWRITE(pdata, XP_I2C_MUTEX, AXGBE_MUTEX_RELEASE); @@ -444,6 +446,7 @@ static int axgbe_phy_get_comm_ownership(struct axgbe_port *pdata) XP_IOWRITE(pdata, XP_MDIO_MUTEX, mutex_id); phy_data->comm_owned = 1; + pthread_mutex_unlock(&pdata->phy_mutex); return 0; } -- 2.17.1