From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id B6C92A0C57;
Sun, 29 Aug 2021 00:18:15 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id A48D04068B;
Sun, 29 Aug 2021 00:18:15 +0200 (CEST)
Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com
[209.85.167.42]) by mails.dpdk.org (Postfix) with ESMTP id 9E2AF4068A
for <dev@dpdk.org>; Sun, 29 Aug 2021 00:18:14 +0200 (CEST)
Received: by mail-lf1-f42.google.com with SMTP id j4so22496707lfg.9
for <dev@dpdk.org>; Sat, 28 Aug 2021 15:18:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=t9wzE3t5Ur9MpP+JrFO4JZ1vWb8WdfaaQ2KaInarue8=;
b=RznwI7RRbS2jUwITXRSYQaKWIg2rlP+CIAleEWQbOTxzK1pF+wRiJxt2Zbi9jeXFTo
yhUDSrBVvcocQzgS+Kwv4TmHXPwp5bCf2xYf3HUNMEoc5AvD2kb9lQ2/5QCuXxsoVUlW
M3ox2OiHZC5cCqkTXsHbLZIAUL8c2INvmLzQ4BYnxN3mf19Be9h+Vo7aCNdwcQJjmEhm
kgT7U/UlJRINIp627+gP5odasc+fUJJt0kycv15Y/v7qLfPHYhvMREKZWRQc3nZoquPt
HFE5RZn8cyCI0pB+QaF4rhOJgnP2idsf0KnrAsNhCim4B4TX1VqwGxxiOMynfE6N18ig
hEGQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=t9wzE3t5Ur9MpP+JrFO4JZ1vWb8WdfaaQ2KaInarue8=;
b=Cdc2NOaAgTECBfEoYofISxft6Jt9zCAzH8zZd3qOGS98p400XgVKqFy7zjYc9+/ixT
BaJwCbjRFQI96Pq46/SpeWsKWi9SpdHXfOEMMwjMvkMaO3ppdtvrgX3Pu/gYedevN4sk
dJphcb1I77q7JKFLLpqDegCGiCaJwwJQpCp93vaFVXrFs9CkRPVqBydYqRNU8+Iuggjj
C3ygB07eO/VHc7ApL8rZRR0gJ4hmFe3m/peahxSInS6et380CgXvqo0Wbji0tZ6C+RCx
uf6G+mgXwuLfwR/4f6pannWcnRR/u8NZBpeunhchlrf2trInS7EYbTGOBbXkV7gT5jZQ
ST8Q==
X-Gm-Message-State: AOAM532h3XFP0exyyvqUDPDtrMF0lWhj81CCFlgmNlidDdQpnvbNjnHf
ocqWLohY08lF5iIvFqcdS98=
X-Google-Smtp-Source: ABdhPJyWHny03gJkoaQgiXUeFlXr4oib/juAqS+/ZFEFefXkRUAqenG+/3uvZBw90AICed5uWkp/rA==
X-Received: by 2002:ac2:434f:: with SMTP id o15mr11680244lfl.124.1630189094245;
Sat, 28 Aug 2021 15:18:14 -0700 (PDT)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
[37.110.65.23])
by smtp.gmail.com with ESMTPSA id c10sm974572lfm.271.2021.08.28.15.18.13
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sat, 28 Aug 2021 15:18:13 -0700 (PDT)
Date: Sun, 29 Aug 2021 01:18:12 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: Jie Zhou <jizh@linux.microsoft.com>
Cc: dev@dpdk.org, roretzla@microsoft.com, navasile@linux.microsoft.com,
dmitrym@microsoft.com, pallavi.kadam@intel.com, talshn@nvidia.com,
thomas@monjalon.net, aconole@redhat.com
Message-ID: <20210829011812.37662dbb@sovereign>
In-Reply-To: <1629306834-6277-14-git-send-email-jizh@linux.microsoft.com>
References: <1629267476-901-1-git-send-email-jizh@linux.microsoft.com>
<1629306834-6277-1-git-send-email-jizh@linux.microsoft.com>
<1629306834-6277-14-git-send-email-jizh@linux.microsoft.com>
X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2 13/13] app/test: enable subset of unit
tests on Windows
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
2021-08-18 10:13 (UTC-0700), Jie Zhou:
> In app/test/meson.build
> - Specify the subset of source files to compile on Windows
> - Specify the subset of tests to be enabled on Windows
> Signed-off-by: Jie Zhou <jizh@linux.microsoft.com>
> ---
> app/test/meson.build | 859 ++++++++++++++++++++++++++-----------------
> 1 file changed, 515 insertions(+), 344 deletions(-)
Commit messages should explain the reason for the change,
which itself is precisely described by the diff below.
For example, why these specific tests are selected?
Please don't create two lists, it will be hard to maintain.
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 7240304916..1e77657510 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
[...]
> @@ -362,7 +533,7 @@ endif
> if dpdk_conf.has('RTE_EVENT_SKELETON')
> test_deps += 'event_skeleton'
> endif
> -if dpdk_conf.has('RTE_LIB_TELEMETRY')
> +if not(is_windows) and dpdk_conf.has('RTE_LIB_TELEMETRY')
> test_sources += ['test_telemetry_json.c', 'test_telemetry_data.c']
> fast_tests += [['telemetry_json_autotest', true], ['telemetry_data_autotest', true]]
> endif
"not" is not a function, "if not is_windows and ..." is the preferred style.