From: Stephen Hemminger <stephen@networkplumber.org>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] eal: make rte_lcore_cpuset and rte_lcore_to_cpu_id stable
Date: Thu, 2 Sep 2021 08:23:14 -0700 [thread overview]
Message-ID: <20210902082314.59e2e22b@hermes.local> (raw)
In-Reply-To: <ae3c4e88-8731-9df0-7ad0-225c45d4391b@oktetlabs.ru>
On Thu, 2 Sep 2021 09:01:58 +0300
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote:
> On 9/1/21 8:16 PM, Stephen Hemminger wrote:
> >
> >>> /**
> >>> - * @warning
> >>> - * @b EXPERIMENTAL: this API may change without prior notice.
> >>> - *
> >>> * Return the cpuset for a given lcore.
> >>> * @param lcore_id
> >>> * the targeted lcore, which MUST be between 0 and RTE_MAX_LCORE-1.
> >>> * @return
> >>> * The cpuset of that lcore
> >>> */
> >>> -__rte_experimental
> >>> rte_cpuset_t
> >>> rte_lcore_cpuset(unsigned int lcore_id);
> >>
> >> I'm wondering why negative lcore_id is supported above
> >> with special meaning, but not supported here.
> >
> > The DPDK API stability in this case means staying bug-for-bug
> > compatible. I.e passing -1 as unsigned int results in UINT_MAX which
> > is invalid.
>
> Isn't promotion to stable the last chance to review and
> fix without much pain?
>
My opinion is that if you want to change the API (including
semantics), then the experimental clock would have to be reset.
prev parent reply other threads:[~2021-09-02 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-31 20:08 Stephen Hemminger
2021-09-01 7:04 ` Andrew Rybchenko
2021-09-01 17:16 ` Stephen Hemminger
2021-09-02 6:01 ` Andrew Rybchenko
2021-09-02 15:23 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210902082314.59e2e22b@hermes.local \
--to=stephen@networkplumber.org \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).