From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CF980A0C4C; Thu, 2 Sep 2021 17:23:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B90DB4003E; Thu, 2 Sep 2021 17:23:20 +0200 (CEST) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 5107D4003C for ; Thu, 2 Sep 2021 17:23:19 +0200 (CEST) Received: by mail-pj1-f54.google.com with SMTP id l3so1579621pji.5 for ; Thu, 02 Sep 2021 08:23:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=deaEp+0GzGk06NVG5SEKbdLJffQh3wqrIiMy99Ce0Pc=; b=bGScImAPO3p+THIT4Ui6NRbJkYQdSD0YNAK3ivwdNbBvWDNoudnCCkvo8Q9kBxSqWC LvHV0tU1Q4dN4rW3Jzarx0tnJN9ZwIa6vpKLDEuu9plnqtk9JKL3nTO0/mwaJ5IyFXTb MIJyWMZqtEyjZy9XlbqWMmzaOiHeGwHu57JZkbpVLRdtnhNoCDzB2vMmjwAwAnjlW4AA DTFnrMFO5QTDlORhHHhHNsgiEnRO9jWD3d2BqSyc0T8zXnPVNXTJBdNvJlIc88lPMt6D RuTnaaql9k+QQuqWbNCLWbHp9ggUFpkKGGKzICNwCX6vKMU1K8tX28POeIr/CxZJ8uJR Hy/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=deaEp+0GzGk06NVG5SEKbdLJffQh3wqrIiMy99Ce0Pc=; b=Db3+0hdz8lwXxaBtscsVQJgqn3BZddoNVnvFf6gFu/pWdwKkHx4hivd4bqw8VF8aHu aGuvR1svZgCxm9oQswMQdfSN/8T/sTbcgF6xBJGJbSoHHcBdstFqtK/rFth4a0Us3U9e N2yQruq/k9Wp3CQedzYh/hYOkUL0PP7bhwDl2gxhcpkImGWm7bvgoZn5eGi8e6S0wGYQ NLBx9b8e3lMcNj71R0JYoTV0MgOo+zqgkFnaEWI8dsCcmV6E+675rKhbl3R0p8rKuY0P WtWyjFRr6dtp/S+gy2bsbKjb5UaVUqfnJjb/DBq1nS3QjH9vmCOCBpS8WSwA9tDcbVkZ 2Fuw== X-Gm-Message-State: AOAM533dhO+h3GDJUdoFvnOOmm2XVLB0VZBXwmQ/ZwIE2Ez6sRr3Btyf BWkw3ccw6vLi8gWdlDxDtRay1q3ndpEBNg== X-Google-Smtp-Source: ABdhPJxADEqTGXScVjT6rQ6vIF1dWGezY2XzsZxSOeusr0ITYTRuvQ3G4FM09irFGoA1cBVqIA6uEQ== X-Received: by 2002:a17:902:b7c8:b0:138:c28f:a775 with SMTP id v8-20020a170902b7c800b00138c28fa775mr3336959plz.11.1630596198441; Thu, 02 Sep 2021 08:23:18 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id i7sm3365170pgd.56.2021.09.02.08.23.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 08:23:17 -0700 (PDT) Date: Thu, 2 Sep 2021 08:23:14 -0700 From: Stephen Hemminger To: Andrew Rybchenko Cc: dev@dpdk.org Message-ID: <20210902082314.59e2e22b@hermes.local> In-Reply-To: References: <20210831200839.93556-1-stephen@networkplumber.org> <057efbd9-f3ec-b4c7-5add-fdf7baeebbee@oktetlabs.ru> <20210901101611.260d79bc@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] eal: make rte_lcore_cpuset and rte_lcore_to_cpu_id stable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2 Sep 2021 09:01:58 +0300 Andrew Rybchenko wrote: > On 9/1/21 8:16 PM, Stephen Hemminger wrote: > > > >>> /** > >>> - * @warning > >>> - * @b EXPERIMENTAL: this API may change without prior notice. > >>> - * > >>> * Return the cpuset for a given lcore. > >>> * @param lcore_id > >>> * the targeted lcore, which MUST be between 0 and RTE_MAX_LCORE-1. > >>> * @return > >>> * The cpuset of that lcore > >>> */ > >>> -__rte_experimental > >>> rte_cpuset_t > >>> rte_lcore_cpuset(unsigned int lcore_id); > >> > >> I'm wondering why negative lcore_id is supported above > >> with special meaning, but not supported here. > > > > The DPDK API stability in this case means staying bug-for-bug > > compatible. I.e passing -1 as unsigned int results in UINT_MAX which > > is invalid. > > Isn't promotion to stable the last chance to review and > fix without much pain? > My opinion is that if you want to change the API (including semantics), then the experimental clock would have to be reset.