From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2C2DBA0C53; Thu, 2 Sep 2021 17:25:03 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 196DA4003E; Thu, 2 Sep 2021 17:25:03 +0200 (CEST) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 0E6F54003C for ; Thu, 2 Sep 2021 17:25:02 +0200 (CEST) Received: by mail-pj1-f54.google.com with SMTP id u11-20020a17090adb4b00b00181668a56d6so1710654pjx.5 for ; Thu, 02 Sep 2021 08:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Tv3cmBDW0YR8Mwls86LGa51gH7Hf1T09lObOYcd+NEk=; b=tKTZTqNPHtk5badRHIaoZ1UGUtCfH7m1NavbBpemI1G/OLGxYoDyNLK7bwFcDTtZrD oQxDvqlRl0APOBI45DH0RLZP1nxWQwaH9HE90PGvroMVaoFBoyLi5z/szG1baOkJVWV3 tMAH+mJfxpWVfQ//nXs+ELXbRWADGFD/WKOwPOAE5/YSXviCS4jkF+M4aOYzvQbj7g6F 2snqmJOCh1thsZ03GIAfiJobljB38wnNbFiThbXSqL1/C9euQj7NETvBe4cqhMDE3kjd 4sqsdq5LRiZRGLZCQaVAQ8ilLohnF7dIo8hVNl49NoK+N+0nNdoQkaUA0d1JF3oKxH9Z tQ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Tv3cmBDW0YR8Mwls86LGa51gH7Hf1T09lObOYcd+NEk=; b=devTDbRDCDAAfr2zJVOxDowr0hzZOvLy/KsFF41br0R43XoDP1ZtLSRUI1VqxxU/px 1vvVh1Sd0eMhZH6SP+Aq1LPx5WudJalTIfeg5tTl9cpzbxHelMQwQrbALPrU1H1xTGdD /Zic4DbwE9nP4m+qNzM1NLgUf8kZT/RiJwTOj+qhc+1nBxQapcPNNArK6piYZ2yeF3qY QxrV56q+l2ruOgUU5tRn6EhYH5n1W4n0LWjMWHhY1oBavbPP6bEqbtz12HKi0IULnQsv 0uUW1FnRtgkSJLOz+qOHCHHa8Q41aqEqpGfzQ/v2Hm60AoONLeBoT6sSVJoYUZ7Mai3T OBtQ== X-Gm-Message-State: AOAM532A5lYnTGBt3MdiER4p1yH33/IK4YLJvf3leqFwLeSEGzQsrOnu bBdD51s5Uyel641VgbZrF2j85w== X-Google-Smtp-Source: ABdhPJwnKnhEMlMio+KckR3WAFzrSKHkQ72fwBl+96Zg5JWE9X39bTaen3uUdkO28ERlANbiCK+BNg== X-Received: by 2002:a17:90a:ae12:: with SMTP id t18mr4499902pjq.211.1630596301136; Thu, 02 Sep 2021 08:25:01 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id s31sm2756218pfw.23.2021.09.02.08.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 08:25:00 -0700 (PDT) Date: Thu, 2 Sep 2021 08:24:58 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org Message-ID: <20210902082458.1ba387f5@hermes.local> In-Reply-To: References: <20210901212707.25079-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2 Sep 2021 09:10:47 +0100 Bruce Richardson wrote: > On Wed, Sep 01, 2021 at 02:27:07PM -0700, Stephen Hemminger wrote: > > This fixes most of the warnings from the Flake8 style checker. > > The ones remaing are long lines (we allow > 79 characters) > > and a line break warning. The line break style changed in later > > versions of PEP 8 and the tool is not updated. > > > > https://www.flake8rules.com/rules/W503.html > > > > Signed-off-by: Stephen Hemminger > > --- > > usertools/dpdk-devbind.py | 70 ++++++++++++++++++++++----------------- > > 1 file changed, 39 insertions(+), 31 deletions(-) > > > Thanks for the cleanup. > > Acked-by: Bruce Richardson I don't use devbind (except in artifical testing), could someone with hardware make sure that nothing changed here.