From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A442DA0C4C; Thu, 2 Sep 2021 18:05:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 302A14003E; Thu, 2 Sep 2021 18:05:06 +0200 (CEST) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id 8EFCB4003C for ; Thu, 2 Sep 2021 18:05:04 +0200 (CEST) Received: by mail-pj1-f41.google.com with SMTP id n13-20020a17090a4e0d00b0017946980d8dso1780167pjh.5 for ; Thu, 02 Sep 2021 09:05:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5yux5/JS7z5MUxlQQbLc7BwWxc0qP4TChykMQ6Gj6Ms=; b=pwOnQX/QhzaOcJ2tdzJHEEDssV5WvIo8jvjavo12r5Kl17rxLQpmY1ZXYPZ6aCbRTm I4l6gjxK8p/OIq+TT3PqMY86R35z9SPg/R6qihYJfg5cHJ+sEJrGUdnpFn5tSrGL0Wbs hDSdjZ+NkACiVvoiNDMHBVfufWLIAWAKK24mYLypsgilBrGQiLFP+3ad7qNWOZjk5q3d WCYbvH3sxRc8OlK4kdXpeHfrOJ9Bvqn/RKWEssdvwmjMsqpsnB+n4lu7WnBOGEOEBLM4 1GTNWwJ9LU5fWHFYvmHNG1ikaZDnoAsdC7OjMFbeO1ib3mKE6ZJOSzPuQyENnv92IPnB 6gbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5yux5/JS7z5MUxlQQbLc7BwWxc0qP4TChykMQ6Gj6Ms=; b=dQdAp7JR/EDv/b6J61qtAn4m4ssDqXlvLe8mGvUm9nMK17if6khSvyjFpDQ/wCi83p 3ppvaFJdxJrPcn2MwcjL9zM3iPFB+UYB/3DRI4X+FpBDe1t7TYaRez+YTkgM13oP/M1n 6PVtPAtCAqZVtVFjw+J4vb8t7qJQ5du2oNNXIWIH/ifw32TWoC03sLvt4AE9XTUiBDek WP91PDLVOvznmqm3+0QyoeYRAwn3F4Qmma+gMuKBRgKKiQfDDASdmIQTYGZasFLCSgJU n+elV99FMyN3QnbZWMriy/jn9yYzMjNNpwxslVKuYGW2GbTrCYwOmtf14pgFoP0N2YsW wfXA== X-Gm-Message-State: AOAM532R/8JSXfTsk+zKIV8Iva0zR4UOmBi6CZlr14T6YUdBdxtXiy/T WWMy0+5/car4Otzz17/cnsHW4Q== X-Google-Smtp-Source: ABdhPJwB2Ln+BigxbBtFsM0mGszZ1VAprbvisRW1BzoUSP7wSfAq3OXlNK74VKMkKCSgGAgyBJ3cog== X-Received: by 2002:a17:90b:17c3:: with SMTP id me3mr3149597pjb.119.1630598703421; Thu, 02 Sep 2021 09:05:03 -0700 (PDT) Received: from hermes.local (204-195-33-123.wavecable.com. [204.195.33.123]) by smtp.gmail.com with ESMTPSA id m28sm3343379pgl.9.2021.09.02.09.05.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Sep 2021 09:05:02 -0700 (PDT) Date: Thu, 2 Sep 2021 09:04:59 -0700 From: Stephen Hemminger To: Bruce Richardson Cc: dev@dpdk.org Message-ID: <20210902090459.33d98d8e@hermes.local> In-Reply-To: References: <20210901212707.25079-1-stephen@networkplumber.org> <20210902082458.1ba387f5@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [RFC] devbind: conform to PEP 8 recommended style X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2 Sep 2021 16:50:14 +0100 Bruce Richardson wrote: > On Thu, Sep 02, 2021 at 08:24:58AM -0700, Stephen Hemminger wrote: > > On Thu, 2 Sep 2021 09:10:47 +0100 > > Bruce Richardson wrote: > > > > > On Wed, Sep 01, 2021 at 02:27:07PM -0700, Stephen Hemminger wrote: > > > > This fixes most of the warnings from the Flake8 style checker. > > > > The ones remaing are long lines (we allow > 79 characters) > > > > and a line break warning. The line break style changed in later > > > > versions of PEP 8 and the tool is not updated. > > > > > > > > https://www.flake8rules.com/rules/W503.html > > > > > > > > Signed-off-by: Stephen Hemminger > > > > --- > > > > usertools/dpdk-devbind.py | 70 ++++++++++++++++++++++----------------- > > > > 1 file changed, 39 insertions(+), 31 deletions(-) > > > > > > > Thanks for the cleanup. > > > > > > Acked-by: Bruce Richardson > > > > I don't use devbind (except in artifical testing), could someone with > > hardware make sure that nothing changed here. > > I didn't go testing with all possible options and inputs, but basic > operation for binding unbinding devices and giving error messages for > invalid device names works fine with this patch applied. > > Tested-by: Bruce Richardson Thanks