DPDK patches and discussions
 help / color / mirror / Atom feed
From: Haiyue Wang <haiyue.wang@intel.com>
To: dev@dpdk.org
Cc: Haiyue Wang <haiyue.wang@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Beilei Xing <beilei.xing@intel.com>
Subject: [dpdk-dev] [PATCH v3 3/4] common/iavf: remove the FDIR query opcode
Date: Tue,  7 Sep 2021 15:33:03 +0800	[thread overview]
Message-ID: <20210907073304.73548-4-haiyue.wang@intel.com> (raw)
In-Reply-To: <20210907073304.73548-1-haiyue.wang@intel.com>

The VIRTCHNL_OP_QUERY_FDIR_FILTER opcode is not used, so remove it.

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/common/iavf/virtchnl.h | 38 ----------------------------------
 1 file changed, 38 deletions(-)

diff --git a/drivers/common/iavf/virtchnl.h b/drivers/common/iavf/virtchnl.h
index c56c668cff..83f51d889f 100644
--- a/drivers/common/iavf/virtchnl.h
+++ b/drivers/common/iavf/virtchnl.h
@@ -146,7 +146,6 @@ enum virtchnl_ops {
 	VIRTCHNL_OP_DEL_RSS_CFG = 46,
 	VIRTCHNL_OP_ADD_FDIR_FILTER = 47,
 	VIRTCHNL_OP_DEL_FDIR_FILTER = 48,
-	VIRTCHNL_OP_QUERY_FDIR_FILTER = 49,
 	VIRTCHNL_OP_GET_MAX_RSS_QREGION = 50,
 	VIRTCHNL_OP_GET_OFFLOAD_VLAN_V2_CAPS = 51,
 	VIRTCHNL_OP_ADD_VLAN_V2 = 52,
@@ -244,8 +243,6 @@ static inline const char *virtchnl_op_str(enum virtchnl_ops v_opcode)
 		return "VIRTCHNL_OP_ADD_FDIR_FILTER";
 	case VIRTCHNL_OP_DEL_FDIR_FILTER:
 		return "VIRTCHNL_OP_DEL_FDIR_FILTER";
-	case VIRTCHNL_OP_QUERY_FDIR_FILTER:
-		return "VIRTCHNL_OP_QUERY_FDIR_FILTER";
 	case VIRTCHNL_OP_GET_MAX_RSS_QREGION:
 		return "VIRTCHNL_OP_GET_MAX_RSS_QREGION";
 	case VIRTCHNL_OP_ENABLE_QUEUES_V2:
@@ -1733,20 +1730,6 @@ struct virtchnl_fdir_rule {
 
 VIRTCHNL_CHECK_STRUCT_LEN(2604, virtchnl_fdir_rule);
 
-/* query information to retrieve fdir rule counters.
- * PF will fill out this structure to reset counter.
- */
-struct virtchnl_fdir_query_info {
-	u32 match_packets_valid:1;
-	u32 match_bytes_valid:1;
-	u32 reserved:30;  /* Reserved, must be zero. */
-	u32 pad;
-	u64 matched_packets; /* Number of packets for this rule. */
-	u64 matched_bytes;   /* Number of bytes through this rule. */
-};
-
-VIRTCHNL_CHECK_STRUCT_LEN(24, virtchnl_fdir_query_info);
-
 /* Status returned to VF after VF requests FDIR commands
  * VIRTCHNL_FDIR_SUCCESS
  * VF FDIR related request is successfully done by PF
@@ -1879,24 +1862,6 @@ struct virtchnl_queue_tc_mapping {
 
 VIRTCHNL_CHECK_STRUCT_LEN(12, virtchnl_queue_tc_mapping);
 
-/* VIRTCHNL_OP_QUERY_FDIR_FILTER
- * VF sends this request to PF by filling out vsi_id,
- * flow_id and reset_counter. PF will return query_info
- * and query_status to VF.
- */
-struct virtchnl_fdir_query {
-	u16 vsi_id;   /* INPUT */
-	u16 pad1[3];
-	u32 flow_id;  /* INPUT */
-	u32 reset_counter:1; /* INPUT */
-	struct virtchnl_fdir_query_info query_info; /* OUTPUT */
-
-	/* see enum virtchnl_fdir_prgm_status; OUTPUT */
-	s32 status;
-	u32 pad2;
-};
-
-VIRTCHNL_CHECK_STRUCT_LEN(48, virtchnl_fdir_query);
 
 /* TX and RX queue types are valid in legacy as well as split queue models.
  * With Split Queue model, 2 additional types are introduced - TX_COMPLETION
@@ -2254,9 +2219,6 @@ virtchnl_vc_validate_vf_msg(struct virtchnl_version_info *ver, u32 v_opcode,
 	case VIRTCHNL_OP_DEL_FDIR_FILTER:
 		valid_len = sizeof(struct virtchnl_fdir_del);
 		break;
-	case VIRTCHNL_OP_QUERY_FDIR_FILTER:
-		valid_len = sizeof(struct virtchnl_fdir_query);
-		break;
 	case VIRTCHNL_OP_GET_QOS_CAPS:
 		break;
 	case VIRTCHNL_OP_CONFIG_QUEUE_TC_MAP:
-- 
2.33.0


  parent reply	other threads:[~2021-09-07  8:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  7:16 [dpdk-dev] [PATCH v1 1/4] common/iavf: add QFI fields for GTPU UL and DL Haiyue Wang
2021-08-17  7:16 ` [dpdk-dev] [PATCH v1 2/4] common/iavf: add proto hdr field support for L4 checksum Haiyue Wang
2021-08-29 11:38   ` Zhang, Qi Z
2021-09-03 10:43   ` Ferruh Yigit
2021-08-17  7:16 ` [dpdk-dev] [PATCH v1 3/4] common/iavf: remove the FDIR query opcode Haiyue Wang
2021-08-29 11:38   ` Zhang, Qi Z
2021-08-17  7:16 ` [dpdk-dev] [PATCH v1 4/4] common/iavf: update the driver version Haiyue Wang
2021-08-29 11:38   ` Zhang, Qi Z
2021-08-29 11:37 ` [dpdk-dev] [PATCH v1 1/4] common/iavf: add QFI fields for GTPU UL and DL Zhang, Qi Z
2021-09-03 10:41 ` Ferruh Yigit
2021-09-06  5:51 ` [dpdk-dev] [PATCH v2 0/4] iavf base code update Haiyue Wang
2021-09-06  5:51   ` [dpdk-dev] [PATCH v2 1/4] common/iavf: add QFI fields for GTPU UL and DL Haiyue Wang
2021-09-06  5:51   ` [dpdk-dev] [PATCH v2 2/4] common/iavf: add proto hdr field support for L4 checksum Haiyue Wang
2021-09-06  5:51   ` [dpdk-dev] [PATCH v2 3/4] common/iavf: remove the FDIR query opcode Haiyue Wang
2021-09-06  5:51   ` [dpdk-dev] [PATCH v2 4/4] common/iavf: update the driver version Haiyue Wang
2021-09-07  7:33 ` [dpdk-dev] [PATCH v3 0/4] iavf base code update Haiyue Wang
2021-09-07  7:33   ` [dpdk-dev] [PATCH v3 1/4] common/iavf: add QFI fields for GTPU UL and DL Haiyue Wang
2021-09-07  7:33   ` [dpdk-dev] [PATCH v3 2/4] common/iavf: enable hash calculation based on L4 checksum Haiyue Wang
2021-09-07  7:33   ` Haiyue Wang [this message]
2021-09-07  7:33   ` [dpdk-dev] [PATCH v3 4/4] common/iavf: update the driver version Haiyue Wang
2021-09-13  0:46   ` [dpdk-dev] [PATCH v3 0/4] iavf base code update Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210907073304.73548-4-haiyue.wang@intel.com \
    --to=haiyue.wang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jingjing.wu@intel.com \
    --cc=qi.z.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).